False passes in tests

[eamelink]

It appears that immutable specs are used together with scopes. This gives false positives; scopes always succeed. See this commit for the proof:
87c0d46

With this commit, the tests still pass.

It looks like something changed in newer specs2 versions, which is used for the Play 2.3 branch: https://github.com/Rhinofly/play-elasticsearch-client/tree/play-2.3

This branch does give errors during testing and it looks like they are real errors.

[EECOLOR]

There is a good chance this is caused by the WithTestIndexWithSimpleAnalysis implementation. The AsResult(t) call should actually be AsResult.effectively(t). Could you check if that solves the problem?

[eamelink]

It does. Pushed the change to master, which now fails:

[error] Error: Total 278, Failed 7, Errors 1, Passed 270
[error] Failed tests:
[error]     fly.play.elasticsearch.ElasticSearchQueryTests
[error] Error during tests:
[error]     fly.play.elasticsearch.analysis.AnalysisTests

[eamelink]

If @EECOLOR or @nverwer has time to look into this that would be awesome. If not, I'll pick it up this week.

[nverwer]

I will try to have a look at it.

[nverwer]

Apparently 'effectively' fixes the tests (no idea why). I am now working on fixinf the code, so the tests pass.

[EECOLOR]

I am not sure if we now both have fixed stuff. I pushed the changes to master. The tests are now completely green in master. There was one tricky bug with enumerations, see: 5dbaf46

That one could cause problems that are virtually undetectable.

[EECOLOR]

The other tests were quite simple to fix.

188effb
8e3a026

[EECOLOR]

One effectively was missing. This caused another error:

have a FuzzyLikeThisQuery sub-class
x that does not find documents when searching for an exact match
'2' is not equal to '0' (QueryTests.scala:251)

According to the elasticsearch documentation the fuzziness if set 0..1 should be an exact match. I do not think this is a problem of the library. When I manually search (using sense) with the following query I get the same results:

GET indexname/typename/_search
{
  "query": {
    "fuzzy_like_this" : {
        "fields" : ["test"],
        "like_text" : "tree",
        "fuzziness" : 0
    }
  } 
}

@nverwer can you confirm that this is a problem of elasticsearch?