MEDIUM: Wildlife yieldMalus self-assignment never clears

[TheCodingDad-TisonK]

Severity: MEDIUM

File: src/utils/animalEvents.lua:259
Multiplayer: No
Fix Complexity: TRIVIAL
Confidence: 100% (Wizard-verified + source-verified)

Description

The onEnd handler contains s.yieldMalus = s.yieldMalus — a no-op self-assignment instead of clearing the value.

Impact

After wildlife_pest_invasion ends, player permanently loses 5%-25% field yield for rest of session.

Fix

Change to s.yieldMalus = 0 in onEnd.

---

Source: Consolidated Bug Review 2026-07-26, RWE-003

[github-actions]

Hey @TheCodingDad-TisonK, an unexpected event has arrived — your issue report! ⚡

@TheCodingDad-TisonK has been notified and will investigate as soon as possible.

To help reproduce the chaos, please confirm:

• You are running the latest version of Random World Events (visible in the mod manager)
• Your issue includes the relevant [RWE] lines from log.txt
  • Log location: Documents/My Games/FarmingSimulator2025/log.txt
  • Search for [RWE] and paste the relevant section here
• If this involves a specific event — note the event type, intensity level, and what in-game day it occurred on
• You have searched existing issues for a similar report

Note: Issues without a log snippet are difficult to investigate and may be closed. Event trigger bugs especially need log data to trace the sequence.

[TheCodingDad-TisonK]

Source-verified. animalEvents.lua line 259 now reads s.yieldMalus = 0 in the onEnd handler, correctly clearing the wildlife pest invasion yield penalty. The self-assignment no-op has been fixed. Fixed on development (commit 7c2bf94). Not yet merged to master.

[TheCodingDad-TisonK]

Resolved in development branch (commit 7c2bf94). yieldMalus self-assignment replaced with = 0. Awaiting merge to master via PR.