HIGH: Pay-mode switch triggers catch-up payment exploit

[TheCodingDad-TisonK]

Severity: HIGH

File: src/IncomeSystem.lua:280-302 + src/Settings.lua:84-88
Multiplayer: No
Fix Complexity: SIMPLE
Confidence: 100% (source-verified)

Description

checkHourly() pays catch-up for gap between self.lastHour and currentHour (clamped to 24). setPayMode() does not reset the inactive mode's timer state.

Impact

After N days in Daily mode, switching to Hourly triggers catch-up: (3 days * 24) + (15 - 10) = 77, clamped to 24. At Easy/10x ($50,000/interval), player receives $1,200,000 instantly.

Fix

Reset both lastHour and lastDay to current values in setPayMode().

---

Source: Consolidated Bug Review 2026-07-26, IM-001

[github-actions]

Hey @TheCodingDad-TisonK, the accountant is on it. 📊

Thanks for filing this report — @TheCodingDad-TisonK has been notified and will review your case as soon as possible.

Before the books are opened, please confirm:

• You are running the latest version of Income Mod (visible in the mod manager)
• Your issue includes the relevant [IncomeMod] lines from log.txt
  • Log location: Documents/My Games/FarmingSimulator2025/log.txt
  • Search for [IncomeMod] and paste the relevant section here
• If this involves a specific income category (crops, animals, contracts, etc.) — mention which one and what amounts are expected vs. shown
• You have searched existing issues for a similar report

Note: Issues without a log snippet are difficult to investigate and may be closed. Income discrepancies often require log data to trace.

[TheCodingDad-TisonK]

Investigation confirmed: src/IncomeSystem.lua:280-302 + src/Settings.lua:84-88 — checkHourly() paid catch-up for gap between lastHour and currentHour, and setPayMode() did not reset inactive timer state. Switching from Daily to Hourly after N days triggered massive catch-up payout. Fixed in commit 6961279 by resetting both lastHour and lastDay to current values in setPayMode(). This has been resolved in the latest development branch and merged to main via PR #32. Closing is recommended.

[TheCodingDad-TisonK]

Resolved in development branch, merged to main via PR #32.