feat(discord): Handle missing permissions for webhook creation (#129)

Co-authored-by: seer-by-sentry[bot] <157164994+seer-by-sentry[bot]@users.noreply.github.com>

Author: seer-by-sentry[bot]

src/routes/subscriptions/discord/webhooks.ts

@@ -9,6 +9,7 @@ import { ErrorCode } from "@/schema/errors/ErrorCode"
 import { zInsufficientPermissionsError } from "@/schema/errors/InsufficientPermissionsError"
 import { zInvalidDiscordAuthError } from "@/schema/errors/InvalidDiscordAuthError"
 import {
+    DiscordWebhookMissingPermissionsError,
     deleteDiscordWebhook,
     getDiscordWebhookStatus,
     upsertDiscordWebhook
@@ -47,13 +48,22 @@ export const putDiscordWebhookRoute = new RaidHubRoute({
                 message: "Forbidden" as const
             })
         }
-        return RaidHubRoute.ok(
-            await upsertDiscordWebhook({
-                ...req.body,
-                guildId,
-                channelId
-            })
-        )
+        try {
+            return RaidHubRoute.ok(
+                await upsertDiscordWebhook({
+                    ...req.body,
+                    guildId,
+                    channelId
+                })
+            )
+        } catch (err) {
+            if (err instanceof DiscordWebhookMissingPermissionsError) {
+                return RaidHubRoute.fail(ErrorCode.InsufficientPermissionsError, {
+                    message: "Forbidden" as const
+                })
+            }
+            throw err
+        }
     }
 })
 

src/services/subscriptions/discord-webhooks.ts

@@ -3,6 +3,13 @@ import { Logger } from "@/lib/utils/logging"
 
 const logger = new Logger("DISCORD_SUBSCRIPTIONS_SERVICE")
 
+export class DiscordWebhookMissingPermissionsError extends Error {
+    constructor(channelId: string) {
+        super(`Discord bot is missing permissions to create a webhook in channel ${channelId}`)
+        this.name = "DiscordWebhookMissingPermissionsError"
+    }
+}
+
 export type DiscordWebhookPlayerTargetInput = {
     membershipId: string
     requireFresh?: boolean
@@ -113,6 +120,9 @@ const createDiscordWebhook = async (
 
     if (!response.ok) {
         const detail = await response.text()
+        if (response.status === 403) {
+            throw new DiscordWebhookMissingPermissionsError(body.channelId)
+        }
         throw new Error(`Discord webhook create failed with status ${response.status}: ${detail}`)
     }