From 6b0537c4c73bf7b19863a9b403eece0714a4d894 Mon Sep 17 00:00:00 2001 From: daniellegillai Date: Fri, 29 May 2026 15:33:48 -0700 Subject: [PATCH 1/3] Fix dst docstring for gamma contrast and convert to --- python/src/operators/py_op_convert_to.cpp | 2 +- python/src/operators/py_op_gamma_contrast.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/python/src/operators/py_op_convert_to.cpp b/python/src/operators/py_op_convert_to.cpp index 9100ce3f..e85efb6c 100644 --- a/python/src/operators/py_op_convert_to.cpp +++ b/python/src/operators/py_op_convert_to.cpp @@ -72,7 +72,7 @@ void PyOpConvertTo::Export(py::module& m) { Refer to the rocCV C++ API reference for more information on this operation. Args: - dst (rocpycv.Tensor): The output tensor with gamma correction applied. + dst (rocpycv.Tensor): Output tensor which image results are written to. src (rocpycv.Tensor): Input tensor containing one or more images. alpha (double, optional): Scalar for output data. Defaults to 1.0. beta (double, optional): Offset for the data. Defaults to 0.0. diff --git a/python/src/operators/py_op_gamma_contrast.cpp b/python/src/operators/py_op_gamma_contrast.cpp index 4ebe0930..c6f5e75f 100644 --- a/python/src/operators/py_op_gamma_contrast.cpp +++ b/python/src/operators/py_op_gamma_contrast.cpp @@ -72,7 +72,7 @@ void PyOpGammaContrast::Export(py::module& m) { Refer to the rocCV C++ API reference for more information on this operation. Args: - dst (rocpycv.Tensor): The output tensor with gamma correction applied. + dst (rocpycv.Tensor): Output tensor which image results are written to. src (rocpycv.Tensor): Input tensor containing one or more images. gamma (float): Gamma correction value to apply to the images. stream (rocpycv.Stream, optional): HIP stream to run this operation on. From 756785cccd91f68e51eb05dd4a59e927d7d4e758 Mon Sep 17 00:00:00 2001 From: daniellegillai Date: Tue, 2 Jun 2026 12:50:07 -0700 Subject: [PATCH 2/3] fixed GoldenConvertTo documentation to have correct tparams --- tests/roccv/cpp/src/tests/operators/test_op_convert_to.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/roccv/cpp/src/tests/operators/test_op_convert_to.cpp b/tests/roccv/cpp/src/tests/operators/test_op_convert_to.cpp index eaa714a9..e755212b 100644 --- a/tests/roccv/cpp/src/tests/operators/test_op_convert_to.cpp +++ b/tests/roccv/cpp/src/tests/operators/test_op_convert_to.cpp @@ -36,8 +36,10 @@ namespace { /** * @brief Verified golden C++ model for the ConvertTo operation. * - * @tparam T Vectorized datatype of the image's pixels. - * @tparam BT Base type of the image's data. + * @tparam SRC_DT Vectorized datatype of the input image's pixels. + * @tparam DEST_DT Vectorized datatype of the output image's pixels. + * @tparam BT_SRC Base type of the input image's data. + * @tparam BT_DEST Base type of the output image's data. * @param[in] input An input vector containing image data. * @param[in] batchSize The number of images in the batch. * @param[in] width Image width. From 30e2f2d4157f0f964d887eea95919b81e8a966c6 Mon Sep 17 00:00:00 2001 From: daniellegillai Date: Tue, 16 Jun 2026 09:27:23 -0700 Subject: [PATCH 3/3] Fixed param documentation in bilateral filter cpp test --- .../cpp/src/tests/operators/test_op_bilateral_filter.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/roccv/cpp/src/tests/operators/test_op_bilateral_filter.cpp b/tests/roccv/cpp/src/tests/operators/test_op_bilateral_filter.cpp index f208962c..57239eb2 100644 --- a/tests/roccv/cpp/src/tests/operators/test_op_bilateral_filter.cpp +++ b/tests/roccv/cpp/src/tests/operators/test_op_bilateral_filter.cpp @@ -39,19 +39,20 @@ namespace { * @brief Verified golden C++ model for the bilateral filtering operation on one image. * * @tparam T Vectorized datatype of the image's pixels. + * @tparam BorderMode Border pixel extrapolation method + * @tparam BT Base type of the image data. * @param[in] input Input tensor containing image data. * @param[out] output Output tensor containing normalized image data. * @param[in] diameter Diameter of the work region * @param[in] sigmaColor Sigma component of Gaussian exponent for color difference * @param[in] sigmaSpace Sigma component of Gaussian exponent for pixel spatial distance - * @param[in] borderMode Border pixel extrapolation method * @param[in] borderValue Color for constant border mode * @return None. */ -template > +template > void GenerateGoldenBilateral(std::vector& input, std::vector& output, int32_t batchSize, Size2D imageSize, int diameter, float sigmaColor, float sigmaSpace, T borderValue) { - BorderWrapper src(ImageWrapper(input, batchSize, imageSize.w, imageSize.h), borderValue); + BorderWrapper src(ImageWrapper(input, batchSize, imageSize.w, imageSize.h), borderValue); ImageWrapper dst(output, batchSize, imageSize.w, imageSize.h); using namespace roccv::detail; using Worktype = MakeType>; @@ -112,6 +113,7 @@ void GenerateGoldenBilateral(std::vector& input, std::vector& output, in * @brief Tests correctness of the bilateral filter operator, comparing it against a generated golden result. * * @tparam T Underlying datatype of the image's pixels. + * @tparam BorderMode Border pixel extrapolation method * @tparam BT Base type of the image data. * @param[in] batchSize Number of images in the batch. * @param[in] width Width of each image in the batch.