From 310a63f05fe928d80ccea0e3bc8d7125f6ad1084 Mon Sep 17 00:00:00 2001 From: Dana Robinson Date: Thu, 19 Mar 2026 15:56:23 -0600 Subject: [PATCH 1/3] Switch default CMake build mode to RelWithDebInfo Changes from Debug --- CHANGELOG.md | 1 + CMakeLists.txt | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 431de028..2707832a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ * `AIS_BUILD_EXAMPLES` has been renamed to `AIS_INSTALL_EXAMPLES` * `AIS_USE_SANITIZERS` now also enables the following sanitizers: integer, float-divide-by-zero, local-bounds, vptr, nullability (in addition to address, leak, and undefined). Sanitizers should also now emit usable stack trace info. * Added check in the Fastpath/AIS backend to ensure the HIP Runtime is initialized. This avoids causing a segfault in the HIP Runtime. +* The default CMake build type was changed from `Debug` to `RelWithDebInfo` ### Removed * The rocFile library has been completely removed and the code is now a part of hipFile. diff --git a/CMakeLists.txt b/CMakeLists.txt index f6c50e6b..9091aa4b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -11,7 +11,7 @@ cmake_minimum_required(VERSION 3.21) # # NOTE: This has to be done BEFORE the project is declared! if(NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES) - set(CMAKE_BUILD_TYPE Debug CACHE STRING "Build type") + set(CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "Build type") endif() # Set the library version in a variable so we can use From d819d12d479d7d869a38b27e8f7ddc407277ff18 Mon Sep 17 00:00:00 2001 From: Dana Robinson Date: Thu, 19 Mar 2026 17:05:44 -0600 Subject: [PATCH 2/3] Update comment --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 9091aa4b..c51c1fc8 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -7,7 +7,7 @@ # CMake version according to latest ROCm platform requirements cmake_minimum_required(VERSION 3.21) -# Set the default build type to Debug +# Set the default CMake build type # # NOTE: This has to be done BEFORE the project is declared! if(NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES) From c5f6f08ece776899f3f2c0779c111e06ea5642ca Mon Sep 17 00:00:00 2001 From: Dana Robinson Date: Tue, 24 Mar 2026 17:01:06 -0600 Subject: [PATCH 3/3] Change build type to Debug in CI RelWithDebInfo emits warnings, so go back to Debug while we wait for fixes. When the fixes are in, the CI will be adapted to build both Debug and RelWithDebInfo. --- .github/workflows/build-ais-nvidia.yml | 3 +-- .github/workflows/build-ais.yml | 1 + .github/workflows/hipfile-nvidia.yml.disabled | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-ais-nvidia.yml b/.github/workflows/build-ais-nvidia.yml index 016274e2..10d8d183 100644 --- a/.github/workflows/build-ais-nvidia.yml +++ b/.github/workflows/build-ais-nvidia.yml @@ -84,7 +84,6 @@ jobs: -DCMAKE_CXX_COMPILER="${_AIS_INPUT_CXX_COMPILER}" \ -DCMAKE_CXX_FLAGS="-Werror" \ -DCMAKE_HIP_PLATFORM=nvidia \ - -DAIS_BUILD_DOCS=ON \ .. ' - name: Build hipFile for the NVIDIA platform (${{ matrix.supported_compilers }}) @@ -114,4 +113,4 @@ jobs: # uses: ./.github/workflows/hipfile-nvidia.yml # needs: build_AIS_image # with: -# platform: ${AIS_INPUT_PLATFORM} \ No newline at end of file +# platform: ${AIS_INPUT_PLATFORM} diff --git a/.github/workflows/build-ais.yml b/.github/workflows/build-ais.yml index 1a42b536..5a9ead9e 100644 --- a/.github/workflows/build-ais.yml +++ b/.github/workflows/build-ais.yml @@ -140,6 +140,7 @@ jobs: export CPACK_DEBIAN_PACKAGE_RELEASE="${JOB_DESIGNATOR}${SLES_BUILD_ID_PREFIX}${BUILD_ID}~$(source /etc/os-release && echo ${VERSION_ID})" export CPACK_RPM_PACKAGE_RELEASE="${JOB_DESIGNATOR}${SLES_BUILD_ID_PREFIX}${BUILD_ID}" cmake \ + -DCMAKE_BUILD_TYPE=Debug \ -DCMAKE_CXX_COMPILER="${_AIS_INPUT_CXX_COMPILER}" \ -DCMAKE_CXX_FLAGS="-Werror" \ -DCMAKE_HIP_ARCHITECTURES="${{ env.AIS_HIP_ARCHITECTURES }}" \ diff --git a/.github/workflows/hipfile-nvidia.yml.disabled b/.github/workflows/hipfile-nvidia.yml.disabled index 6bf62587..02f1ed97 100644 --- a/.github/workflows/hipfile-nvidia.yml.disabled +++ b/.github/workflows/hipfile-nvidia.yml.disabled @@ -74,7 +74,6 @@ jobs: -DCMAKE_CXX_COMPILER=g++ \ -DCMAKE_CXX_FLAGS="-Werror" \ -DCMAKE_HIP_PLATFORM=nvidia \ - -DAIS_BUILD_DOCS=ON \ -DAIS_CAPABLE_DIR=\"${ROCTMPDIR}\" \ .. "