Skip to content

Commit 9c2dd29

Browse files
jplehrillsilin
authored andcommitted
[rocm-libraries] ROCm/rocm-libraries#4419 (commit e241f8b)
[CK] Work around staging compiler lifetime warning ## Motivation The staging compiler enables lifetime-safety warnings and we already worked around a few of them. This works around a few more instances that came up recently on gfx950 builds. The initial PR that resolved most issues: #3640 ## Technical Details This follows the pattern to locally ignore the newly added lifetime-safety warnings that were moved from experimental to production in upstream LLVM. As a result, CK turned them on and treats them as errors, which prevents the staging compiler from building CK. ## Test Plan ## Test Result ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. Co-authored-by: Illia Silin <98187287+illsilin@users.noreply.github.com>
1 parent dae352e commit 9c2dd29

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

include/ck/utility/functional2.hpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@
88
#include "ck/utility/tuple.hpp"
99
#include "ck/utility/type.hpp"
1010

11+
#pragma clang diagnostic push
12+
#pragma clang diagnostic ignored "-Wlifetime-safety-intra-tu-suggestions"
13+
1114
namespace ck {
1215

1316
namespace detail {
@@ -113,3 +116,4 @@ struct identity
113116
};
114117

115118
} // namespace ck
119+
#pragma clang diagnostic pop

library/src/tensor_operation_instance/gpu/gemm_multi_abd/device_gemm_wmma_multi_abd_gelu_bf16_i8_bf16_mk_kn_mn_v1_instance.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212

1313
#include "ck/library/tensor_operation_instance/add_device_operation_instance.hpp"
1414

15+
#pragma clang diagnostic push
16+
#pragma clang diagnostic ignored "-Wlifetime-safety-intra-tu-suggestions"
17+
1518
namespace ck {
1619
namespace tensor_operation {
1720
namespace device {
@@ -57,3 +60,4 @@ void add_device_gemm_wmma_multi_abd_bf16_i8_bf16_mk_kn_mn_gelu_v1_instances(
5760
} // namespace device
5861
} // namespace tensor_operation
5962
} // namespace ck
63+
#pragma clang diagnostic pop

0 commit comments

Comments
 (0)