From 198d5a46295ee4185249925010591b09506ce08a Mon Sep 17 00:00:00 2001 From: Edgar Gabriel Date: Thu, 26 Feb 2026 21:43:00 +0000 Subject: [PATCH 1/2] update ROCm README file we need some additional packages to be installed, and we need to set at the moment -Wno-error when compiling nixlbench --- README_rocm.md | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/README_rocm.md b/README_rocm.md index aeee9e6a..01902b84 100644 --- a/README_rocm.md +++ b/README_rocm.md @@ -6,7 +6,7 @@ The original code can be found at https://github.com/ai-dynamo/nixl. ## Prerequisites for source build ### Ubuntu: ```bash -sudo apt install build-essential cmake pkg-config +sudo apt install build-essential cmake pkg-config libcxxopts-dev libcpprest-dev sudo apt install libaio-dev liburing-dev pip3 install meson==0.64.0 @@ -37,7 +37,7 @@ make -j RIXL can use ETCD for metadata distribution and coordination between nodes in distributed environments. To use ETCD with RIXL: #### ETCD Server and Client ``` -sudo apt install etcd etcd-server etcd-client +sudo apt install etcd-server etcd-client ``` #### ETCD CPP API @@ -77,6 +77,11 @@ Only the UCX backend is support with ROCm in nixlbench as of today. The equivale ### Build & install ```bash cd benchmark/nixlbench + +#The following line is temporarily required to circumvent a ROCm header file +#incompatibility issue. +export CXXFLAGS="-Wno-error" + meson setup build \ -Dnixl_path=${_rixl_install_dir} \ -Drocm_path=/opt/rocm \ From b685ea9c806eda90f875df1a1efc4ddc144ec5f4 Mon Sep 17 00:00:00 2001 From: Edgar Gabriel Date: Tue, 3 Mar 2026 16:15:36 -0600 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- README_rocm.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README_rocm.md b/README_rocm.md index 01902b84..19c41202 100644 --- a/README_rocm.md +++ b/README_rocm.md @@ -6,7 +6,7 @@ The original code can be found at https://github.com/ai-dynamo/nixl. ## Prerequisites for source build ### Ubuntu: ```bash -sudo apt install build-essential cmake pkg-config libcxxopts-dev libcpprest-dev +sudo apt install build-essential cmake pkg-config libcxxopts-dev sudo apt install libaio-dev liburing-dev pip3 install meson==0.64.0 @@ -78,8 +78,8 @@ Only the UCX backend is support with ROCm in nixlbench as of today. The equivale ```bash cd benchmark/nixlbench -#The following line is temporarily required to circumvent a ROCm header file -#incompatibility issue. +# The following line is temporarily required to circumvent a ROCm header file +# incompatibility issue. export CXXFLAGS="-Wno-error" meson setup build \