Using `performance.catalog_page_size` for UI table size

[RouxAntoine]

Hi,

In the configuration I see this property performance.catalog_page_size set to 100 for exemple.
I use to think this is a settings to change the number of repo entries per page.

After investigation it is more to set the number of item retrieve in the puller of the registry.

What do you think if I contribute to the code and use this property in the UI too ?

Or other possibility create a ui key and a new property to customize the ui item per page.

Waiting for your opinion, thanks

[RouxAntoine]

Pull request with solution 1
#105

[roman-vynar]

This setting was designed to throttle catalog fetch request and not related to UI at all.
For AWS, it is pretty much always fast, for Azure it is very slow with the same number of repos in the catalog comparing with AWS.

What's the use case to make UI page size configurable? Just trying to understand.

[RouxAntoine]

Hi, Thanks for the reply,

The use case is just to have customizable default UI page size to avoid having to change page each time.

Ok if it is not intended for UI. What do you think of my second suggestion to introduce a dedicated configuration

Maybe something like:

ui:
  default_page_size: 10

[roman-vynar]

Sounds good.

[RouxAntoine]

New pull request #106
I don't use the new default_page_size for number of tag per page but I can if you find it relevant

[roman-vynar]

Yes, it should use the same option for tag page as well.
Also what happens if someones put whatever not listed, e.g. 11?

[RouxAntoine]

I push the change to apply this property to tag and event log table.

Good question regarding not listed value.
I test it and this properly print the 11 line. but the scroll down at bottom is blank. But contain the other possible page size.

[RouxAntoine]

Hi @roman-vynar I change the pull request to avoid empty element in the list in case of the config reference an unknown value.
The trick is I add the config defined value in the list of possible value.

Some tricky sort is needed too to have a sorted list and having the Show all option at the end.

Open to your feedback