You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
release: 0.24.0 — per-catalog attach options, and a gated ATTACH that answers
`attach/attach_options_required.test` was skipping here: upstream 1f1d7b1 split
the `required` assertions out of the shared attach_options_echo.test behind
VGI_ATTACH_OPTIONS_REQUIRED_WORKER, because the catalog they need existed only
in the Python fixture. This grows the same catalog.
- `Worker.ExtraCatalog` gains a 5th component, `attachOptions`: an auxiliary
catalog advertises its own specs on its `catalog_catalogs()` row and enforces
them at its own attach. A 4-arg convenience constructor keeps every existing
call site source-compatible. Deliberately per-catalog rather than folded into
`Worker.attachOptions(...)` — one worker serves a catalog that requires an
option next to one that takes none, which is exactly what the test asserts.
- Fixture: `AttachOptionsFixture.requiredSpecs()` (`api_key` required, `region`
defaulting) as the `attach_options_required` catalog of the attach-options
worker, mirroring vgi-python's `RequiredAttachOptions`. ci/run-integration.sh
points the env var at that same worker on both lanes, so the test runs.
- The refusal path had never been exercised in Java, and it HUNG.
`AttachOptionRequirements` throws `RpcError("ValueError", …)`, whose
`errorKind()` is null as documented, and vgirpc wrote that null into the error
batch's metadata — throwing in the flatbuffer writer, so the batch never
reached the wire and the client waited on a response that would never come.
Fixed in vgirpc 0.21.1; pinned here (build.gradle.kts + VGI_RPC_JAVA_REF).
Global functions needed no work: they shipped in 0.22.0 and both
global_functions tests pass against an extension carrying vgi 21fdd4e. CI's red
on them is the community extension lagging the consuming side — see CLAUDE.md.
Local: launch 296 files / 268 pass / 28 skip / 0 fail (attach_options_required
now among the passes); the two attach tests also verified under shm and over
HTTP. `:vgi:test` green with a new ExtraCatalogAttachOptionsTest; javadoc clean.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
0 commit comments