Commit 796de7b
committed
ci: pin vgi-rpc-java past the LargeBinary fix, and re-pin VGI_REF
Two unrelated CI failures, both stale pins rather than Java bugs.
PlanClientRoundTripTest failed in CI and passed locally on the same JDK and
commit. Line 262 is `vgi.init(...)`, redeeming a plan split, and
InitRequest.split_tokens is a List<byte[]> annotated large_binary. vgi-rpc-java
v0.23.0's Marshalling.writeListElement has no LargeBinary case, so it hits
`default -> throw new IllegalArgumentException("unsupported list element type:
LargeBinary")`. Locally settings.gradle.kts composite-includes a checkout
sitting two commits past v0.23.1, one of which is 306e182 "support LargeBinary
list elements" — whose own message names this test. CI checked out v0.23.0 and
never saw it. Reproduced byte-for-byte by pointing the composite at v0.23.0.
Bumping to the newest TAG would not have fixed it: v0.23.1 is a0309fe, which
predates 306e182, and upstream tags stop there. So both workflows pin the
untagged SHA — the minimal revision carrying the fix.
Separately, all three integration lanes failed on cache/secret_ineligible.test
and macro/macros.test, both asserting duckdb_logs events. Those assertions
landed upstream on 2026-08-26 together with the C++ client code that emits them
(27b6ded, a0eb66b, f10b9bc). The lane took VGI_REF: main so it got the TESTS,
while the extension comes from `INSTALL vgi FROM community`, published from
40891ac — before all three. The binary simply doesn't emit those events. Both
files pass locally against a from-source extension, which clears the Java
worker: nothing is missing here. ci/README.md predicted this exact failure mode;
`VGI_REF: main` defeated it. Re-pinned to 40891ac, the commit the last green run
used, restoring the SHA pin the file originally had.
Bump VGI_REF by hand when the community channel republishes vgi; the
authoritative value is repo.ref in that channel's description.yml.
KNOWN ISSUE this exposed, not fixed here: vgi/build.gradle.kts declares
farm.query:vgirpc:0.23.0, and no PUBLISHED vgirpc carries the LargeBinary fix.
CI's composite substitution hides it, but released vgi-java 0.27.0 therefore
cannot redeem a table_function_plan split for a downstream JVM consumer. The
remedy is a vgi-rpc-java release >= 306e182, then bumping the declared
dependency and these two pins together.1 parent cee37bf commit 796de7b
3 files changed
Lines changed: 66 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
31 | 45 | | |
32 | 46 | | |
33 | 47 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
32 | 49 | | |
33 | 50 | | |
34 | 51 | | |
35 | 52 | | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
43 | 60 | | |
44 | 61 | | |
45 | 62 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | | - | |
| 117 | + | |
| 118 | + | |
118 | 119 | | |
119 | 120 | | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
120 | 137 | | |
121 | 138 | | |
122 | 139 | | |
| |||
0 commit comments