Skip to content

Commit 06e6ac8

Browse files
rustyconoverclaude
andcommitted
fix(example): drop uncommitted narrow_bind wiring from example worker
The catalog source_url + schema-tags commit (a773896) accidentally folded in local WIP that wires the `examples/narrow_bind` fixture into the example worker, but that package isn't committed — so `go vet ./...` fails in CI ("no required module provides package .../examples/narrow_bind"). Remove the narrow_bind import/alias/handlers/registration from main.go, keeping the metadata additions (WithCatalogInfo source_url + WithSchemaTags). The narrow_bind WIP remains uncommitted in the working tree. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent a773896 commit 06e6ac8

1 file changed

Lines changed: 4 additions & 28 deletions

File tree

‎cmd/vgi-example-worker/main.go‎

Lines changed: 4 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import (
1414

1515
"github.com/Query-farm/vgi-go/examples/accumulate"
1616
"github.com/Query-farm/vgi-go/examples/all"
17-
"github.com/Query-farm/vgi-go/examples/narrow_bind"
1817
"github.com/Query-farm/vgi-go/examples/schema_reconcile"
1918
"github.com/Query-farm/vgi-go/examples/table"
2019
"github.com/Query-farm/vgi-go/internal/covflush"
@@ -97,7 +96,7 @@ func main() {
9796
}),
9897
// Cross-language reproducer catalogs share this binary; ATTACH
9998
// against any of these names succeeds (functions are catalog-agnostic).
100-
vgi.WithCatalogAliases("projection_repro", "schema_reconcile", narrow_bind.CatalogName),
99+
vgi.WithCatalogAliases("projection_repro", "schema_reconcile"),
101100
// The accumulate fixture catalog is discoverable (data version 2.0.0)
102101
// and isolated per ATTACH (random scope); its functions are registered
103102
// catalog-scoped below so they don't leak into the example catalog.
@@ -107,27 +106,9 @@ func main() {
107106
// served by handlers (not declared via RegisterCatalogTable). The four
108107
// handlers below are wired in registration order; they short-circuit on
109108
// any other catalog name.
110-
// Each option is single-valued, so the schema_reconcile and narrow_bind
111-
// fixtures are composed: try the first, fall through to the second when
112-
// it declines (returns false).
113-
vgi.WithSchemaContentsHandler(func(attach []byte, schema string) ([]vgi.SerializedSchemaItem, bool) {
114-
if items, ok := schema_reconcile.SchemaContentsHandler(attach, schema); ok {
115-
return items, true
116-
}
117-
return narrow_bind.SchemaContentsHandler(attach, schema)
118-
}),
119-
vgi.WithAttachTableGetHandler(func(attach []byte, schema, name string, atUnit, atValue *string) ([]byte, bool, error) {
120-
if data, ok, err := schema_reconcile.AttachTableGetHandler(attach, schema, name, atUnit, atValue); ok || err != nil {
121-
return data, ok, err
122-
}
123-
return narrow_bind.AttachTableGetHandler(attach, schema, name, atUnit, atValue)
124-
}),
125-
vgi.WithAttachScanFunctionGetHandler(func(attach []byte, schema, name string, atUnit, atValue *string) (*vgi.ScanFunctionResult, bool, error) {
126-
if res, ok, err := schema_reconcile.AttachScanFunctionGetHandler(attach, schema, name, atUnit, atValue); ok || err != nil {
127-
return res, ok, err
128-
}
129-
return narrow_bind.AttachScanFunctionGetHandler(attach, schema, name, atUnit, atValue)
130-
}),
109+
vgi.WithSchemaContentsHandler(schema_reconcile.SchemaContentsHandler),
110+
vgi.WithAttachTableGetHandler(schema_reconcile.AttachTableGetHandler),
111+
vgi.WithAttachScanFunctionGetHandler(schema_reconcile.AttachScanFunctionGetHandler),
131112
vgi.WithAttachScanBranchesGetHandler(multiBranchScanBranchesGet),
132113
vgi.WithAttachWriteFunctionGetHandler(schema_reconcile.AttachWriteFunctionGetHandler),
133114
vgi.WithSecretTypes(
@@ -196,11 +177,6 @@ func main() {
196177
// the example catalog and preserves its function inventory).
197178
accumulate.Register(w)
198179

199-
// Register the narrow_bind reproducer fixture (catalog-scoped). Its
200-
// scan functions back the mismatch/consistent tables advertised by the
201-
// composed catalog handlers above.
202-
narrow_bind.RegisterAll(w)
203-
204180
// Writable catalog (in-memory, per-process state). Gated off by default so
205181
// the example worker's function inventory matches the reference vgi-python
206182
// worker; set VGI_WORKER_ENABLE_WRITABLE=1 to exercise the writable tests.

0 commit comments

Comments
 (0)