Skip to content

override_redirect feature cannot be set to disabled due to validation typo #11107

Description

@ts-klassen

Qubes OS release

Qubes OS 4.3

Brief summary

gui-override-redirect are either allow or disabled. But the validator at override_redirect expects ["allow", "disable"].
If you set it to disabled (the correct spelling with d), the flag will be ignored.

Steps to reproduce

  1. Run qvm-features untrusted gui-override-redirect disabled on dom0
  2. Start untrusted qube
  3. It will show a warning that it is ignored and you can popup type=Gtk.WindowType.POPUP kind of window without the close button

Expected behavior

qvm-features <QUBE> gui-override-redirect disabled would disable override redirect windows.

Actual behavior

qvm-features <QUBE> gui-override-redirect disabled is ignored and allows override redirect windows.

Additional information

I've pached qvm_start_daemon.py locally and it worked after restarting the daemon.

user@dom0:/usr/lib/python3.13/site-packages/qubesadmin/tools$ diff -u qvm_start_daemon.py.orig qvm_start_daemon.py
--- qvm_start_daemon.py.orig	2026-09-05 13:02:29.876083070 +0900
+++ qvm_start_daemon.py	2026-09-05 13:02:59.356764100 +0900
@@ -111,7 +111,7 @@
 GUI_DAEMON_OPTIONS = [
     ("allow_fullscreen", "bool", (lambda x: isinstance(x, bool))),
     ("override_redirect_protection", "bool", (lambda x: isinstance(x, bool))),
-    ("override_redirect", "str", (lambda x: x in ["allow", "disable"])),
+    ("override_redirect", "str", (lambda x: x in ["allow", "disabled"])),
     ("allow_utf8_titles", "bool", (lambda x: isinstance(x, bool))),
     ("secure_copy_sequence", "str", validator_key_sequence),
     ("secure_paste_sequence", "str", validator_key_sequence),

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

C: coreThis issue pertains to a Qubes core component.P: defaultPriority: default. Default priority for new issues, to be replaced given sufficient information.affects-4.3This issue affects Qubes OS 4.3.diagnosedTechnical diagnosis of this issue has been performed.pr submittedA pull request has been submitted for this issue.

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions