Skip to content

Commit 7183145

Browse files
authored
Trim visible strategy plugin alert fields (#60)
1 parent a65f589 commit 7183145

3 files changed

Lines changed: 4 additions & 34 deletions

File tree

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
44

55
[project]
66
name = "quant-platform-kit"
7-
version = "0.7.27"
7+
version = "0.7.28"
88
description = "Shared broker adapters, domain models, execution ports, and notification utilities for QuantStrategyLab strategies."
99
readme = "README.md"
1010
requires-python = ">=3.9"

src/quant_platform_kit/common/strategy_plugins.py

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -483,10 +483,6 @@ def build_strategy_plugin_alert_messages(
483483
translated_route = translate_strategy_plugin_value("route", route, translator=translator)
484484
translated_action = translate_strategy_plugin_value("action", action, translator=translator)
485485
strategy = str(strategy_label or getattr(signal, "strategy", None) or "").strip() or "unknown"
486-
would_trade = _translate_bool(
487-
translator,
488-
bool(getattr(signal, "would_trade_if_enabled", False)),
489-
)
490486
subject = _translate(
491487
translator,
492488
"strategy_plugin_alert_subject",
@@ -548,24 +544,8 @@ def build_strategy_plugin_alert_messages(
548544
fallback="Signal as-of: {as_of}",
549545
as_of=getattr(signal, "as_of", None) or "unknown",
550546
),
551-
_translate(
552-
translator,
553-
"strategy_plugin_alert_would_trade",
554-
fallback="Would trade if enabled: {value}",
555-
value=would_trade,
556-
),
557547
]
558548
)
559-
source = getattr(signal, "source_uri", None) or getattr(signal, "local_path", None)
560-
if source:
561-
body_lines.append(
562-
_translate(
563-
translator,
564-
"strategy_plugin_alert_source",
565-
fallback="Source: {source}",
566-
source=source,
567-
)
568-
)
569549
metadata = {
570550
"strategy": getattr(signal, "strategy", None),
571551
"strategy_label": strategy,
@@ -686,14 +666,6 @@ def _translate(
686666
return translated if translated != key else fallback.format(**kwargs)
687667

688668

689-
def _translate_bool(translator: Callable[..., str] | None, value: bool) -> str:
690-
return _translate(
691-
translator,
692-
"strategy_plugin_alert_yes" if value else "strategy_plugin_alert_no",
693-
fallback="yes" if value else "no",
694-
)
695-
696-
697669
def _required_string(value: Any, *, field_name: str) -> str:
698670
text = _optional_string(value)
699671
if text is None:

tests/test_strategy_plugins.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -279,9 +279,6 @@ def test_strategy_plugin_true_crisis_builds_generic_alert_message(self):
279279
"strategy_plugin_alert_action": "action={action}",
280280
"strategy_plugin_alert_mode": "mode={mode}",
281281
"strategy_plugin_alert_as_of": "as_of={as_of}",
282-
"strategy_plugin_alert_would_trade": "would_trade={value}",
283-
"strategy_plugin_alert_source": "source={source}",
284-
"strategy_plugin_alert_yes": "yes",
285282
"strategy_plugin_name_crisis_response_shadow": "Crisis",
286283
"strategy_plugin_mode_shadow": "shadow",
287284
"strategy_plugin_route_true_crisis": "true crisis",
@@ -303,8 +300,9 @@ def test_strategy_plugin_true_crisis_builds_generic_alert_message(self):
303300
self.assertIn("status=true crisis", alerts[0].body)
304301
self.assertIn("action=defend", alerts[0].body)
305302
self.assertIn("mode=shadow", alerts[0].body)
306-
self.assertIn("would_trade=yes", alerts[0].body)
307-
self.assertIn("source=gs://bucket/latest_signal.json", alerts[0].body)
303+
self.assertNotIn("would_trade=", alerts[0].body)
304+
self.assertNotIn("source=", alerts[0].body)
305+
self.assertTrue(alerts[0].metadata["would_trade_if_enabled"])
308306

309307

310308
if __name__ == "__main__":

0 commit comments

Comments
 (0)