fix: require report-date price coverage

Co-Authored-By: Codex <noreply@openai.com>

Author: Pigbibi

src/quant_advisor_research/recommendation_review.py

@@ -45,13 +45,6 @@ def final_recommendations(report: dict[str, Any]) -> list[dict[str, Any]]:
     return [item for item in recommendations if isinstance(item, dict) and item.get("symbol")]
 
 
-def first_bar_on_or_after(bars: list[PriceBar], target: dt.date) -> PriceBar | None:
-    for bar in sorted(bars, key=lambda item: item.date):
-        if bar.date >= target:
-            return bar
-    return None
-
-
 def last_bar_on_or_before(bars: list[PriceBar], target: dt.date) -> PriceBar | None:
     candidates = [bar for bar in bars if bar.date <= target]
     return max(candidates, key=lambda item: item.date) if candidates else None
@@ -120,9 +113,9 @@ def build_review_item(
     data_source: str,
 ) -> dict[str, Any]:
     symbol = str(pick.get("symbol", "")).upper()
-    start_bar = first_bar_on_or_after(symbol_bars, report_as_of)
+    start_bar = last_bar_on_or_before(symbol_bars, report_as_of)
     end_bar = last_bar_on_or_before(symbol_bars, review_as_of)
-    benchmark_start = first_bar_on_or_after(benchmark_bars, report_as_of)
+    benchmark_start = last_bar_on_or_before(benchmark_bars, report_as_of)
     benchmark_end = last_bar_on_or_before(benchmark_bars, review_as_of)
     has_price_data = bool(start_bar and end_bar and start_bar.date <= end_bar.date)
 

tests/test_recommendation_review.py

@@ -131,6 +131,24 @@ def test_long_horizon_cannot_be_labeled_lagging_after_a_few_weeks(tmp_path: Path
     assert item["outcome"] == "in_progress"
 
 
+def test_review_requires_price_coverage_on_or_before_report_date(tmp_path: Path) -> None:
+    cache_dir = tmp_path / "market-cache"
+    write_cached_bars("MU", make_bars(dt.date(2026, 2, 1), [100] * 300), cache_dir=cache_dir)
+    write_cached_bars("SPY", make_bars(dt.date(2026, 2, 1), [100] * 300), cache_dir=cache_dir)
+    report_path = tmp_path / "advisory_report_2026-01-05.json"
+    write_report(report_path, horizon="long")
+
+    review = build_recommendation_review(
+        report_paths=[report_path], as_of=dt.date(2026, 11, 1), benchmark="SPY",
+        cache_dir=cache_dir, cache_max_age_days=400, use_network=False,
+    )
+
+    item = review["review_items"][0]
+    assert item["start_price_date"] == ""
+    assert item["maturity_status"] == "insufficient_price_data"
+    assert item["outcome"] == "insufficient_price_data"
+
+
 def test_recommendation_review_marks_same_day_report_as_pending(tmp_path: Path) -> None:
     report_path = tmp_path / "advisory_report_2026-01-05.json"
     write_report(report_path)