fix: enforce vnext identity uniqueness and ordering

Co-Authored-By: Codex <noreply@openai.com>

Author: Pigbibi

src/quant_advisor_research/vnext_identity_schema_v1.py

@@ -117,6 +117,7 @@ def __post_init__(self) -> None:
         if type(self.bindings) is not tuple or not all(isinstance(item, VNextIdentityBinding) for item in self.bindings):
             raise _error("index_invalid")
         _validate_index(self.bindings)
+        object.__setattr__(self, "bindings", tuple(sorted(self.bindings, key=_binding_sort_key)))
 
 
 def _validate_binding(binding: VNextIdentityBinding) -> None:
@@ -169,7 +170,7 @@ def _validate_index(bindings: tuple[VNextIdentityBinding, ...]) -> None:
     canonical_periods: set[str] = set()
     names: set[str] = set()
     artifact_identities: set[tuple[str, str, str, str, str, str, str]] = set()
-    digest_periods: dict[str, tuple[str, str, str]] = {}
+    artifact_digests: set[str] = set()
     display: dict[str, tuple[bool, set[int]]] = {}
     for binding in bindings:
         _validate_binding(binding)
@@ -195,11 +196,9 @@ def _validate_index(bindings: tuple[VNextIdentityBinding, ...]) -> None:
                 if name in names:
                     raise _error("target_collision")
                 names.add(name)
-        period = (binding.period_key, binding.as_of, binding.cadence)
-        previous = digest_periods.get(binding.artifact_integrity_digest)
-        if previous is not None and previous != period:
+        if binding.artifact_integrity_digest in artifact_digests:
             raise _error("artifact_digest_conflict")
-        digest_periods[binding.artifact_integrity_digest] = period
+        artifact_digests.add(binding.artifact_integrity_digest)
     if {item.period_key for item in bindings} - canonical_periods:
         raise _error("canonical_missing")
 

tests/test_vnext_identity_schema_v1_foundation.py

@@ -71,6 +71,7 @@ def test_schema_v1_roundtrip_and_input_permutation_are_deterministic():
     left = parse_vnext_identity_index(payload(canonical, variant))
     right = parse_vnext_identity_index(payload(variant, canonical))
     assert left == right
+    assert hash(left) == hash(right)
     assert serialize_vnext_identity_index(left) == serialize_vnext_identity_index(right)
     assert parse_vnext_identity_index(serialize_vnext_identity_index(left)) == left
 
@@ -132,6 +133,8 @@ def test_index_requires_one_canonical_and_enforces_display_policy():
 def test_full_artifact_identity_and_target_collisions_fail_closed():
     with pytest.raises(VNextIdentityError, match="identity_duplicate"):
         VNextIdentityIndex((binding(), binding(md=True)))
+    with pytest.raises(VNextIdentityError, match="artifact_digest_conflict"):
+        VNextIdentityIndex((binding(), binding(cls=V3_VARIANT, semantic=B, order=1)))
 
 
 def test_display_order_is_safe_json_integer_and_not_bool():