Surface material rebalance blockers

Author: Pigbibi

application/execution_service.py

@@ -434,14 +434,25 @@ def execute_rebalance(
     )
     trade_logs.extend(_format_target_lines(target_weights, current_mv, equity, translator=translator))
 
+    missing_price_symbols: list[str] = []
+    insufficient_buying_power_symbols: list[str] = []
+    min_notional_symbols: list[str] = []
+    quantity_zero_symbols: list[str] = []
+
     has_sell_plan = False
     for symbol in all_symbols:
         current = current_mv.get(symbol, 0.0)
         target = target_mv.get(symbol, 0.0)
+        if current <= target + threshold:
+            continue
         price = prices.get(symbol)
-        if price and current > target + threshold and int((current - target) / price) > 0:
+        if not price:
+            missing_price_symbols.append(symbol)
+            continue
+        if int((current - target) / price) > 0:
             has_sell_plan = True
             break
+        quantity_zero_symbols.append(symbol)
 
     anticipated_buying_power = get_available_buying_power(
         ib,
@@ -450,19 +461,54 @@ def execute_rebalance(
     has_buy_plan = False
     for symbol, target in target_mv.items():
         current = current_mv.get(symbol, 0.0)
+        if current >= target - threshold:
+            continue
         price = prices.get(symbol)
-        if not price or current >= target - threshold:
+        if not price:
+            missing_price_symbols.append(symbol)
             continue
         buy_value = min(target - current, anticipated_buying_power * 0.95)
+        if buy_value <= 0:
+            insufficient_buying_power_symbols.append(symbol)
+            continue
+        if buy_value < 50:
+            min_notional_symbols.append(symbol)
+            continue
         limit_price = round(price * limit_buy_premium, 2)
         qty = int(buy_value / limit_price) if limit_price > 0 else 0
-        if qty > 0 and buy_value >= 50:
+        if qty > 0:
             has_buy_plan = True
             break
+        quantity_zero_symbols.append(symbol)
 
     if not has_sell_plan and not has_buy_plan:
-        execution_summary["execution_status"] = "no_op"
-        execution_summary["no_op_reason"] = "target_diff_below_threshold"
+        reason = "target_diff_below_threshold"
+        status = "no_op"
+        if missing_price_symbols:
+            symbols = ",".join(sorted(dict.fromkeys(missing_price_symbols)))
+            reason = f"missing_price:{symbols}"
+            status = "blocked"
+            execution_summary["orders_skipped"].extend(
+                {"symbol": symbol, "reason": "missing_price"}
+                for symbol in sorted(dict.fromkeys(missing_price_symbols))
+            )
+        elif insufficient_buying_power_symbols:
+            symbols = ",".join(sorted(dict.fromkeys(insufficient_buying_power_symbols)))
+            reason = f"insufficient_buying_power:{symbols}"
+            status = "blocked"
+        elif min_notional_symbols:
+            symbols = ",".join(sorted(dict.fromkeys(min_notional_symbols)))
+            reason = f"min_notional:{symbols}"
+        elif quantity_zero_symbols:
+            symbols = ",".join(sorted(dict.fromkeys(quantity_zero_symbols)))
+            reason = f"quantity_zero:{symbols}"
+
+        execution_summary["execution_status"] = status
+        execution_summary["no_op_reason"] = reason
+        if reason != "target_diff_below_threshold":
+            execution_summary["skipped_reasons"].append(reason)
+            if status == "blocked":
+                trade_logs.append(translator("failed", reason=reason))
         return _finalize_result(trade_logs, execution_summary, return_summary=return_summary)
 
     same_day_filled_symbols = _collect_same_day_filled_symbols(ib, set(all_symbols), trade_date)

tests/test_execution_service.py

@@ -290,3 +290,77 @@ def fake_fetch_quote_snapshots(_ib, symbols):
     assert summary["safe_haven_symbol"] == "BOXX"
     assert summary["orders_submitted"]
     assert summary["target_vs_current"]
+
+
+def test_execute_rebalance_blocks_when_material_target_has_missing_prices():
+    class FakeIB:
+        def openTrades(self):
+            return []
+
+        def fills(self):
+            return []
+
+        def accountValues(self):
+            return [SimpleNamespace(tag="AvailableFunds", currency="USD", value="5000")]
+
+    trade_logs, summary = execute_rebalance(
+        FakeIB(),
+        {"VOO": 1.0},
+        {},
+        {"equity": 1000.0, "buying_power": 1000.0},
+        fetch_quote_snapshots=lambda *_args, **_kwargs: {},
+        submit_order_intent=lambda *_args, **_kwargs: None,
+        order_intent_cls=OrderIntent,
+        translator=translate,
+        strategy_symbols=["VOO"],
+        strategy_profile="tech_pullback_cash_buffer",
+        signal_metadata={"trade_date": "2026-04-01", "snapshot_as_of": "2026-03-31"},
+        dry_run_only=True,
+        cash_reserve_ratio=0.0,
+        rebalance_threshold_ratio=0.02,
+        limit_buy_premium=1.005,
+        sell_settle_delay_sec=0,
+        return_summary=True,
+    )
+
+    assert summary["execution_status"] == "blocked"
+    assert summary["no_op_reason"] == "missing_price:VOO"
+    assert summary["orders_skipped"] == [{"symbol": "VOO", "reason": "missing_price"}]
+    assert "failed missing_price:VOO" in trade_logs[-1]
+
+
+def test_execute_rebalance_blocks_when_material_target_has_no_buying_power():
+    class FakeIB:
+        def openTrades(self):
+            return []
+
+        def fills(self):
+            return []
+
+        def accountValues(self):
+            return [SimpleNamespace(tag="AvailableFunds", currency="USD", value="0")]
+
+    trade_logs, summary = execute_rebalance(
+        FakeIB(),
+        {"VOO": 1.0},
+        {},
+        {"equity": 1000.0, "buying_power": 0.0},
+        fetch_quote_snapshots=lambda *_args, **_kwargs: {"VOO": SimpleNamespace(last_price=100.0)},
+        submit_order_intent=lambda *_args, **_kwargs: None,
+        order_intent_cls=OrderIntent,
+        translator=translate,
+        strategy_symbols=["VOO"],
+        strategy_profile="tech_pullback_cash_buffer",
+        signal_metadata={"trade_date": "2026-04-01", "snapshot_as_of": "2026-03-31"},
+        dry_run_only=True,
+        cash_reserve_ratio=0.0,
+        rebalance_threshold_ratio=0.02,
+        limit_buy_premium=1.005,
+        sell_settle_delay_sec=0,
+        return_summary=True,
+    )
+
+    assert summary["execution_status"] == "blocked"
+    assert summary["no_op_reason"] == "insufficient_buying_power:VOO"
+    assert summary["skipped_reasons"] == ["insufficient_buying_power:VOO"]
+    assert "failed insufficient_buying_power:VOO" in trade_logs[-1]