Skip to content

Commit 398deb3

Browse files
Pigbibicodex
andcommitted
fix(ops): preserve diagnostic SSH failures
Co-Authored-By: Codex <noreply@openai.com>
1 parent 9ec2ab0 commit 398deb3

2 files changed

Lines changed: 3 additions & 0 deletions

File tree

.github/workflows/diagnose.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -248,5 +248,7 @@ jobs:
248248
'
249249
}
250250
251+
# Keep SSH/authentication failures visible even though output is filtered.
252+
set -o pipefail
251253
gcloud compute ssh "${REMOTE_TARGET}" "${SSH_FLAGS[@]}" --command "${REMOTE_DIAG_COMMAND}" 2>&1 \
252254
| redact_diagnostics

tests/test_workflow_shared_config.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,7 @@ grep -Fq 'shell: python3 {0}' "$diagnose_workflow_file"
161161
! grep -Fxq ' shell: python3' "$diagnose_workflow_file"
162162
grep -Fq 'redact_diagnostics()' "$diagnose_workflow_file"
163163
grep -Fq 'sensitive_assignment_pattern.sub(r"\1\2<REDACTED>\n", line)' "$diagnose_workflow_file"
164+
grep -Fq 'set -o pipefail' "$diagnose_workflow_file"
164165
grep -Fq '| redact_diagnostics' "$diagnose_workflow_file"
165166
! grep -Fq 'actions/checkout' "$diagnose_workflow_file"
166167
! grep -R -Fxq ' shell: python3' "$repo_dir/.github/workflows"

0 commit comments

Comments
 (0)