Reject non-finite cash reserve settings

Author: Pigbibi

runtime_config_support.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import math
 import os
 from dataclasses import dataclass
 from pathlib import Path
@@ -188,6 +189,8 @@ def _resolve_non_negative_float_env(name: str, *, default: float) -> float:
     value = resolve_optional_float_env(os.environ, name)
     if value is None:
         return float(default)
+    if not math.isfinite(value):
+        raise ValueError(f"{name} must be finite, got {value}")
     if value < 0:
         raise ValueError(f"{name} must be non-negative, got {value}")
     return float(value)

tests/test_runtime_config_support.py

@@ -3,6 +3,7 @@
 import pytest
 
 from runtime_config_support import (
+    _resolve_non_negative_float_env,
     _resolve_ratio_env,
     _runtime_execution_window_trading_days_env,
     load_platform_runtime_settings,
@@ -72,6 +73,22 @@ def test_reserved_cash_ratio_rejects_invalid_env(monkeypatch):
         _resolve_ratio_env("FIRSTRADE_RESERVED_CASH_RATIO", default=0.0)
 
 
+@pytest.mark.parametrize("raw_value", ["nan", "inf", "-inf"])
+def test_reserved_cash_floor_rejects_non_finite_env(monkeypatch, raw_value):
+    monkeypatch.setenv("FIRSTRADE_MIN_RESERVED_CASH_USD", raw_value)
+
+    with pytest.raises(ValueError, match="FIRSTRADE_MIN_RESERVED_CASH_USD must be finite"):
+        _resolve_non_negative_float_env("FIRSTRADE_MIN_RESERVED_CASH_USD", default=0.0)
+
+
+@pytest.mark.parametrize("raw_value", ["nan", "inf", "-inf"])
+def test_reserved_cash_ratio_rejects_non_finite_env(monkeypatch, raw_value):
+    monkeypatch.setenv("FIRSTRADE_RESERVED_CASH_RATIO", raw_value)
+
+    with pytest.raises(ValueError, match="FIRSTRADE_RESERVED_CASH_RATIO must be finite"):
+        _resolve_ratio_env("FIRSTRADE_RESERVED_CASH_RATIO", default=0.0)
+
+
 @pytest.mark.parametrize("raw_value", ["0", "-1", "abc"])
 def test_runtime_execution_window_rejects_invalid_generic_env(monkeypatch, raw_value):
     monkeypatch.setenv("FIRSTRADE_RUNTIME_EXECUTION_WINDOW_TRADING_DAYS", raw_value)