Skip to content

Commit 69fe135

Browse files
Pigbibicodex
andcommitted
fix: keep runtime configuration out of logs
Co-Authored-By: Codex <noreply@openai.com>
1 parent da9fbfe commit 69fe135

5 files changed

Lines changed: 23 additions & 15 deletions

File tree

.github/workflows/ci.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,14 @@ jobs:
1616
- name: Checkout
1717
uses: actions/checkout@v6
1818

19+
- name: Reject public runtime configuration bindings
20+
run: |
21+
set -euo pipefail
22+
if rg -n '\$\{\{[[:space:]]*vars\.(CLOUD_RUN_SERVICE_TARGETS_JSON|RUNTIME_TARGET_JSON|GLOBAL_TELEGRAM_CHAT_ID|CLOUD_RUN_SERVICES|CLOUD_RUN_SERVICE|RUNTIME_HEARTBEAT_REQUIRED_SERVICES|RUNTIME_GUARD_SCHEDULER_JOB_PATTERN)' .github/workflows; then
23+
echo "Operational runtime configuration must use GitHub Secrets, not GitHub Variables." >&2
24+
exit 1
25+
fi
26+
1927
- name: Resolve QuantPlatformKit ref
2028
id: quant-platform-kit-ref
2129
run: |

.github/workflows/execution-report-heartbeat.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,16 +49,16 @@ jobs:
4949
RUNTIME_HEARTBEAT_SCHEDULER_AWARE: ${{ vars.RUNTIME_HEARTBEAT_SCHEDULER_AWARE || 'true' }}
5050
RUNTIME_HEARTBEAT_SCHEDULER_LOCATION: ${{ vars.RUNTIME_HEARTBEAT_SCHEDULER_LOCATION || vars.CLOUD_RUN_REGION || 'us-central1' }}
5151
RUNTIME_TARGET_ENABLED: ${{ vars.RUNTIME_TARGET_ENABLED }}
52-
RUNTIME_TARGET_JSON: ${{ vars.RUNTIME_TARGET_JSON }}
52+
RUNTIME_TARGET_JSON: ${{ secrets.RUNTIME_TARGET_JSON }}
5353
CLOUD_RUN_REGION: ${{ vars.CLOUD_RUN_REGION }}
54-
CLOUD_RUN_SERVICE: ${{ vars.CLOUD_RUN_SERVICE }}
55-
CLOUD_RUN_SERVICES: ${{ vars.CLOUD_RUN_SERVICES }}
56-
CLOUD_RUN_SERVICE_TARGETS_JSON: ${{ vars.CLOUD_RUN_SERVICE_TARGETS_JSON }}
54+
CLOUD_RUN_SERVICE: ${{ secrets.CLOUD_RUN_SERVICE }}
55+
CLOUD_RUN_SERVICES: ${{ secrets.CLOUD_RUN_SERVICES }}
56+
CLOUD_RUN_SERVICE_TARGETS_JSON: ${{ secrets.CLOUD_RUN_SERVICE_TARGETS_JSON }}
5757
CLOUD_SCHEDULER_MAIN_TIME: ${{ vars.CLOUD_SCHEDULER_MAIN_TIME }}
5858
EXECUTION_REPORT_GCS_URI: ${{ vars.EXECUTION_REPORT_GCS_URI }}
5959
FIRSTRADE_GCS_STATE_BUCKET: ${{ vars.FIRSTRADE_GCS_STATE_BUCKET }}
6060
FIRSTRADE_STATE_PREFIX: ${{ vars.FIRSTRADE_STATE_PREFIX }}
61-
GLOBAL_TELEGRAM_CHAT_ID: ${{ vars.GLOBAL_TELEGRAM_CHAT_ID }}
61+
GLOBAL_TELEGRAM_CHAT_ID: ${{ secrets.GLOBAL_TELEGRAM_CHAT_ID }}
6262
TELEGRAM_TOKEN: ${{ secrets.TELEGRAM_TOKEN }}
6363
TELEGRAM_TOKEN_SECRET_NAME: ${{ vars.TELEGRAM_TOKEN_SECRET_NAME }}
6464
steps:

.github/workflows/invoke-cloud-run.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
id-token: write
3838
env:
3939
CLOUD_RUN_REGION: ${{ vars.CLOUD_RUN_REGION }}
40-
CLOUD_RUN_SERVICE: ${{ vars.CLOUD_RUN_SERVICE }}
40+
CLOUD_RUN_SERVICE: ${{ secrets.CLOUD_RUN_SERVICE }}
4141
CLOUD_SCHEDULER_LOCATION: ${{ vars.CLOUD_SCHEDULER_LOCATION }}
4242
steps:
4343
- name: Validate inputs

.github/workflows/runtime-guard.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,12 @@ jobs:
5050
RUNTIME_GUARD_LOOKBACK_MINUTES: ${{ inputs.lookback_minutes || vars.RUNTIME_GUARD_LOOKBACK_MINUTES || '180' }}
5151
RUNTIME_GUARD_REQUIRE_SUCCESS: ${{ inputs.require_success || vars.RUNTIME_GUARD_REQUIRE_SUCCESS || 'false' }}
5252
RUNTIME_GUARD_FAIL_WORKFLOW_ON_ALERT: ${{ inputs.fail_workflow_on_alert || vars.RUNTIME_GUARD_FAIL_WORKFLOW_ON_ALERT || 'true' }}
53-
RUNTIME_GUARD_SCHEDULER_JOB_PATTERN: ${{ vars.RUNTIME_GUARD_SCHEDULER_JOB_PATTERN }}
54-
CLOUD_RUN_SERVICE: ${{ vars.CLOUD_RUN_SERVICE }}
55-
CLOUD_RUN_SERVICES: ${{ vars.CLOUD_RUN_SERVICES }}
56-
CLOUD_RUN_SERVICE_TARGETS_JSON: ${{ vars.CLOUD_RUN_SERVICE_TARGETS_JSON }}
53+
RUNTIME_GUARD_SCHEDULER_JOB_PATTERN: ${{ secrets.RUNTIME_GUARD_SCHEDULER_JOB_PATTERN }}
54+
CLOUD_RUN_SERVICE: ${{ secrets.CLOUD_RUN_SERVICE }}
55+
CLOUD_RUN_SERVICES: ${{ secrets.CLOUD_RUN_SERVICES }}
56+
CLOUD_RUN_SERVICE_TARGETS_JSON: ${{ secrets.CLOUD_RUN_SERVICE_TARGETS_JSON }}
5757
CLOUD_RUN_REGION: ${{ vars.CLOUD_RUN_REGION }}
58-
GLOBAL_TELEGRAM_CHAT_ID: ${{ vars.GLOBAL_TELEGRAM_CHAT_ID }}
58+
GLOBAL_TELEGRAM_CHAT_ID: ${{ secrets.GLOBAL_TELEGRAM_CHAT_ID }}
5959
TELEGRAM_TOKEN: ${{ secrets.TELEGRAM_TOKEN }}
6060
TELEGRAM_TOKEN_SECRET_NAME: ${{ vars.TELEGRAM_TOKEN_SECRET_NAME }}
6161
steps:

.github/workflows/sync-cloud-run-env.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ jobs:
3737
ENABLE_MAIN_PUSH_CLOUD_RUN_AUTOMATION: ${{ vars.ENABLE_MAIN_PUSH_CLOUD_RUN_AUTOMATION }}
3838
QSL_ENABLE_CLOUD_RUN_AUTOMATION: ${{ vars.QSL_ENABLE_CLOUD_RUN_AUTOMATION }}
3939
CLOUD_RUN_REGION: ${{ vars.CLOUD_RUN_REGION }}
40-
CLOUD_RUN_SERVICE: ${{ vars.CLOUD_RUN_SERVICE }}
41-
CLOUD_RUN_SERVICE_TARGETS_JSON: ${{ vars.CLOUD_RUN_SERVICE_TARGETS_JSON }}
40+
CLOUD_RUN_SERVICE: ${{ secrets.CLOUD_RUN_SERVICE }}
41+
CLOUD_RUN_SERVICE_TARGETS_JSON: ${{ secrets.CLOUD_RUN_SERVICE_TARGETS_JSON }}
4242
CLOUD_SCHEDULER_LOCATION: ${{ vars.CLOUD_SCHEDULER_LOCATION }}
4343
CLOUD_SCHEDULER_MAIN_TIME: ${{ vars.CLOUD_SCHEDULER_MAIN_TIME }}
4444
CLOUD_SCHEDULER_PROBE_TIME: ${{ vars.CLOUD_SCHEDULER_PROBE_TIME }}
@@ -51,7 +51,7 @@ jobs:
5151
FIRSTRADE_MFA_EMAIL_SECRET_NAME: ${{ vars.FIRSTRADE_MFA_EMAIL_SECRET_NAME }}
5252
FIRSTRADE_MFA_PHONE_SECRET_NAME: ${{ vars.FIRSTRADE_MFA_PHONE_SECRET_NAME }}
5353
FIRSTRADE_MFA_CODE_SECRET_NAME: ${{ vars.FIRSTRADE_MFA_CODE_SECRET_NAME }}
54-
RUNTIME_TARGET_JSON: ${{ vars.RUNTIME_TARGET_JSON }}
54+
RUNTIME_TARGET_JSON: ${{ secrets.RUNTIME_TARGET_JSON }}
5555
ACCOUNT_PREFIX: ${{ vars.ACCOUNT_PREFIX }}
5656
ACCOUNT_REGION: ${{ vars.ACCOUNT_REGION }}
5757
FIRSTRADE_ACCOUNT: ${{ vars.FIRSTRADE_ACCOUNT }}
@@ -138,7 +138,7 @@ jobs:
138138
IBIT_ZSCORE_EXIT_ALLOW_OUTSIDE_EXECUTION_WINDOW: ${{ vars.IBIT_ZSCORE_EXIT_ALLOW_OUTSIDE_EXECUTION_WINDOW }}
139139
RUNTIME_TARGET_ENABLED: ${{ vars.RUNTIME_TARGET_ENABLED }}
140140
EXECUTION_REPORT_GCS_URI: ${{ vars.EXECUTION_REPORT_GCS_URI }}
141-
GLOBAL_TELEGRAM_CHAT_ID: ${{ vars.GLOBAL_TELEGRAM_CHAT_ID }}
141+
GLOBAL_TELEGRAM_CHAT_ID: ${{ secrets.GLOBAL_TELEGRAM_CHAT_ID }}
142142
NOTIFY_LANG: ${{ vars.NOTIFY_LANG }}
143143
TELEGRAM_TOKEN: ${{ secrets.TELEGRAM_TOKEN }}
144144
STRATEGY_PLUGIN_ALERT_EMAIL_SENDER_PASSWORD: ${{ secrets.STRATEGY_PLUGIN_ALERT_EMAIL_SENDER_PASSWORD }}

0 commit comments

Comments
 (0)