feat(gate): require base-approved exact deletions

Co-Authored-By: Codex <noreply@openai.com>

Author: Pigbibi

.github/codex_auto_merge_policy.json

@@ -23,7 +23,13 @@
     }
   },
   "max_changed_files": 30,
-  "max_changed_lines": 2000,
+  "max_changed_lines": 3000,
+  "approved_deleted_paths": [
+    ".github/workflows/codex_pr_review.yml",
+    "prompts/pr_review.md",
+    "scripts/run_codex_pr_review.py",
+    "tests/test_run_codex_pr_review.py"
+  ],
   "pr_review": {
     "enabled": true,
     "block_severities": [

scripts/gate_codex_app_review_static.py

@@ -7,7 +7,7 @@
 
 import json
 import re
-from pathlib import Path
+from pathlib import Path, PurePosixPath
 from typing import Any
 
 DEFAULT_POLICY_PATH = Path(".github/codex_auto_merge_policy.json")
@@ -72,14 +72,32 @@ def scan_diff(diff_text: str, path_patterns: list[re.Pattern[str]]) -> list[str]
 
 def check_metadata(files: list[dict[str, Any]], policy: dict[str, Any]) -> list[str]:
     issues: list[str] = []
+    approved_deleted_paths: set[str] = set()
+    configured_approvals = policy.get("approved_deleted_paths", [])
+    if isinstance(configured_approvals, list):
+        for value in configured_approvals:
+            if not isinstance(value, str) or value != value.strip():
+                continue
+            path = PurePosixPath(value)
+            if (
+                not value
+                or path.is_absolute()
+                or path.as_posix() != value
+                or ".." in path.parts
+                or "\\" in value
+                or any(character in value for character in "*?[]")
+            ):
+                continue
+            approved_deleted_paths.add(value)
+
     max_files = policy.get("max_changed_files", 50)
     max_lines = policy.get("max_changed_lines", 5000)
     total_added = sum(f.get("additions", 0) or 0 for f in files)
     total_deleted = sum(f.get("deletions", 0) or 0 for f in files)
     for f in files:
         filename = f.get("filename", "?")
         status = (f.get("status") or "").lower().strip()
-        if status == "removed":
+        if status == "removed" and filename not in approved_deleted_paths:
             issues.append(f"**File deleted**: `{filename}` — verify intentional")
         elif status == "renamed":
             issues.append(f"**File renamed**: `{f.get('previous_filename', '?')}` → `{filename}`")

tests/test_gate_codex_app_review.py

@@ -107,6 +107,56 @@ def test_collect_static_gate_issues_aggregates_metadata_and_diff(self) -> None:
         self.assertTrue(any("Hardcoded secret" in issue for issue in issues))
         self.assertTrue(any("Too many lines" in issue for issue in issues))
 
+    def test_check_metadata_allows_only_exact_base_approved_deletions(self) -> None:
+        files = [
+            {
+                "filename": "scripts/retired.py",
+                "status": "removed",
+                "additions": 0,
+                "deletions": 10,
+            },
+            {
+                "filename": "scripts/unapproved.py",
+                "status": "removed",
+                "additions": 0,
+                "deletions": 10,
+            },
+        ]
+        policy = {
+            "approved_deleted_paths": ["scripts/retired.py"],
+            "max_changed_files": 10,
+            "max_changed_lines": 100,
+        }
+
+        issues = gate_codex_app_review_static.check_metadata(files, policy)
+
+        self.assertFalse(any("scripts/retired.py" in issue for issue in issues))
+        self.assertTrue(any("scripts/unapproved.py" in issue for issue in issues))
+
+    def test_check_metadata_rejects_unsafe_delete_approvals(self) -> None:
+        files = [
+            {
+                "filename": "scripts/retired.py",
+                "status": "removed",
+                "additions": 0,
+                "deletions": 10,
+            },
+        ]
+        for approval in (
+            "scripts/*.py",
+            "../scripts/retired.py",
+            "/scripts/retired.py",
+            "scripts\\retired.py",
+        ):
+            with self.subTest(approval=approval):
+                policy = {
+                    "approved_deleted_paths": [approval],
+                    "max_changed_files": 10,
+                    "max_changed_lines": 100,
+                }
+                issues = gate_codex_app_review_static.check_metadata(files, policy)
+                self.assertTrue(any("scripts/retired.py" in issue for issue in issues))
+
 
 if __name__ == "__main__":
     unittest.main()