fix: harden dual review alert delivery

Co-Authored-By: Codex <noreply@openai.com>

Author: Pigbibi

service/briefing_dispatch.py

@@ -117,7 +117,7 @@ def create_github_issue(*, title: str, body: str, labels: tuple[str, ...] = ())
         return None
     if not shutil_which("gh"):
         return None
-    cmd = [
+    base_cmd = [
         "gh",
         "issue",
         "create",
@@ -128,12 +128,33 @@ def create_github_issue(*, title: str, body: str, labels: tuple[str, ...] = ())
         "--body",
         body,
     ]
+    cmd = list(base_cmd)
     for label in labels:
         cmd.extend(["--label", label])
     try:
         output = subprocess.check_output(cmd, text=True, stderr=subprocess.STDOUT).strip()
         return output
-    except Exception:
+    except subprocess.CalledProcessError as exc:
+        if labels:
+            print(
+                "::warning title=GitHub issue labels unavailable::"
+                "retrying durable issue creation without labels"
+            )
+            try:
+                return subprocess.check_output(
+                    base_cmd,
+                    text=True,
+                    stderr=subprocess.STDOUT,
+                ).strip()
+            except (OSError, subprocess.CalledProcessError) as retry_exc:
+                detail = str(getattr(retry_exc, "output", "") or retry_exc).strip()
+                print(f"::warning title=GitHub issue creation failed::{detail}")
+                return None
+        detail = str(exc.output or exc).strip()
+        print(f"::warning title=GitHub issue creation failed::{detail}")
+        return None
+    except OSError as exc:
+        print(f"::warning title=GitHub issue creation failed::{exc}")
         return None
 
 

service/dual_review_primary.py

@@ -87,8 +87,9 @@ def run_codex_primary_review(
         raise RuntimeError("CODEX_AUDIT_SERVICE_URL is not configured")
 
     timeout = int(timeout_minutes or os.environ.get("DUAL_REVIEW_PRIMARY_TIMEOUT_MINUTES", "15"))
+    review_prompt = f"{_PRIMARY_SYSTEM}\n\n{prompt}"
     result = AiGatewayClient(GatewayConfig.from_env()).execute(
-        prompt,
+        review_prompt,
         task="dual_review",
         mode="review_only",
         complexity="high",

tests/test_briefing_dispatch.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import os
+import subprocess
 import unittest
 from unittest.mock import patch
 
@@ -134,6 +135,26 @@ def test_create_github_issue_uses_actions_repository(self, _which, check_output)
         self.assertEqual(issue, "https://example.test/issues/1")
         self.assertIn("QuantStrategyLab/CryptoStrategies", check_output.call_args.args[0])
 
+    @patch(
+        "service.briefing_dispatch.subprocess.check_output",
+        side_effect=[
+            subprocess.CalledProcessError(1, ["gh"], output="label not found"),
+            "https://example.test/issues/2\n",
+        ],
+    )
+    @patch("service.briefing_dispatch.shutil_which", return_value="/usr/bin/gh")
+    def test_create_github_issue_retries_without_missing_labels(self, _which, check_output) -> None:
+        with patch.dict(os.environ, {"GITHUB_REPOSITORY": "QuantStrategyLab/CryptoStrategies"}, clear=True):
+            issue = create_github_issue(
+                title="review disagreement",
+                body="details",
+                labels=("dual-review", "needs-human"),
+            )
+
+        self.assertEqual(issue, "https://example.test/issues/2")
+        self.assertIn("--label", check_output.call_args_list[0].args[0])
+        self.assertNotIn("--label", check_output.call_args_list[1].args[0])
+
     @patch("service.briefing_dispatch.subprocess.check_output")
     @patch("service.briefing_dispatch.shutil_which", return_value="/usr/bin/gh")
     def test_create_github_issue_rejects_invalid_repository(self, _which, check_output) -> None:

tests/test_dual_review_primary.py

@@ -124,8 +124,14 @@ def test_budget_error_is_unavailable(self, review) -> None:
         review.return_value = AiResult.unavailable("codex", "Daily budget exceeded")
         result = run_codex_primary_review(prompt="review")
         self.assertEqual(result["verdict"], VERDICT_UNAVAILABLE)
+        expected_prompt = (
+            "You are the primary Codex reviewer for quantitative strategy promotion and risk decisions. "
+            "Respond with JSON only: "
+            '{"verdict":"approve"|"reject","confidence":0.0-1.0,"summary":"..."}'
+            "\n\nreview"
+        )
         review.assert_called_once_with(
-            "review",
+            expected_prompt,
             task="dual_review",
             mode="review_only",
             complexity="high",