fix: align execution action with review-only mode

Co-Authored-By: Codex <noreply@openai.com>

Author: Pigbibi

service/ai_gateway_service.py

@@ -1633,7 +1633,8 @@ def _handle_record_automation_run(self, claims: dict[str, Any], payload: dict[st
             if mode_from_payload
             else existing_metadata.get("requested_mode") or existing_metadata.get("mode")
         )
-        requested_mode = _normalize_control_mode_param(str(raw_mode or MODE_REVIEW_ONLY))
+        default_mode = MODE_REVIEW_ONLY if existing is not None else MODE_REVIEW_AND_FIX
+        requested_mode = _normalize_control_mode_param(str(raw_mode or default_mode))
         if mode_from_payload and not requested_mode:
             raise ValueError("invalid mode")
         run_metadata = {

service/automation_decision.py

@@ -424,6 +424,8 @@ def decide_automation_execution(
         else:
             reasons.append(f"quota status is {quota}; execution already blocked")
         effective_mode = MODE_REVIEW_ONLY
+    if action == EXECUTION_RUN and effective_mode == MODE_REVIEW_ONLY:
+        action = EXECUTION_REVIEW_ONLY
     human_review_required = action == EXECUTION_HUMAN_REVIEW
 
     return {

tests/test_ai_gateway_service_get_routes.py

@@ -583,8 +583,8 @@ def test_automation_routes_record_and_return_run_ledger(self) -> None:
                         recorded = json.loads(response.read().decode("utf-8"))
                     self.assertEqual(recorded["run"]["run_id"], "platform-health-run-1")
                     self.assertEqual(recorded["run"]["suggested_action"], recorded["control"]["action"])
-                    self.assertEqual(recorded["control"]["execution"]["requested_mode"], "review_only")
-                    self.assertEqual(recorded["run"]["metadata"]["requested_mode"], "review_only")
+                    self.assertEqual(recorded["control"]["execution"]["requested_mode"], "review_and_fix")
+                    self.assertEqual(recorded["run"]["metadata"]["requested_mode"], "review_and_fix")
                     self.assertEqual(recorded["run"]["service_health"], recorded["control"]["service_health"])
                     self.assertEqual(recorded["run"]["quota_status"], recorded["control"]["quota_status"])
                     self.assertEqual(recorded["run"]["org_health_status"], recorded["control"]["org_health_status"])

tests/test_automation_decision.py

@@ -93,7 +93,7 @@ def test_auto_merge_is_disabled_when_effective_mode_is_review_only(self) -> None
             policy={"default": {"max_autonomy": "auto_merge"}},
         )
 
-        self.assertEqual(result["action"], EXECUTION_RUN)
+        self.assertEqual(result["action"], EXECUTION_REVIEW_ONLY)
         self.assertEqual(result["effective_mode"], MODE_REVIEW_ONLY)
         self.assertFalse(result["auto_fix_allowed"])
         self.assertFalse(result["auto_merge_allowed"])
@@ -108,6 +108,7 @@ def test_degraded_health_forces_review_only(self) -> None:
             org_health_status="ok",
         )
 
+        self.assertEqual(result["action"], EXECUTION_REVIEW_ONLY)
         self.assertEqual(result["effective_mode"], MODE_REVIEW_ONLY)
         self.assertFalse(result["auto_fix_allowed"])
         self.assertFalse(result["human_review_required"])
@@ -197,6 +198,7 @@ def test_repo_policy_can_force_review_only(self) -> None:
             policy={"repositories": {"QuantStrategyLab/CryptoLivePoolPipelines": {"max_autonomy": "review_only"}}},
         )
 
+        self.assertEqual(result["action"], EXECUTION_REVIEW_ONLY)
         self.assertEqual(result["effective_mode"], MODE_REVIEW_ONLY)
         self.assertFalse(result["human_review_required"])
         self.assertFalse(result["auto_fix_allowed"])