fix: keep automation control legacy actions compatible

Co-Authored-By: Codex <noreply@openai.com>

Author: Pigbibi

service/ai_gateway_service.py

@@ -67,14 +67,13 @@
 )
 from service.automation_run_ledger import (
     CONTROL_CONTINUE,
-    CONTROL_DEFER,
     CONTROL_ESCALATE,
     CONTROL_PAUSE_AUTO_FIX,
     CONTROL_REVIEW_ONLY,
     get_automation_run_ledger,
     suggest_control_action,
 )
-from service.automation_decision import EXECUTION_DEFER, EXECUTION_HUMAN_REVIEW, decide_automation_execution, load_execution_policy
+from service.automation_decision import EXECUTION_HUMAN_REVIEW, decide_automation_execution, load_execution_policy
 from service.strategy_automation_registry import (
     apply_strategy_registry_guard,
     summarize_strategy_registry_context,
@@ -514,7 +513,7 @@ def _automation_control_snapshot(
     repo: str,
     *,
     task_name: str = "",
-    requested_mode: str = MODE_REVIEW_ONLY,
+    requested_mode: str = MODE_REVIEW_AND_FIX,
     pending_run: dict[str, Any] | None = None,
 ) -> dict[str, Any]:
     try:
@@ -560,8 +559,6 @@ def _automation_control_snapshot(
     strict_action = original_action
     if execution.get("action") == EXECUTION_HUMAN_REVIEW:
         strict_action = CONTROL_ESCALATE
-    elif execution.get("action") == EXECUTION_DEFER:
-        strict_action = CONTROL_DEFER
     elif (
         execution.get("requested_mode") == MODE_REVIEW_AND_FIX
         and execution.get("effective_mode") == MODE_REVIEW_ONLY
@@ -571,7 +568,7 @@ def _automation_control_snapshot(
     if strict_action != original_action:
         control["action"] = strict_action
         control["auto_fix_allowed"] = False
-        control["requires_human_review"] = execution.get("action") != EXECUTION_DEFER
+        control["requires_human_review"] = True
         reasons = control.get("reasons") if isinstance(control.get("reasons"), list) else []
         reasons.append("capped by execution decision")
         control["reasons"] = reasons
@@ -1499,7 +1496,7 @@ def _handle_automation_control(self) -> None:
             else:
                 repo = claims_repo
         repo = repo or "unknown"
-        mode = str(params.get("mode", [MODE_REVIEW_ONLY])[0] or MODE_REVIEW_ONLY)
+        mode = str(params.get("mode", [MODE_REVIEW_AND_FIX])[0] or MODE_REVIEW_AND_FIX)
         _json_response(self, HTTPStatus.OK, {"status": "ok", "control": _automation_control_snapshot(repo, requested_mode=mode)})
 
     def _handle_automation_triage(self, claims: dict[str, Any], payload: dict[str, Any]) -> None:
@@ -1604,7 +1601,7 @@ def _handle_record_automation_run(self, claims: dict[str, Any], payload: dict[st
         control = _automation_control_snapshot(
             repo,
             task_name=task_name,
-            requested_mode=str(payload.get("mode") or MODE_REVIEW_ONLY),
+            requested_mode=str(payload.get("mode") or MODE_REVIEW_AND_FIX),
             pending_run={
                 "run_id": run_id,
                 "task_name": task_name,

service/automation_run_ledger.py

@@ -22,15 +22,13 @@
 CONTROL_REVIEW_ONLY = "review_only"
 CONTROL_PAUSE_AUTO_FIX = "pause_auto_fix"
 CONTROL_ESCALATE = "escalate"
-CONTROL_DEFER = "defer"
 
 CONTROL_ACTIONS = frozenset(
     {
         CONTROL_CONTINUE,
         CONTROL_REVIEW_ONLY,
         CONTROL_PAUSE_AUTO_FIX,
         CONTROL_ESCALATE,
-        CONTROL_DEFER,
     }
 )
 

tests/test_ai_gateway_automation_control.py

@@ -13,7 +13,7 @@
 
 
 class TestAutomationControlSnapshot(unittest.TestCase):
-    def test_control_snapshot_defaults_to_review_only_for_healthy_repo(self) -> None:
+    def test_control_snapshot_defaults_to_review_and_fix_for_healthy_repo(self) -> None:
         health = type("Health", (), {"status": "healthy"})()
         quota = type("Quota", (), {"runtime_status": lambda self, repo: {"status": "ok"}})()
         ledger = type("Ledger", (), {"snapshot": lambda self, limit=None: {"runs": []}})()
@@ -28,8 +28,8 @@ def test_control_snapshot_defaults_to_review_only_for_healthy_repo(self) -> None
             control = _automation_control_snapshot("QuantStrategyLab/TargetRepo")
 
         self.assertEqual(control["action"], "continue")
-        self.assertEqual(control["execution"]["effective_mode"], "review_only")
-        self.assertFalse(control["execution"]["auto_fix_allowed"])
+        self.assertEqual(control["execution"]["effective_mode"], "review_and_fix")
+        self.assertTrue(control["execution"]["auto_fix_allowed"])
 
     def test_control_snapshot_preserves_continue_for_explicit_review_and_fix_mode(self) -> None:
         health = type("Health", (), {"status": "healthy"})()
@@ -210,7 +210,7 @@ def test_control_snapshot_deduplicates_pending_run_by_run_id(self) -> None:
         self.assertEqual(control["action"], "continue")
         self.assertEqual(control["execution"]["consecutive_failures"], 1)
 
-    def test_control_snapshot_maps_defer_to_legacy_defer(self) -> None:
+    def test_control_snapshot_keeps_legacy_pause_for_defer(self) -> None:
         health = type("Health", (), {"status": "healthy"})()
         quota = type("Quota", (), {"runtime_status": lambda self, repo: {"status": "low"}})()
         ledger = type("Ledger", (), {"snapshot": lambda self, limit=None: {"runs": []}})()
@@ -227,8 +227,7 @@ def test_control_snapshot_maps_defer_to_legacy_defer(self) -> None:
         ):
             control = _automation_control_snapshot("QuantStrategyLab/TargetRepo", requested_mode="review_and_fix")
 
-        self.assertEqual(control["action"], "defer")
-        self.assertFalse(control["requires_human_review"])
+        self.assertEqual(control["action"], "pause_auto_fix")
         self.assertEqual(control["execution"]["action"], "defer")
 
     def test_control_snapshot_fails_closed_when_ledger_is_unavailable(self) -> None:

tests/test_ai_gateway_service_get_routes.py

@@ -580,7 +580,7 @@ def test_automation_routes_record_and_return_run_ledger(self) -> None:
 
                     with urllib.request.urlopen(f"{base_url}/v1/ai/automation/control?repo=local/repo", timeout=5) as response:
                         control = json.loads(response.read().decode("utf-8"))["control"]
-                    self.assertIn(control["action"], {"continue", "review_only", "pause_auto_fix", "escalate", "defer"})
+                    self.assertIn(control["action"], {"continue", "review_only", "pause_auto_fix", "escalate"})
                     self.assertIn("execution", control)
                 finally:
                     server.shutdown()