diff --git a/cmd/esbuild/service.go b/cmd/esbuild/service.go index 3b646985805..ae16287d24d 100644 --- a/cmd/esbuild/service.go +++ b/cmd/esbuild/service.go @@ -918,7 +918,7 @@ func (service *serviceType) convertPlugins(key int, jsPlugins interface{}, activ }}, nil } -func (service *serviceType) handleTransformRequest(id uint32, request map[string]interface{}) []byte { +func (*serviceType) handleTransformRequest(id uint32, request map[string]interface{}) []byte { inputFS := request["inputFS"].(bool) input := request["input"].(string) flags := decodeStringArray(request["flags"].([]interface{})) @@ -988,7 +988,7 @@ func (service *serviceType) handleTransformRequest(id uint32, request map[string }) } -func (service *serviceType) handleFormatMessagesRequest(id uint32, request map[string]interface{}) []byte { +func (*serviceType) handleFormatMessagesRequest(id uint32, request map[string]interface{}) []byte { msgs := decodeMessages(request["messages"].([]interface{})) options := api.FormatMessagesOptions{ @@ -1014,7 +1014,7 @@ func (service *serviceType) handleFormatMessagesRequest(id uint32, request map[s }) } -func (service *serviceType) handleAnalyzeMetafileRequest(id uint32, request map[string]interface{}) []byte { +func (*serviceType) handleAnalyzeMetafileRequest(id uint32, request map[string]interface{}) []byte { metafile := request["metafile"].(string) options := api.AnalyzeMetafileOptions{} diff --git a/internal/bundler/linker.go b/internal/bundler/linker.go index ec6b691fa4f..46ac63b97f9 100644 --- a/internal/bundler/linker.go +++ b/internal/bundler/linker.go @@ -1126,7 +1126,7 @@ func (a crossChunkImportArray) Less(i int, j int) bool { } // Sort cross-chunk imports by chunk name for determinism -func (c *linkerContext) sortedCrossChunkImports(chunks []chunkInfo, importsFromOtherChunks map[uint32]crossChunkImportItemArray) crossChunkImportArray { +func (*linkerContext) sortedCrossChunkImports(chunks []chunkInfo, importsFromOtherChunks map[uint32]crossChunkImportItemArray) crossChunkImportArray { result := make(crossChunkImportArray, 0, len(importsFromOtherChunks)) for otherChunkIndex, importItems := range importsFromOtherChunks { diff --git a/internal/css_ast/css_ast.go b/internal/css_ast/css_ast.go index 11f33e6e38c..edaeda2e887 100644 --- a/internal/css_ast/css_ast.go +++ b/internal/css_ast/css_ast.go @@ -314,7 +314,7 @@ func (*RAtImport) Equal(rule R) bool { return false } -func (r *RAtImport) Hash() (uint32, bool) { +func (*RAtImport) Hash() (uint32, bool) { return 0, false } diff --git a/internal/css_parser/css_decls_font_weight.go b/internal/css_parser/css_decls_font_weight.go index 6b8fe90acb7..e41dd7e2af6 100644 --- a/internal/css_parser/css_decls_font_weight.go +++ b/internal/css_parser/css_decls_font_weight.go @@ -7,7 +7,7 @@ import ( "github.com/evanw/esbuild/internal/css_lexer" ) -func (p *parser) mangleFontWeight(token css_ast.Token) css_ast.Token { +func (*parser) mangleFontWeight(token css_ast.Token) css_ast.Token { if token.Kind != css_lexer.TIdent { return token } diff --git a/internal/css_parser/css_decls_transform.go b/internal/css_parser/css_decls_transform.go index e5cdbae63e6..e8a0ac02147 100644 --- a/internal/css_parser/css_decls_transform.go +++ b/internal/css_parser/css_decls_transform.go @@ -18,7 +18,7 @@ func turnPercentIntoNumberIfShorter(t *css_ast.Token) { // https://www.w3.org/TR/css-transforms-1/#two-d-transform-functions // https://drafts.csswg.org/css-transforms-2/#transform-functions -func (p *parser) mangleTransforms(tokens []css_ast.Token) []css_ast.Token { +func (*parser) mangleTransforms(tokens []css_ast.Token) []css_ast.Token { for i := range tokens { if token := &tokens[i]; token.Kind == css_lexer.TFunction { if args := *token.Children; css_ast.TokensAreCommaSeparated(args) { diff --git a/internal/fs/fs.go b/internal/fs/fs.go index 353df7650e6..ac709edf9cd 100644 --- a/internal/fs/fs.go +++ b/internal/fs/fs.go @@ -151,7 +151,7 @@ func (f *InMemoryOpenedFile) Read(start int, end int) ([]byte, error) { return []byte(f.Contents[start:end]), nil } -func (f *InMemoryOpenedFile) Close() error { +func (*InMemoryOpenedFile) Close() error { return nil } diff --git a/internal/fs/fs_mock.go b/internal/fs/fs_mock.go index e5392850f3f..50bb852650d 100644 --- a/internal/fs/fs_mock.go +++ b/internal/fs/fs_mock.go @@ -69,7 +69,7 @@ func (fs *mockFS) OpenFile(path string) (OpenedFile, error, error) { return nil, syscall.ENOENT, syscall.ENOENT } -func (fs *mockFS) ModKey(path string) (ModKey, error) { +func (*mockFS) ModKey(path string) (ModKey, error) { return ModKey{}, errors.New("This is not available during tests") } @@ -148,10 +148,10 @@ func (*mockFS) Rel(base string, target string) (string, bool) { return commonParent + target, true } -func (fs *mockFS) kind(dir string, base string) (symlink string, kind EntryKind) { +func (*mockFS) kind(dir string, base string) (symlink string, kind EntryKind) { panic("This should never be called") } -func (fs *mockFS) WatchData() WatchData { +func (*mockFS) WatchData() WatchData { panic("This should never be called") } diff --git a/internal/graph/input.go b/internal/graph/input.go index 2a54fc987b9..62a1c0dc324 100644 --- a/internal/graph/input.go +++ b/internal/graph/input.go @@ -120,6 +120,6 @@ type CopyRepr struct { URLForCode string } -func (repr *CopyRepr) ImportRecords() *[]ast.ImportRecord { +func (*CopyRepr) ImportRecords() *[]ast.ImportRecord { return nil } diff --git a/internal/js_parser/js_parser.go b/internal/js_parser/js_parser.go index e7aa849b2f5..4314aa9b4bc 100644 --- a/internal/js_parser/js_parser.go +++ b/internal/js_parser/js_parser.go @@ -8936,7 +8936,7 @@ func (p *parser) mangleIfExpr(loc logger.Loc, e *js_ast.EIf) js_ast.Expr { return js_ast.Expr{Loc: loc, Data: e} } -func (p *parser) isAnonymousNamedExpr(expr js_ast.Expr) bool { +func (*parser) isAnonymousNamedExpr(expr js_ast.Expr) bool { switch e := expr.Data.(type) { case *js_ast.EArrow: return true @@ -10053,7 +10053,7 @@ func (p *parser) maybeRelocateVarsToTopLevel(decls []js_ast.Decl, mode relocateV return js_ast.Stmt{Loc: value.Loc, Data: &js_ast.SExpr{Value: value}}, true } -func (p *parser) markExprAsParenthesized(value js_ast.Expr) { +func (*parser) markExprAsParenthesized(value js_ast.Expr) { switch e := value.Data.(type) { case *js_ast.EArray: e.IsParenthesized = true @@ -11568,7 +11568,7 @@ func (p *parser) isValidAssignmentTarget(expr js_ast.Expr) bool { } // "`a${'b'}c`" => "`abc`" -func (p *parser) mangleTemplate(loc logger.Loc, e *js_ast.ETemplate) js_ast.Expr { +func (*parser) mangleTemplate(loc logger.Loc, e *js_ast.ETemplate) js_ast.Expr { // Can't inline strings if there's a custom template tag if e.TagOrNil.Data == nil { end := 0 diff --git a/internal/js_parser/js_parser_lower.go b/internal/js_parser/js_parser_lower.go index e3ea2d34162..607521465e7 100644 --- a/internal/js_parser/js_parser_lower.go +++ b/internal/js_parser/js_parser_lower.go @@ -777,7 +777,7 @@ flatten: } } -func (p *parser) lowerParenthesizedOptionalChain(loc logger.Loc, e *js_ast.ECall, childOut exprOut) js_ast.Expr { +func (*parser) lowerParenthesizedOptionalChain(loc logger.Loc, e *js_ast.ECall, childOut exprOut) js_ast.Expr { return childOut.thisArgWrapFunc(js_ast.Expr{Loc: loc, Data: &js_ast.ECall{ Target: js_ast.Expr{Loc: loc, Data: &js_ast.EDot{ Target: e.Target, diff --git a/internal/js_parser/ts_parser.go b/internal/js_parser/ts_parser.go index 811d1a3b52d..2977cd4a60a 100644 --- a/internal/js_parser/ts_parser.go +++ b/internal/js_parser/ts_parser.go @@ -1854,7 +1854,7 @@ func (p *parser) generateClosureForTypeScriptEnum( return stmts } -func (p *parser) wrapInlinedEnum(value js_ast.Expr, comment string) js_ast.Expr { +func (*parser) wrapInlinedEnum(value js_ast.Expr, comment string) js_ast.Expr { if strings.Contains(comment, "*/") { // Don't wrap with a comment return value diff --git a/internal/xxhash/xxhash.go b/internal/xxhash/xxhash.go index 15c835d5417..7f8f70570b5 100644 --- a/internal/xxhash/xxhash.go +++ b/internal/xxhash/xxhash.go @@ -59,10 +59,10 @@ func (d *Digest) Reset() { } // Size always returns 8 bytes. -func (d *Digest) Size() int { return 8 } +func (*Digest) Size() int { return 8 } // BlockSize always returns 32 bytes. -func (d *Digest) BlockSize() int { return 32 } +func (*Digest) BlockSize() int { return 32 } // Write adds more data to d. It always returns len(b), nil. func (d *Digest) Write(b []byte) (n int, err error) {