From 59d7504b616d6e56ae893c2abf18100585c170fb Mon Sep 17 00:00:00 2001 From: Srijan Saurav <68371686+srijan-deepsource@users.noreply.github.com> Date: Thu, 15 Dec 2022 16:20:08 +0530 Subject: [PATCH 1/3] Update User.php Signed-off-by: Srijan Saurav <68371686+srijan-deepsource@users.noreply.github.com> --- php/src/User.php | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/php/src/User.php b/php/src/User.php index 9baccb59..5487b86a 100644 --- a/php/src/User.php +++ b/php/src/User.php @@ -21,3 +21,12 @@ public function setUser(string|array|string $data): void ]); } } + +$conn = 'db-connect'; +​ +$offset = $argv[0]; // beware, no input validation! +$query = "SELECT id, name FROM products ORDER BY name LIMIT 20 OFFSET $offset;"; +$result = pg_query($conn, $query); +​ +$sql = "SELECT * FROM users WHERE id = " . $_GET['id']; +$result = pg_query($conn, $sql); From c9eb6cb0de40aaa887485a267d1cfac942da01d9 Mon Sep 17 00:00:00 2001 From: Srijan Saurav <68371686+srijan-deepsource@users.noreply.github.com> Date: Thu, 15 Dec 2022 16:31:39 +0530 Subject: [PATCH 2/3] Update php/src/User.php Signed-off-by: Srijan Saurav <68371686+srijan-deepsource@users.noreply.github.com> --- php/src/User.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/php/src/User.php b/php/src/User.php index 5487b86a..58832dc3 100644 --- a/php/src/User.php +++ b/php/src/User.php @@ -23,10 +23,10 @@ public function setUser(string|array|string $data): void } $conn = 'db-connect'; -​ + $offset = $argv[0]; // beware, no input validation! $query = "SELECT id, name FROM products ORDER BY name LIMIT 20 OFFSET $offset;"; $result = pg_query($conn, $query); -​ + $sql = "SELECT * FROM users WHERE id = " . $_GET['id']; $result = pg_query($conn, $sql); From 976511ff67a9fc31257718009a18dfb103f81a5c Mon Sep 17 00:00:00 2001 From: Srijan Saurav <68371686+srijan-deepsource@users.noreply.github.com> Date: Thu, 15 Dec 2022 16:35:59 +0530 Subject: [PATCH 3/3] Update php/src/User.php Signed-off-by: Srijan Saurav <68371686+srijan-deepsource@users.noreply.github.com> --- php/src/User.php | 1 + 1 file changed, 1 insertion(+) diff --git a/php/src/User.php b/php/src/User.php index 58832dc3..ef8827ce 100644 --- a/php/src/User.php +++ b/php/src/User.php @@ -30,3 +30,4 @@ public function setUser(string|array|string $data): void $sql = "SELECT * FROM users WHERE id = " . $_GET['id']; $result = pg_query($conn, $sql); +$sql_res = mysqli_query($conn, $sql);