Language: const expressions with array_find() must compile-fatal (re-#6843, zend_compile.c)

[PurHur]

Category

language — compile-time validation

Problem

Class/const constant expressions that call non-constexpr builtins must be a compile-time fatal in Zend. Closed #6843 added this guard, but const C = array_find([...], fn(...) => ...) still compiles and evaluates at runtime in this compiler.

php-src reference

• php/php-src Zend/zend_compile.c — zend_compile_const_expr / invalid operations in constant expressions
• php/php-src ext/standard/array.c — array_find() (not constexpr)

Repro

test/repro/maintainer_const_array_find.php:

<?php
const C = array_find([1, 2, 3], fn($v) => $v > 1);
var_export(C);
echo "\n";

php test/repro/maintainer_const_array_find.php
# Zend: Fatal error: Constant expression contains invalid operations

./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/maintainer_const_array_find.php'
# VM today: 2

	Zend	VM today
const C = array_find(...)	compile fatal	compiles; prints 2

Scope

• lib/Compiler.php (or php-cfg) constant-expression validator — reject function calls / closures in const initializers unless Zend-constexpr
• VM must not evaluate illegal const expressions at runtime
• Shared with enum/class const and define() constexpr paths where applicable

Done when

• Repro fails at compile time with Zend-equivalent fatal (not runtime 2)
• Guard covers array_find and other non-constexpr builtins in const context
• ./script/ci-fast.sh --filter ConstExpr or new compliance PHPT green
• php-src-strict

Links

• Language: class/enum constant expressions with function calls — must compile-fatal (zend_compile.c) #6843 (closed — function calls in class const expressions)
• Stdlib: array_find()/array_find_key()/array_all()/array_any() — PHP 8.4 $strict third parameter missing (ext/standard/array.c) #6949 (array_find $strict parameter — separate runtime parity)

[PurHur]

claim: worker-lane-b — starting this run

[PurHur]

Merged via #8821.

Fix: Extended ThrowInClassConstCompileCheck to walk file-scope const terminals and reject function calls, closures, and arrow functions — same guard as class/enum constants (#6843).

Verification:

• php bin/vm.php test/repro/maintainer_const_array_find.php → compile fatal: Constant expression contains invalid operations
• vendor/bin/phpunit test/unit/ThrowInClassConstCompileCheckTest.php --filter GlobalConst → OK (3 tests)
• ./script/docker-exec.sh -- bash -lc 'vendor/bin/phpunit test/compliance/VMTest.php --filter global_const_func_call' → OK (1 test)