bug: format_text false values are reported as success but ignored

[kiki830621]

Problem

format_text(paragraph_index: ..., bold: false) reports success but leaves existing <w:b/> formatting unchanged. The handler builds a fresh RunProperties, assigns bold = false, and calls Document.formatParagraph; the current upstream merge applies only true values, so false is indistinguishable from an omitted argument.

The same ambiguity affects italic: false and underline: false at the public tool boundary.

Type

bug

Expected

• Omitted formatting arguments leave existing run properties unchanged.
• bold: false and italic: false explicitly remove/disable those properties.
• underline: false explicitly removes underline.
• The tool reports success only when the requested mutation is represented and persists after save/reopen.

Actual

format_text returns Applied formatting to paragraph N, but false boolean values are swallowed by the downstream additive merge.

Scope / Acceptance

• Depend on the tri-state/presence correction tracked by bug: preserve explicit false run properties across read/write ooxml-swift#115.
• Add MCP-level RED→GREEN tests for omitted vs true vs false formatting arguments.
• Verify bold:false, italic:false, and underline:false persist after save/reopen without changing unrelated run properties.
• Preserve existing as_revision behavior or fail loudly if explicit false revision formatting is not representable.
• Update public tool descriptions if needed; run focused and full che-word-mcp suites.

Cross-repo tracking

• Parent: format_text bold:false is a no-op — cannot remove existing boolean formatting macdoc#174
• Shared root cause / round-trip impact: Boolean run property w:val="0" dropped on save — bold spreads to untouched runs macdoc#173
• Upstream model: bug: preserve explicit false run properties across read/write ooxml-swift#115

---

Current Status

Phase: implemented (draft dependency integration)
Last updated: 2026-08-31 by idd-implement

Key Decisions

• Omitted formatting arguments remain unchanged; explicit false removes bold/italic/underline.
• Revision-mode formatting starts from current run properties before applying the partial patch.
• ooxml 3.5.x rawSlotExecutionFailure has an explicit MCP error mapping.

Blocking

• Draft PR refactor: honor false text formatting #198 pins upstream program SHA 563039c and must not merge.
• Awaiting verified bug: preserve explicit false run properties across read/write ooxml-swift#115 / PR parseMathComponent: add recursion depth cap to prevent JSON-tree DoS #116 merge and release; then replace the revision with a released version constraint and rerun final verify.

Commits

• 3353186 — consumer behavior and tests.
• cd3e592 — final exact upstream pin.

Verification

• Focused 2/2; full 347 tests with 12 skips and 0 failures.
• Upstream Add math-script match options to insertion anchors #115 full verify: refactor: preserve explicit false run properties ooxml-swift#116 (comment)

Pull Request

• Draft refactor: honor false text formatting #198

[kiki830621]

Implementation Draft Complete

Changes

• 3353186 — format_text false persisted mutation、as_revision partial-patch preservation、ooxml 3.5.x error compatibility、MCP save/reopen tests。
• Draft PR: refactor: honor false text formatting #198
• Upstream dependency: bug: preserve explicit false run properties across read/write ooxml-swift#115 / PR parseMathComponent: add recursion depth cap to prevent JSON-tree DoS #116 / frozen 8cc8e48。

Verification

• Released 3.4.0 RED: normal format path有 3 個 persisted-format failures。
• Revision RED: explicit false清除 bold 時，omitted italic 被錯誤清除。
• Upstream exact revision GREEN: focused 2/2；full che-word-mcp 347 tests，12 skips，0 failures。

Blocking

• Draft 目前精確 pin upstream commit，只供 integration CI；不可合併。
• 等 PR parseMathComponent: add recursion depth cap to prevent JSON-tree DoS #116 合併並發版後，須改回 released version constraint、重跑全套與 final verify。