Skip to content

What's That: reference image title overlays the bottom corner of the image #708

Description

@WilfordGrimley

Part of #704.

Reported symptom

Owner: "The reference image has it's title blocking the bottom corner."

Code evidence

SubjectArtTitle (QuestionFeed.tsx:220-232) is styled with position: absolute; left: 0; right: 0; bottom: 0; z-index: 2; a dark linear-gradient background (transparent to rgba(0,0,0,0.72)); white, 700-weight text at clamp(13px, 3.4cqi, 17px); and padding 22px 10px 8px.

It renders as the last child of SubjectArt (QuestionFeed.tsx:1233-1236: SubjectArt wraps cardArt then SubjectArtTitle), stacked directly on top of the card art via position:absolute + bottom:0 + z-index:2, and is identically reused for the artist/tag question types at QuestionFeed.tsx:1742-1755. It always renders unconditionally - there is no check against the underlying artwork's own bottom-corner content (a mana cost, set symbol, or collector info printed into the scan itself) - so its dark gradient plus the full card name text sits directly over whatever art occupies the bottom of the reference image, matching the reported "blocking the bottom corner."

Confirmed / Refuted / Inconclusive

Confirmed. SubjectArtTitle is an always-on, absolutely-positioned overlay pinned to the bottom edge of the subject art, with no mechanism to avoid overlapping card-art detail there.

Scope

Touches SubjectArtTitle (QuestionFeed.tsx) and its two render sites (SubjectCard, QuestionFeed.tsx:1231-1242, and the artist/tag cardNode, QuestionFeed.tsx:1739-1758). A fix could move the title out of the art entirely into SubjectCap (QuestionFeed.tsx:234-264, the existing caption strip below the art) rather than overlaying it, or shrink/reposition the overlay so it only covers a margin strip instead of a full-width band. Either approach changes the subject-card composition shared by every question type on this page (confirm_suggestion, identify_printing, artist, tag), so it needs one visual pass across all four, not a per-type patch.

Layout-pass coupling

Directly coupled to the "reference card should stay visible while scrolling / page uses vertical space poorly" item - both touch the same SubjectCard/SubjectArt/SubjectCap composition, and moving the title into SubjectCap (this issue's likely fix) changes the vertical space budget that item is trying to reclaim. Should be designed together, not sequenced as independent patches.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions