Fix toSearchable to not strip mid-string "the" (completes #460)

PR #460 fixed the backend's to_searchable() (search/sanitisation.py) so
it no longer strips the word "the" from the middle of card names (issue
#435), but the frontend's hand-maintained mirror of that logic in
processing.ts was never updated to match, so it still mangled names like
"Adanto, the First Fort" into "adanto first fort" instead of the correct
"adanto the first fort". Removes the same two lines #460 removed from the
backend, and updates the test case that was asserting the buggy output.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: WilfordGrimley

frontend/src/common/processing.test.ts

@@ -501,7 +501,10 @@ describe("toSearchable", () => {
   test.each([
     { input: "Lightning Bolt", expectedOutput: "lightning bolt" },
     { input: " Lightning   BOLT ", expectedOutput: "lightning bolt" },
-    { input: "Adanto, the First Fort", expectedOutput: "adanto first fort" },
+    {
+      input: "Adanto, the First Fort",
+      expectedOutput: "adanto the first fort",
+    },
     { input: "Black Lotus (Masterpiece)", expectedOutput: "black lotus" }, // brackets removal
     {
       input: "Black Lotus (Masterpiece, But With Punctuation! )",

frontend/src/common/processing.ts

@@ -389,11 +389,9 @@ export const toSearchable = (inputString: string): string =>
       .toLowerCase()
       .replaceAll(/[\(\[].*?[\)\]]/g, "")
       .replace("-", " ")
-      .replace(" the ", " ")
       .replace("’", "'")
       .replaceAll(/[!"#\$%&'\(\)\*\+,-\.\/:;<=>\?@\[\]\^_`{\|}~\/]/g, "") // remove punctuation
       .replaceAll(/[0123456789]/g, "") // remove digits
-      .replaceAll(/^the (.*$)/g, "$1") // remove "the " at start of string
       // remove accents - match elasticsearch `asciifolding` filter. https://stackoverflow.com/a/37511463/13021511
       .normalize("NFD")
       .replace(/\p{Diacritic}/gu, "")