Updates

Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>

Author: ericspod

.github/workflows/cicd_tests.yml

@@ -275,12 +275,13 @@ jobs:
     - name: Install dependencies + nvsubquadratic (no-deps)
       run: |
         python -m pip install --upgrade pip wheel tomli pytest
-        python monai/config/print_dependencies.py build-system | xargs pip install --no-build-isolation
-        python -m pip install torch==${PYTORCH_VER1} torchvision==${TORCHVISION_VER1}
+        # need a specific version of torch for nvsubquadratic
+        python monai/config/print_dependencies.py build-system | \
+          xargs -d '\n' pip install --no-build-isolation torch==2.10.0 torchvision==0.25.0
         # # nvsubquadratic runtime imports need only torch + einops + omegaconf; install
         # # the package itself without its core dependency tree (see job comment above).
-        # python -m pip install omegaconf
-        # python -m pip install --no-deps 'nvsubquadratic>=0.1.1'
+        python -m pip install --no-build-isolation omegaconf
+        python -m pip install --no-build-isolation --no-deps 'nvsubquadratic>=0.1.1'
         python -m pip install --no-build-isolation .[hyena,testing]
         python -m pip list
       shell: bash
@@ -298,6 +299,7 @@ jobs:
     runs-on: ubuntu-latest
     env:
       QUICKTEST: True
+      INDEX_URL: "https://download.pytorch.org/whl/cpu"
     steps:
     - name: Clean unused tools
       run: |
@@ -318,11 +320,8 @@ jobs:
       run: |
         python -m pip install --user --upgrade pip setuptools wheel twine packaging tomli
         # install the latest pytorch for testing
-        # however, "pip install monai*.tar.gz" will build cpp/cuda with an isolated
-        # fresh torch installation according to pyproject.toml
-        python -m pip install torch==${PYTORCH_VER1} torchvision --extra-index-url https://download.pytorch.org/whl/cpu
-        python monai/config/print_dependencies.py build-system all testing > requirements.txt
-        pip install --no-build-isolation -r requirements.txt
+        python monai/config/print_dependencies.py build-system all testing | \
+            xargs -d '\n' pip install --no-build-isolation torch==${PYTORCH_VER1} --extra-index-url $INDEX_URL
     - name: Check packages
       run: |
         python -m pip uninstall -y monai
@@ -351,7 +350,7 @@ jobs:
       working-directory: ${{ steps.mktemp.outputs.tmp_dir }}
       run: |
         # install from wheel
-        python -m pip install monai*.whl --extra-index-url https://download.pytorch.org/whl/cpu
+        python -m pip install --no-build-isolation monai*.whl --extra-index-url $INDEX_URL
         python -c 'import monai; monai.config.print_config()' 2>&1 | grep -iv "unknown"
         python -c 'import monai; print(monai.__file__)'
         python -m pip uninstall -y monai
@@ -361,6 +360,14 @@ jobs:
       run: |
         for name in *.tar.gz; do break; done
         echo $name
-        python -m pip install ${name}[all] --extra-index-url https://download.pytorch.org/whl/cpu
+        python -m pip install --no-build-isolation ${name}[all] --extra-index-url $INDEX_URL
+        python -c 'import monai; monai.config.print_config()' 2>&1 | grep -iv "unknown"
+        python -c 'import monai; print(monai.__file__)'
+        python -m pip uninstall -y monai
+    - name: Install using uv
+      working-directory: ${{ steps.mktemp.outputs.tmp_dir }}
+      run: |
+        pip install uv
+        uv pip install --no-build-isolation .[all] --extra-index-url $INDEX_URL
         python -c 'import monai; monai.config.print_config()' 2>&1 | grep -iv "unknown"
         python -c 'import monai; print(monai.__file__)'

Dockerfile

@@ -49,7 +49,8 @@ COPY LICENSE CHANGELOG.md CODE_OF_CONDUCT.md CONTRIBUTING.md README.md versionee
 COPY tests ./tests
 COPY monai ./monai
 
-# Need to install build requirements explicitly so that no-build-isolation can be used. This needed to make pip build
-# against the included version of PyTorch, rather than install a new version in the isolated environment.
+# Need to install build requirements explicitly so that no-build-isolation can be used. This is needed to make pip build
+# against the included version of PyTorch, rather than install a new version in the isolated environment. Constraint
+# files will not work for this image which installed things like PyTorch through files which are no longer present.
 RUN python monai/config/print_dependencies.py build-system | xargs -d '\n' pip install --no-cache-dir --no-build-isolation \
   && FORCE_CUDA=1 pip install --no-cache-dir --no-build-isolation -e .[all,testing]

docs/source/installation.md

@@ -130,33 +130,39 @@ or, to build with MONAI C++/CUDA extensions:
 BUILD_MONAI=1 pip install git+https://github.com/Project-MONAI/MONAI
 ```
 
-To build the extensions, if the system environment already has a version of PyTorch installed,
-`--no-build-isolation` might be preferred:
-
-```bash
-BUILD_MONAI=1 pip install --no-build-isolation git+https://github.com/Project-MONAI/MONAI
-```
-
-When using build isolation (pip's default behaviour), a version of PyTorch must be installed which may not be the same as an existing install. This can cause the compiled libraries to be built against an ABI-incompatible PyTorch and thus not function at runtime. Building without isolation requires the current environment to have the necessary building libraries already installed. See the `build-system` section of `pyproject.toml` for these libraries, or use the following to install them:
-
-```bash
-python monai/config/print_dependencies.py build-system | xargs -d '\n' pip install --no-build-isolation
-```
-
 On Windows the inline `BUILD_MONAI=1 pip install ...` form is not supported by
 `cmd.exe` or PowerShell. Set the environment variable first, then run either
 install command shown above:
 
 ```bat
 :: cmd.exe
 set BUILD_MONAI=1
-pip install --no-build-isolation git+https://github.com/Project-MONAI/MONAI
+pip install git+https://github.com/Project-MONAI/MONAI
 ```
 
 ```powershell
 # PowerShell
 $env:BUILD_MONAI="1"
-pip install --no-build-isolation git+https://github.com/Project-MONAI/MONAI
+pip install git+https://github.com/Project-MONAI/MONAI
+```
+
+To build the extensions, if the system environment already has a version of PyTorch installed, `--no-build-isolation` might be preferred:
+
+```bash
+BUILD_MONAI=1 pip install --no-build-isolation git+https://github.com/Project-MONAI/MONAI
+```
+
+When using build isolation (pip's default behaviour), a version of PyTorch must be installed which may not be the same as an existing install. This can cause the compiled libraries to be built against an ABI-incompatible PyTorch and thus not function at runtime. Building without isolation requires the current environment to have the necessary building libraries already installed. See the `build-system` section of `pyproject.toml` for these libraries, or use the following to install them in a bash environment:
+
+```bash
+python monai/config/print_dependencies.py build-system | xargs -d '\n' pip install --no-build-isolation
+```
+
+An alternative solution is to use built constraints during installation:
+
+```bash
+pip freeze | grep torch > constraints.txt
+pip install --build-constraint constraints.txt git+https://github.com/Project-MONAI/MONAI
 ```
 
 this command will download and install the current `dev` branch of [MONAI from
@@ -178,6 +184,7 @@ You can install it by running:
 ```bash
 cd MONAI/
 pip install -e .
+# or pip install -e .[all,testing] to include most of the dependencies
 ```
 
 or, to build with MONAI C++/CUDA extensions and install:
@@ -205,6 +212,8 @@ $env:BUILD_MONAI="1"
 pip install -e .
 ```
 
+If the compiled extensions were built by pip against a different version of PyTorch than the one in your environment, you may need to run the above with the `--no-build-isoloation` flag to force the use of that version, or use the `--build-constraint` method.
+
 To uninstall the package please run:
 
 ```bash

pyproject.toml

@@ -1,7 +1,7 @@
 
 [build-system]
 requires = [
-  "setuptools<71.0.0",  # pkg_resources removed in setuptools>=71; needed by MetricsReloaded setup.py
+  "setuptools",
   "wheel",
   "versioneer[toml]",
   "more-itertools>=8.0",
@@ -41,8 +41,7 @@ classifiers = [
 ]
 dependencies = [
   "torch>=2.8.0",
-  "numpy>=1.24,<3.0",
-  "setuptools<71.0.0"  # used here to match requirement in build-system and prevent different PyTorch installations
+  "numpy>=1.24,<3.0"
 ]
 dynamic = ["version"]
 
@@ -276,6 +275,8 @@ exclude = '''
     | \.hg
     | \.tox
     | \.venv
+    | \.mypy_cache
+    | \.pytype
     | venv
     | _build
     | buck-out
@@ -382,7 +383,7 @@ project-excludes = [
 ]
 
 # Match CI environment
-python-version = "3.9"
+python-version = "3.10"
 python-platform = "linux"
 
 # "legacy" preset provides a smooth migration from previous type checkers