Skip to content

Commit 5be3db9

Browse files
authored
Enable macOS Install Test Only (#8976)
### Description macOS tests are really slow and disabled for now in the CI system, see #8864. This change will enable most of the test again except for the actual unit tests, so this will test the build and install only. Subsequent changes will look into re-enabling a subset of tests for macOS. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
1 parent f1dcac4 commit 5be3db9

1 file changed

Lines changed: 13 additions & 4 deletions

File tree

.github/workflows/cicd_tests.yml

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ jobs:
171171
strategy:
172172
fail-fast: false
173173
matrix:
174-
os: [windows-latest, ubuntu-latest] # macOS-latest omitted for now for being very slow, see #8864
174+
os: [windows-latest, ubuntu-latest, macOS-latest] # macOS-latest is very slow (#8864), testing install only
175175
timeout-minutes: 120
176176
env:
177177
QUICKTEST: True
@@ -223,19 +223,28 @@ jobs:
223223
cat "requirements-dev.txt"
224224
python -m pip install --no-build-isolation -r requirements-dev.txt
225225
python -m pip list
226-
python -m pip install -e . # test no compile installation
226+
python -m pip install --no-build-isolation -e . # test no compile installation
227227
shell: bash
228228
- name: Run compiled (${{ runner.os }})
229229
run: |
230230
python -m pip uninstall -y monai
231-
BUILD_MONAI=1 python -m pip install -e . # compile the cpp extensions
231+
BUILD_MONAI=1 python -m pip install --no-build-isolation -e . # compile the cpp extensions
232232
shell: bash
233-
- name: Run quick tests
233+
- if: runner.os != 'macOS'
234+
name: Run full tests
234235
run: |
235236
python -c 'import torch; print(torch.__version__); print(torch.rand(5,3))'
236237
python -c "import monai; monai.config.print_config()"
237238
python -m unittest -v
238239
shell: bash
240+
- if: runner.os == 'macOS'
241+
name: Run min tests
242+
run: |
243+
python -c 'import torch; print(torch.__version__); print(torch.rand(5,3))'
244+
python -c "import monai; monai.config.print_config()"
245+
# TODO: enable large range of macOS tests which don't take a very long time
246+
./runtests.sh --min
247+
shell: bash
239248

240249
packaging: # Test package generation
241250
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)