[#534] Custom endpoint docs: selecting models, common setups, quickstart breadcrumb #2020
Replies: 6 comments
Independent verification on current
|
| #534 item | Status on main |
|---|---|
1. ~/.pi/agent/ path |
Already fixed — no ~/.pi/agent/ left under packages/coding-agent/docs/ |
| 2. Quickstart custom-endpoint breadcrumb | Still missing |
| 3. Index / nav buries Custom Models under Customization | Still true (index.md + docs.json) |
4. CLI --provider / --model provider/id examples in models.md |
Still missing (examples live in usage.md / providers.md for built-ins only) |
5. Common setups + error→compat shortcut |
Still missing as a dedicated section |
6. /login surfaces models.json providers |
Still undocumented; confirmed in source via getLoginProviderOptions → modelRegistry.getAll() providers in auth-flows.ts |
Also checked prior cold PR #976 (same scope, auto-closed) — so Discussion-first is the right path.
Ready branch (docs-only, rebased on current main)
Branch: docs/534-custom-endpoint-discoverability (local; will push when invited).
Same core fix set as @FekyBaz's fork branch, plus three small deltas after re-reading the files in full:
- Section order —
Selecting Custom Models/Common Setupsnow sit after Minimal Example and before Full Example (matches the ToC; the earlier patch had body order inverted). - Common setups include typical
compat— Ollama / vLLM / LM Studio / generic proxy snippets ship withsupportsDeveloperRole+supportsReasoningEffortset tofalse, matching what Custom endpoint documentation gaps for new open-source users #534 asked for and what the Minimal Example already teaches. - Nav promotion — Custom Models + Custom Providers moved into Start Here in both
index.mdanddocs.json(not only an inline cross-link on the Providers bullet).
Happy to stay second author / fold into @FekyBaz's branch if maintainers prefer a single PR author. Not opening a PR until invited (per CONTRIBUTING.md).
|
Thanks for the independent verification, @Kornisburg — glad we converged on all six points, and good catch on the cold PR #976 history; Discussion-first it is. On your three deltas, all accepted:
On process: one PR is better than two for the maintainers here since our core sets are identical. Proposal — I'll apply the three deltas above to my branch ( |
|
@FekyBaz Yes, Happy to fold everything into your branch as the co-author. |
|
@Kornisburg @koenigs — thank you both for the independent verification, and yes, let's fold everything into I accept all three deltas:
Next step: please push your branch to your fork and open a PR targeting |
|
@FekyBaz — PR is open as you asked: FekyBaz/prime-agent#1 ( Thanks for the careful guidance here — pairing the independent verification, the three deltas, and folding everything into a single branch was a much cleaner path than two competing PRs. Appreciate you carrying this through to the maintainers. |
|
@koenigs @Kornisburg — folded and cleaned up: New branch: What I did with your PR #1: it couldn't merge as-is — the head branch carried the full upstream history with it, which would have polluted
I closed #1 as superseded (nothing lost — authorship preserved via |
Uh oh!
There was an error while loading. Please reload this page.
Hi, following up on #534 (custom endpoint documentation gaps). I checked each of the six suggested fixes against current
mainand implemented what's still missing. Per CONTRIBUTING.md I'm posting here first instead of opening a PR, and would like an implementation invite if the approach looks good.What I found
models.mdandproviders.mdconsistently use~/.prime/agent/— no~/.pi/agent/references remain inpackages/coding-agent/docs/. No change needed.Changes (branch
FekyBaz/prime-agent@docs/custom-endpoints-534, not a PR)models.md: newSelecting Custom Modelssection with CLI examples verified againstsrc/cli/args.ts+resolveCliModel(--provider ollama --model llama3.1:8band--model ollama/llama3.1:8b),/modelpicker note, and a/loginkey-storage note verified againstgetLoginProviderOptions/isApiKeyLoginProviderinauth-flows.ts(models.json custom providers do appear in the/loginselector). NewCommon Setupssection with copy-paste vLLM, LM Studio, and generic-proxy configs plus an error→compat-flag troubleshooting table built only from mappings already documented in the file (developerrole →supportsDeveloperRole: false,reasoning_effort→supportsReasoningEffort: false, Anthropic-proxy tool streaming →supportsEagerToolInputStreaming: false). ToC updated.quickstart.md: newOption 3: Custom Endpointunder Authenticate (5 lines + minimal Ollama JSON + link tomodels.md), andNext stepsnow linksmodels.mdandcustom-provider.md.index.md: the Start HereProvidersentry now cross-linksCustom modelsandCustom providers(minimal discoverability fix; left the Customization section structure untouched).providers.md: theVia models.jsonbullet now notes that custom providers appear in/loginfor key storage.Validation
args.ts,model-resolver.ts,auth-flows.ts) or existing documented tables — no new factual claims.usage.md,custom-provider.md,#selecting-custom-models,#common-setups,#value-resolution,#openai-compatibility,#anthropic-messages-compatibility).vitest/tsgo/biomescope is unaffected (I ran those suites for my earlier Non-worker draft discard: unobserved closeSession rejection can exit the process; pendingAttaches window discards a draft mid-attach #1922/fix: handle empty env vars in config (prevent relative path bug) #1811 patches on this machine).Happy to adjust scope or wording before opening a PR. Thanks!
All reactions