[Bug] ACP mode never sends available_commands_update, so slash commands and skills cannot be completed #1354
AndriyPytel
started this conversation in
Bug reports
Replies: 1 comment
|
@sethkarten flagging this to you directly since you wrote ACP mode, and this category is new enough that nothing here has been seen yet. Context for why I care: I drive Prime Agent through ACP every day rather than through the TUI, and this is the thing I trip over most. The commands are all there in the session, the client simply is never told about them, so anything loaded as a skill is invisible unless you already know its name. The fix turned out to be small, so I wrote it up as #1308 with a test that fails on |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Affected area
Coding agent and CLI (ACP mode)
What happened?
prime-agent --mode acpnever sends anavailable_commands_updatenotification, so an ACP client receives no command list for the session. The same session in the TUI completes every slash command, skill, and prompt template; over ACP a user has to type/skill:<name>blind, with no way to discover what is loaded.ACP has a first-class
available_commands_updatesession update for exactly this, and clients use it to drive completion.Steps to reproduce
prime-agent --mode acp.initialize, thensession/new.session/updatenotifications.available_commands_updateever arrives; the client's command list stays empty.Expected behavior
After
session/new, the agent advertises the commands a prompt turn can actually execute: the session slash commands (compact,refine,goal,autonomous), plus everythingconnection.getCommands()returns — skills asskill:<name>, prompt templates, and extension commands.Commands whose
executionis not"session"(/model,/settings,/export) should stay out: they open a TUI selector and have no headless behavior, so completing to them would only insert prompt text.Prime Agent version
0.7.1 (also reproduced on
mainat 7787f07)Environment
macOS,
prime-agent --mode acpdriven over stdio by an ACP clientAdditional context
Tracked as #1306. A focused patch with a test that drives a real
@agentclientprotocol/sdkclient over an in-memory duplex is up as #1308 (it fails onmainwith "no available_commands_update yet");npm run checkpasses.Opening this Discussion because the new contribution process routes intake here — happy to take the patch forward if it is in scope, or to drop it if you would rather solve command discovery differently.
All reactions