Skip to content

Fix: PHPStan - property $html is never read, only written #31

Description

@mattgoud

Description

PHPStan (level 5, PS 8.x) reports:

```
Property statsbestproducts::$html is never read, only written.
```

The $html property is declared and assigned but its value is never actually read — the module likely builds HTML directly in the return statement instead.

To do

Fix the code and remove the corresponding ignoreErrors line from:

  • tests/php/phpstan/phpstan-8.1.7.neon
  • tests/php/phpstan/phpstan-8.2.x.neon

Added as ignoreErrors in

#30

Metadata

Metadata

Assignees

Labels

Type

No type

Fields

No fields configured for issues without a type.

Projects

Status
Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions