From ff27fc9e2a20d8a8a47b35a6fc2564aaaac652bf Mon Sep 17 00:00:00 2001 From: Kaikina Date: Mon, 2 Feb 2026 16:12:03 +0100 Subject: [PATCH 1/5] fix(AdminController): ob_end_clean without content creates error --- controllers/admin/AdminConfigureSlidesController.php | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/controllers/admin/AdminConfigureSlidesController.php b/controllers/admin/AdminConfigureSlidesController.php index 5abef0f..7e8d69f 100644 --- a/controllers/admin/AdminConfigureSlidesController.php +++ b/controllers/admin/AdminConfigureSlidesController.php @@ -22,7 +22,10 @@ class AdminConfigureSlidesController extends ModuleAdminController public function ajaxProcessUpdateSlidesPosition() { if (empty(Tools::getValue('action')) || Tools::getValue('action') != 'updateSlidesPosition' || empty(Tools::getValue('slides'))) { - ob_end_clean(); + if (ob_get_contents()) { + ob_end_clean(); + } + header('Content-Type: application/json'); $this->ajaxRender(json_encode(['error' => true])); exit; @@ -40,7 +43,10 @@ public function ajaxProcessUpdateSlidesPosition() // Wipe module cache $this->module->clearCache(); - ob_end_clean(); + if (ob_get_contents()) { + ob_end_clean(); + } + header('Content-Type: application/json'); $this->ajaxRender(json_encode(['success' => true])); exit; From ebc4bf868749b648ebd05bec234e1e24623cba42 Mon Sep 17 00:00:00 2001 From: Thomas Roux <156076965+Touxten@users.noreply.github.com> Date: Fri, 20 Feb 2026 09:26:52 +0100 Subject: [PATCH 2/5] Cs Fixer --- controllers/admin/AdminConfigureSlidesController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/controllers/admin/AdminConfigureSlidesController.php b/controllers/admin/AdminConfigureSlidesController.php index 7e8d69f..408cc4f 100644 --- a/controllers/admin/AdminConfigureSlidesController.php +++ b/controllers/admin/AdminConfigureSlidesController.php @@ -22,7 +22,7 @@ class AdminConfigureSlidesController extends ModuleAdminController public function ajaxProcessUpdateSlidesPosition() { if (empty(Tools::getValue('action')) || Tools::getValue('action') != 'updateSlidesPosition' || empty(Tools::getValue('slides'))) { - if (ob_get_contents()) { + if (ob_get_contents()) { ob_end_clean(); } From 9b76b48579f18b19cade570bdb533a18f71aa292 Mon Sep 17 00:00:00 2001 From: Thomas Roux <156076965+Touxten@users.noreply.github.com> Date: Fri, 20 Feb 2026 09:32:27 +0100 Subject: [PATCH 3/5] CSFixer --- controllers/admin/AdminConfigureSlidesController.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/controllers/admin/AdminConfigureSlidesController.php b/controllers/admin/AdminConfigureSlidesController.php index 408cc4f..ed173ab 100644 --- a/controllers/admin/AdminConfigureSlidesController.php +++ b/controllers/admin/AdminConfigureSlidesController.php @@ -24,8 +24,8 @@ public function ajaxProcessUpdateSlidesPosition() if (empty(Tools::getValue('action')) || Tools::getValue('action') != 'updateSlidesPosition' || empty(Tools::getValue('slides'))) { if (ob_get_contents()) { ob_end_clean(); - } - + } + header('Content-Type: application/json'); $this->ajaxRender(json_encode(['error' => true])); exit; @@ -45,8 +45,8 @@ public function ajaxProcessUpdateSlidesPosition() if (ob_get_contents()) { ob_end_clean(); - } - + } + header('Content-Type: application/json'); $this->ajaxRender(json_encode(['success' => true])); exit; From 94a96b0eabb9814624cea20093d28f44f4d47a98 Mon Sep 17 00:00:00 2001 From: Thomas Roux Date: Fri, 20 Feb 2026 09:36:39 +0100 Subject: [PATCH 4/5] CsFixer --- controllers/admin/AdminConfigureSlidesController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/controllers/admin/AdminConfigureSlidesController.php b/controllers/admin/AdminConfigureSlidesController.php index ed173ab..f760875 100644 --- a/controllers/admin/AdminConfigureSlidesController.php +++ b/controllers/admin/AdminConfigureSlidesController.php @@ -44,7 +44,7 @@ public function ajaxProcessUpdateSlidesPosition() $this->module->clearCache(); if (ob_get_contents()) { - ob_end_clean(); + ob_end_clean(); } header('Content-Type: application/json'); From e780cb19c9ec6414bf695e8b04636c534eda684f Mon Sep 17 00:00:00 2001 From: Thomas Roux Date: Fri, 20 Feb 2026 09:41:09 +0100 Subject: [PATCH 5/5] CS Fixer --- controllers/admin/AdminConfigureSlidesController.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/controllers/admin/AdminConfigureSlidesController.php b/controllers/admin/AdminConfigureSlidesController.php index f760875..a2558ae 100644 --- a/controllers/admin/AdminConfigureSlidesController.php +++ b/controllers/admin/AdminConfigureSlidesController.php @@ -23,7 +23,7 @@ public function ajaxProcessUpdateSlidesPosition() { if (empty(Tools::getValue('action')) || Tools::getValue('action') != 'updateSlidesPosition' || empty(Tools::getValue('slides'))) { if (ob_get_contents()) { - ob_end_clean(); + ob_end_clean(); } header('Content-Type: application/json'); @@ -44,7 +44,7 @@ public function ajaxProcessUpdateSlidesPosition() $this->module->clearCache(); if (ob_get_contents()) { - ob_end_clean(); + ob_end_clean(); } header('Content-Type: application/json');