From 907f9f5d84027c6feb52bb02d40d5d2824a1dddf Mon Sep 17 00:00:00 2001 From: Thomas Roux Date: Wed, 18 Feb 2026 07:05:08 +0100 Subject: [PATCH 1/9] Fix CI --- .github/workflows/php.yml | 144 +++++++++++++++++------- tests/{ => php}/phpstan/index.php | 0 tests/php/phpstan/phpstan-8.1.7.neon | 2 + tests/php/phpstan/phpstan-8.2.x.neon | 2 + tests/php/phpstan/phpstan-9.0.x.neon | 2 + tests/php/phpstan/phpstan-develop.neon | 2 + tests/php/phpstan/phpstan.neon | 2 + tests/php/phpstan/prepend-constants.php | 11 ++ tests/phpstan.sh | 28 ----- tests/phpstan/phpstan-1.7.2.5.neon | 10 -- tests/phpstan/phpstan-1.7.3.4.neon | 10 -- tests/phpstan/phpstan-1.7.4.4.neon | 9 -- tests/phpstan/phpstan-1.7.5.1.neon | 9 -- tests/phpstan/phpstan-1.7.6.neon | 9 -- tests/phpstan/phpstan-1.7.7.neon | 7 -- tests/phpstan/phpstan-1.7.8.neon | 7 -- tests/phpstan/phpstan-latest.neon | 7 -- tests/phpstan/phpstan.neon | 11 -- 18 files changed, 123 insertions(+), 149 deletions(-) rename tests/{ => php}/phpstan/index.php (100%) create mode 100644 tests/php/phpstan/phpstan-8.1.7.neon create mode 100644 tests/php/phpstan/phpstan-8.2.x.neon create mode 100644 tests/php/phpstan/phpstan-9.0.x.neon create mode 100644 tests/php/phpstan/phpstan-develop.neon create mode 100644 tests/php/phpstan/phpstan.neon create mode 100644 tests/php/phpstan/prepend-constants.php delete mode 100755 tests/phpstan.sh delete mode 100644 tests/phpstan/phpstan-1.7.2.5.neon delete mode 100644 tests/phpstan/phpstan-1.7.3.4.neon delete mode 100644 tests/phpstan/phpstan-1.7.4.4.neon delete mode 100644 tests/phpstan/phpstan-1.7.5.1.neon delete mode 100644 tests/phpstan/phpstan-1.7.6.neon delete mode 100644 tests/phpstan/phpstan-1.7.7.neon delete mode 100644 tests/phpstan/phpstan-1.7.8.neon delete mode 100644 tests/phpstan/phpstan-latest.neon delete mode 100644 tests/phpstan/phpstan.neon diff --git a/.github/workflows/php.yml b/.github/workflows/php.yml index 8574833..b484807 100644 --- a/.github/workflows/php.yml +++ b/.github/workflows/php.yml @@ -1,76 +1,136 @@ name: PHP tests on: [push, pull_request] jobs: - # Check there is no syntax errors in the project php-linter: - name: PHP Syntax check 5.4 => 8.1 + name: PHP Syntax check runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v5 - - - name: PHP syntax checker 5.4 - uses: prestashop/github-action-php-lint/5.6@master - - - name: PHP syntax checker 5.5 - uses: prestashop/github-action-php-lint/5.6@master - - - name: PHP syntax checker 5.6 - uses: prestashop/github-action-php-lint/5.6@master + uses: actions/checkout@v6 - name: PHP syntax checker 7.2 uses: prestashop/github-action-php-lint/7.2@master - - name: PHP syntax checker 7.3 - uses: prestashop/github-action-php-lint/7.3@master - - name: PHP syntax checker 7.4 uses: prestashop/github-action-php-lint/7.4@master - name: PHP syntax checker 8.0 uses: prestashop/github-action-php-lint/8.0@master - - name: PHP syntax checker 8.1 - uses: prestashop/github-action-php-lint/8.1@master + - name: PHP syntax checker 8.5 + uses: prestashop/github-action-php-lint/8.5@master # Check the PHP code follow the coding standards php-cs-fixer: name: PHP-CS-Fixer runs-on: ubuntu-latest steps: - - name: Setup PHP - uses: shivammathur/setup-php@v2 + - name: Run PHP-CS-Fixer + uses: PrestaShop/.github/.github/actions/php-ci/php-cs@master with: php-version: '7.4' - - name: Checkout - uses: actions/checkout@v5 - - - name: Install dependencies - run: composer install - - - name: Run PHP-CS-Fixer - run: ./vendor/bin/php-cs-fixer fix --dry-run --diff --using-cache=no --diff-format udiff - - # Run PHPStan against the module and a PrestaShop release - phpstan: - name: PHPStan + # Run PHPStan against the module (PHP 7.4 – 8.1) + phpstan-74: + name: PHPStan (PHP 7.4 - 8.1) runs-on: ubuntu-latest strategy: + matrix: + presta_version: ['8.1.7', '8.2.x'] + php_version: ['7.4', '8.1'] fail-fast: false + env: + PHPRC: ${{ github.workspace }}/${{ github.event.repository.name }}/.phpstan-php-ini + steps: + - name: Checkout repository + uses: actions/checkout@v6 + with: + path: ${{ github.event.repository.name }} + + - name: Prepare PHP env for PrestaShop 8 (define constants before any bootstrap) + run: | + mkdir -p ${{ github.event.repository.name }}/.phpstan-php-ini + { + echo "auto_prepend_file=$GITHUB_WORKSPACE/${{ github.event.repository.name }}/tests/php/phpstan/prepend-constants.php" + echo "memory_limit=512M" + } > ${{ github.event.repository.name }}/.phpstan-php-ini/php.ini + + - name: Run PHPStan + uses: PrestaShop/.github/.github/actions/php-ci/phpstan@master + with: + php-version: ${{ matrix.php_version }} + presta-version: ${{ matrix.presta_version }} + module-name: ${{ github.event.repository.name }} + phpstan-level: '5' + phpstan-config: tests/php/phpstan/phpstan-${{ matrix.presta_version }}.neon + phpstan-version: '^0.12' + composer-version: '2.2.18' + + # Run PHPStan against the module (PHP 8.1 – 8.4) + phpstan-80-84: + name: PHPStan (PHP 8.1 - 8.4) + runs-on: ubuntu-latest + strategy: matrix: - presta-versions: ['1.7.2.5', '1.7.3.4', '1.7.4.4', '1.7.5.1', '1.7.6', '1.7.7', '1.7.8', 'latest'] + presta_version: ['9.0.x'] + php_version: ['8.1', '8.4'] + fail-fast: false + env: + PHPRC: ${{ github.workspace }}/${{ github.event.repository.name }}/.phpstan-php-ini steps: - - name: Setup PHP - uses: shivammathur/setup-php@v2 + - name: Checkout repository + uses: actions/checkout@v6 with: - php-version: '7.4' - - - name: Checkout - uses: actions/checkout@v5 + path: ${{ github.event.repository.name }} + + - name: Prepare PHP env for PrestaShop 9.0.x (define constants before any bootstrap) + run: | + mkdir -p ${{ github.event.repository.name }}/.phpstan-php-ini + { + echo "auto_prepend_file=$GITHUB_WORKSPACE/${{ github.event.repository.name }}/tests/php/phpstan/prepend-constants.php" + echo "memory_limit=512M" + } > ${{ github.event.repository.name }}/.phpstan-php-ini/php.ini + + - name: Run PHPStan + uses: PrestaShop/.github/.github/actions/php-ci/phpstan@master + with: + php-version: ${{ matrix.php_version }} + presta-version: ${{ matrix.presta_version }} + module-name: ${{ github.event.repository.name }} + phpstan-level: '5' + phpstan-config: tests/php/phpstan/phpstan-${{ matrix.presta_version }}.neon - - run: composer install + # Run PHPStan against the module (PHP 8.1 – 8.5) + phpstan: + name: PHPStan (PHP 8.1 - 8.5) + runs-on: ubuntu-latest + strategy: + matrix: + presta_version: ['9.1.x', 'develop'] + php_version: ['8.1', '8.5'] + fail-fast: false + env: + PHPRC: ${{ github.workspace }}/${{ github.event.repository.name }}/.phpstan-php-ini + steps: + - name: Checkout repository + uses: actions/checkout@v6 + with: + path: ${{ github.event.repository.name }} + + - name: Prepare PHP env for PrestaShop 9.1.x and later (define constants before any bootstrap) + run: | + mkdir -p ${{ github.event.repository.name }}/.phpstan-php-ini + { + echo "auto_prepend_file=$GITHUB_WORKSPACE/${{ github.event.repository.name }}/tests/php/phpstan/prepend-constants.php" + echo "memory_limit=512M" + } > ${{ github.event.repository.name }}/.phpstan-php-ini/php.ini + + - name: Run PHPStan + uses: PrestaShop/.github/.github/actions/php-ci/phpstan@master + with: + php-version: ${{ matrix.php_version }} + presta-version: ${{ matrix.presta_version }} + module-name: ${{ github.event.repository.name }} + phpstan-level: '5' + phpstan-config: tests/php/phpstan/phpstan-${{ matrix.presta_version }}.neon - # Docker images prestashop/prestashop may be used, even if the shop remains uninstalled - - name: Execute PHPStan on PrestaShop (Tag ${{ matrix.presta-versions }}) - run: ./tests/phpstan.sh ${{ matrix.presta-versions }} diff --git a/tests/phpstan/index.php b/tests/php/phpstan/index.php similarity index 100% rename from tests/phpstan/index.php rename to tests/php/phpstan/index.php diff --git a/tests/php/phpstan/phpstan-8.1.7.neon b/tests/php/phpstan/phpstan-8.1.7.neon new file mode 100644 index 0000000..481ff9f --- /dev/null +++ b/tests/php/phpstan/phpstan-8.1.7.neon @@ -0,0 +1,2 @@ +includes: + - %currentWorkingDirectory%/tests/php/phpstan/phpstan.neon \ No newline at end of file diff --git a/tests/php/phpstan/phpstan-8.2.x.neon b/tests/php/phpstan/phpstan-8.2.x.neon new file mode 100644 index 0000000..efa856c --- /dev/null +++ b/tests/php/phpstan/phpstan-8.2.x.neon @@ -0,0 +1,2 @@ +includes: + - %currentWorkingDirectory%/tests/php/phpstan/phpstan.neon diff --git a/tests/php/phpstan/phpstan-9.0.x.neon b/tests/php/phpstan/phpstan-9.0.x.neon new file mode 100644 index 0000000..481ff9f --- /dev/null +++ b/tests/php/phpstan/phpstan-9.0.x.neon @@ -0,0 +1,2 @@ +includes: + - %currentWorkingDirectory%/tests/php/phpstan/phpstan.neon \ No newline at end of file diff --git a/tests/php/phpstan/phpstan-develop.neon b/tests/php/phpstan/phpstan-develop.neon new file mode 100644 index 0000000..efa856c --- /dev/null +++ b/tests/php/phpstan/phpstan-develop.neon @@ -0,0 +1,2 @@ +includes: + - %currentWorkingDirectory%/tests/php/phpstan/phpstan.neon diff --git a/tests/php/phpstan/phpstan.neon b/tests/php/phpstan/phpstan.neon new file mode 100644 index 0000000..be11823 --- /dev/null +++ b/tests/php/phpstan/phpstan.neon @@ -0,0 +1,2 @@ + # Base PHPStan configuration for the moduleExpand commentComment on line R2ResolvedCode has comments. Press enter to view. + # This file is included by version-specific configs \ No newline at end of file diff --git a/tests/php/phpstan/prepend-constants.php b/tests/php/phpstan/prepend-constants.php new file mode 100644 index 0000000..733689a --- /dev/null +++ b/tests/php/phpstan/prepend-constants.php @@ -0,0 +1,11 @@ + given.#' - - '#Parameter \#1 \$hook_name of method ModuleCore\:\:registerHook\(\) expects string, array given.#' diff --git a/tests/phpstan/phpstan-1.7.3.4.neon b/tests/phpstan/phpstan-1.7.3.4.neon deleted file mode 100644 index f4b4198..0000000 --- a/tests/phpstan/phpstan-1.7.3.4.neon +++ /dev/null @@ -1,10 +0,0 @@ -includes: - - %currentWorkingDirectory%/tests/phpstan/phpstan.neon - -parameters: - ignoreErrors: - - '#Access to an undefined property Cookie\:\:\$contactFormToken.#' - - '#Access to an undefined property Cookie\:\:\$contactFormTokenTTL.#' - - '#Call to method assign\(\) on an unknown class Smarty_Data.#' - - '#Parameter \#4 \$templateVars of static method MailCore\:\:send\(\) expects string, array given.#' - - '#Parameter \#1 \$hook_name of method ModuleCore\:\:registerHook\(\) expects string, array given.#' diff --git a/tests/phpstan/phpstan-1.7.4.4.neon b/tests/phpstan/phpstan-1.7.4.4.neon deleted file mode 100644 index 4bb3d01..0000000 --- a/tests/phpstan/phpstan-1.7.4.4.neon +++ /dev/null @@ -1,9 +0,0 @@ -includes: - - %currentWorkingDirectory%/tests/phpstan/phpstan.neon - -parameters: - ignoreErrors: - - '#Access to an undefined property Cookie\:\:\$contactFormToken.#' - - '#Access to an undefined property Cookie\:\:\$contactFormTokenTTL.#' - - '#Parameter \#4 \$templateVars of static method MailCore\:\:send\(\) expects string, array given.#' - - '#Parameter \#1 \$hook_name of method ModuleCore\:\:registerHook\(\) expects string, array given.#' diff --git a/tests/phpstan/phpstan-1.7.5.1.neon b/tests/phpstan/phpstan-1.7.5.1.neon deleted file mode 100644 index 4bb3d01..0000000 --- a/tests/phpstan/phpstan-1.7.5.1.neon +++ /dev/null @@ -1,9 +0,0 @@ -includes: - - %currentWorkingDirectory%/tests/phpstan/phpstan.neon - -parameters: - ignoreErrors: - - '#Access to an undefined property Cookie\:\:\$contactFormToken.#' - - '#Access to an undefined property Cookie\:\:\$contactFormTokenTTL.#' - - '#Parameter \#4 \$templateVars of static method MailCore\:\:send\(\) expects string, array given.#' - - '#Parameter \#1 \$hook_name of method ModuleCore\:\:registerHook\(\) expects string, array given.#' diff --git a/tests/phpstan/phpstan-1.7.6.neon b/tests/phpstan/phpstan-1.7.6.neon deleted file mode 100644 index 4bb3d01..0000000 --- a/tests/phpstan/phpstan-1.7.6.neon +++ /dev/null @@ -1,9 +0,0 @@ -includes: - - %currentWorkingDirectory%/tests/phpstan/phpstan.neon - -parameters: - ignoreErrors: - - '#Access to an undefined property Cookie\:\:\$contactFormToken.#' - - '#Access to an undefined property Cookie\:\:\$contactFormTokenTTL.#' - - '#Parameter \#4 \$templateVars of static method MailCore\:\:send\(\) expects string, array given.#' - - '#Parameter \#1 \$hook_name of method ModuleCore\:\:registerHook\(\) expects string, array given.#' diff --git a/tests/phpstan/phpstan-1.7.7.neon b/tests/phpstan/phpstan-1.7.7.neon deleted file mode 100644 index 8b75660..0000000 --- a/tests/phpstan/phpstan-1.7.7.neon +++ /dev/null @@ -1,7 +0,0 @@ -includes: - - %currentWorkingDirectory%/tests/phpstan/phpstan.neon - -parameters: - ignoreErrors: - - '#Access to an undefined property Cookie\:\:\$contactFormToken.#' - - '#Access to an undefined property Cookie\:\:\$contactFormTokenTTL.#' diff --git a/tests/phpstan/phpstan-1.7.8.neon b/tests/phpstan/phpstan-1.7.8.neon deleted file mode 100644 index 8b75660..0000000 --- a/tests/phpstan/phpstan-1.7.8.neon +++ /dev/null @@ -1,7 +0,0 @@ -includes: - - %currentWorkingDirectory%/tests/phpstan/phpstan.neon - -parameters: - ignoreErrors: - - '#Access to an undefined property Cookie\:\:\$contactFormToken.#' - - '#Access to an undefined property Cookie\:\:\$contactFormTokenTTL.#' diff --git a/tests/phpstan/phpstan-latest.neon b/tests/phpstan/phpstan-latest.neon deleted file mode 100644 index 8b75660..0000000 --- a/tests/phpstan/phpstan-latest.neon +++ /dev/null @@ -1,7 +0,0 @@ -includes: - - %currentWorkingDirectory%/tests/phpstan/phpstan.neon - -parameters: - ignoreErrors: - - '#Access to an undefined property Cookie\:\:\$contactFormToken.#' - - '#Access to an undefined property Cookie\:\:\$contactFormTokenTTL.#' diff --git a/tests/phpstan/phpstan.neon b/tests/phpstan/phpstan.neon deleted file mode 100644 index 0c6cd2a..0000000 --- a/tests/phpstan/phpstan.neon +++ /dev/null @@ -1,11 +0,0 @@ -includes: - - %currentWorkingDirectory%/vendor/prestashop/php-dev-tools/phpstan/ps-module-extension.neon - -parameters: - paths: - # From PHPStan 0.12, paths to check are relative to the neon file - - ../../contactform.php - - ../../upgrade/ - ignoreErrors: - reportUnmatchedIgnoredErrors: false - level: 5 From 7078f44d2c95535d1608e39f258908e22367a9ee Mon Sep 17 00:00:00 2001 From: Thomas Roux Date: Wed, 18 Feb 2026 07:06:30 +0100 Subject: [PATCH 2/9] compilance --- contactform.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contactform.php b/contactform.php index 739975a..89406a8 100644 --- a/contactform.php +++ b/contactform.php @@ -66,7 +66,7 @@ public function __construct() 'Modules.Contactform.Admin' ); $this->ps_versions_compliancy = [ - 'min' => '1.7.2.0', + 'min' => '8.0.0', 'max' => _PS_VERSION_, ]; } From 7096b29b574300028f80ea7b26c2113dbec915aa Mon Sep 17 00:00:00 2001 From: Thomas Roux Date: Wed, 18 Feb 2026 07:22:50 +0100 Subject: [PATCH 3/9] Update Readme --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index d101197..6530613 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ Help your customers get in touch when they need, add a contact form on your stor ## Compatibility -PrestaShop: `1.7.2.0` or later +PrestaShop: `8.0.0` or later ## How to test From d919d303e15d044d463aa5be9acc59af87c88ee0 Mon Sep 17 00:00:00 2001 From: Thomas Roux Date: Wed, 18 Feb 2026 07:34:51 +0100 Subject: [PATCH 4/9] Add missing --- tests/php/phpstan/phpstan-9.1.x.neon | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 tests/php/phpstan/phpstan-9.1.x.neon diff --git a/tests/php/phpstan/phpstan-9.1.x.neon b/tests/php/phpstan/phpstan-9.1.x.neon new file mode 100644 index 0000000..efa856c --- /dev/null +++ b/tests/php/phpstan/phpstan-9.1.x.neon @@ -0,0 +1,2 @@ +includes: + - %currentWorkingDirectory%/tests/php/phpstan/phpstan.neon From 71d795cdbb9ce9ba5da2fc5ea2f799a9b3a32ddc Mon Sep 17 00:00:00 2001 From: Thomas Roux Date: Fri, 20 Feb 2026 08:49:21 +0100 Subject: [PATCH 5/9] Update repo for test --- .github/workflows/php.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/php.yml b/.github/workflows/php.yml index b484807..148577d 100644 --- a/.github/workflows/php.yml +++ b/.github/workflows/php.yml @@ -56,7 +56,7 @@ jobs: } > ${{ github.event.repository.name }}/.phpstan-php-ini/php.ini - name: Run PHPStan - uses: PrestaShop/.github/.github/actions/php-ci/phpstan@master + uses: Touxten/.github/.github/actions/php-ci/phpstan@master with: php-version: ${{ matrix.php_version }} presta-version: ${{ matrix.presta_version }} @@ -92,7 +92,7 @@ jobs: } > ${{ github.event.repository.name }}/.phpstan-php-ini/php.ini - name: Run PHPStan - uses: PrestaShop/.github/.github/actions/php-ci/phpstan@master + uses: Touxten/.github/.github/actions/php-ci/phpstan@master with: php-version: ${{ matrix.php_version }} presta-version: ${{ matrix.presta_version }} @@ -126,7 +126,7 @@ jobs: } > ${{ github.event.repository.name }}/.phpstan-php-ini/php.ini - name: Run PHPStan - uses: PrestaShop/.github/.github/actions/php-ci/phpstan@master + uses: Touxten/.github/.github/actions/php-ci/phpstan@master with: php-version: ${{ matrix.php_version }} presta-version: ${{ matrix.presta_version }} From 71dbb40368537bef5e8c2e932e5442c4d07c2774 Mon Sep 17 00:00:00 2001 From: Thomas Roux Date: Fri, 20 Feb 2026 08:53:46 +0100 Subject: [PATCH 6/9] Test --- tests/php/phpstan/phpstan-8.1.7.neon | 7 ++++++- tests/php/phpstan/phpstan-8.2.x.neon | 5 +++++ tests/php/phpstan/phpstan-9.0.x.neon | 7 ++++++- tests/php/phpstan/phpstan-9.1.x.neon | 5 +++++ tests/php/phpstan/phpstan-develop.neon | 5 +++++ 5 files changed, 27 insertions(+), 2 deletions(-) diff --git a/tests/php/phpstan/phpstan-8.1.7.neon b/tests/php/phpstan/phpstan-8.1.7.neon index 481ff9f..d185545 100644 --- a/tests/php/phpstan/phpstan-8.1.7.neon +++ b/tests/php/phpstan/phpstan-8.1.7.neon @@ -1,2 +1,7 @@ includes: - - %currentWorkingDirectory%/tests/php/phpstan/phpstan.neon \ No newline at end of file + - %currentWorkingDirectory%/tests/php/phpstan/phpstan.neon + +parameters: + ignoreErrors: + - '#Access to an undefined property Cookie\:\:\$contactFormToken.#' + - '#Access to an undefined property Cookie\:\:\$contactFormTokenTTL.#' \ No newline at end of file diff --git a/tests/php/phpstan/phpstan-8.2.x.neon b/tests/php/phpstan/phpstan-8.2.x.neon index efa856c..6294a6d 100644 --- a/tests/php/phpstan/phpstan-8.2.x.neon +++ b/tests/php/phpstan/phpstan-8.2.x.neon @@ -1,2 +1,7 @@ includes: - %currentWorkingDirectory%/tests/php/phpstan/phpstan.neon + +parameters: + ignoreErrors: + - '#Access to an undefined property Cookie\:\:\$contactFormToken.#' + - '#Access to an undefined property Cookie\:\:\$contactFormTokenTTL.#' diff --git a/tests/php/phpstan/phpstan-9.0.x.neon b/tests/php/phpstan/phpstan-9.0.x.neon index 481ff9f..d185545 100644 --- a/tests/php/phpstan/phpstan-9.0.x.neon +++ b/tests/php/phpstan/phpstan-9.0.x.neon @@ -1,2 +1,7 @@ includes: - - %currentWorkingDirectory%/tests/php/phpstan/phpstan.neon \ No newline at end of file + - %currentWorkingDirectory%/tests/php/phpstan/phpstan.neon + +parameters: + ignoreErrors: + - '#Access to an undefined property Cookie\:\:\$contactFormToken.#' + - '#Access to an undefined property Cookie\:\:\$contactFormTokenTTL.#' \ No newline at end of file diff --git a/tests/php/phpstan/phpstan-9.1.x.neon b/tests/php/phpstan/phpstan-9.1.x.neon index efa856c..6294a6d 100644 --- a/tests/php/phpstan/phpstan-9.1.x.neon +++ b/tests/php/phpstan/phpstan-9.1.x.neon @@ -1,2 +1,7 @@ includes: - %currentWorkingDirectory%/tests/php/phpstan/phpstan.neon + +parameters: + ignoreErrors: + - '#Access to an undefined property Cookie\:\:\$contactFormToken.#' + - '#Access to an undefined property Cookie\:\:\$contactFormTokenTTL.#' diff --git a/tests/php/phpstan/phpstan-develop.neon b/tests/php/phpstan/phpstan-develop.neon index efa856c..d185545 100644 --- a/tests/php/phpstan/phpstan-develop.neon +++ b/tests/php/phpstan/phpstan-develop.neon @@ -1,2 +1,7 @@ includes: - %currentWorkingDirectory%/tests/php/phpstan/phpstan.neon + +parameters: + ignoreErrors: + - '#Access to an undefined property Cookie\:\:\$contactFormToken.#' + - '#Access to an undefined property Cookie\:\:\$contactFormTokenTTL.#' \ No newline at end of file From ce6e3e45dc2439e040cf0b027d76eea1e53c7146 Mon Sep 17 00:00:00 2001 From: Thomas Roux Date: Fri, 20 Feb 2026 08:57:22 +0100 Subject: [PATCH 7/9] catch eror --- tests/php/phpstan/phpstan-8.1.7.neon | 3 +-- tests/php/phpstan/phpstan-8.2.x.neon | 1 - tests/php/phpstan/phpstan-9.0.x.neon | 2 +- tests/php/phpstan/phpstan-9.1.x.neon | 2 +- tests/php/phpstan/phpstan-develop.neon | 2 +- 5 files changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/php/phpstan/phpstan-8.1.7.neon b/tests/php/phpstan/phpstan-8.1.7.neon index d185545..0d3f527 100644 --- a/tests/php/phpstan/phpstan-8.1.7.neon +++ b/tests/php/phpstan/phpstan-8.1.7.neon @@ -3,5 +3,4 @@ includes: parameters: ignoreErrors: - - '#Access to an undefined property Cookie\:\:\$contactFormToken.#' - - '#Access to an undefined property Cookie\:\:\$contactFormTokenTTL.#' \ No newline at end of file + - '#Access to an undefined property Cookie\:\:\$contactFormToken.#' \ No newline at end of file diff --git a/tests/php/phpstan/phpstan-8.2.x.neon b/tests/php/phpstan/phpstan-8.2.x.neon index 6294a6d..b0db9cf 100644 --- a/tests/php/phpstan/phpstan-8.2.x.neon +++ b/tests/php/phpstan/phpstan-8.2.x.neon @@ -4,4 +4,3 @@ includes: parameters: ignoreErrors: - '#Access to an undefined property Cookie\:\:\$contactFormToken.#' - - '#Access to an undefined property Cookie\:\:\$contactFormTokenTTL.#' diff --git a/tests/php/phpstan/phpstan-9.0.x.neon b/tests/php/phpstan/phpstan-9.0.x.neon index d185545..a72bdeb 100644 --- a/tests/php/phpstan/phpstan-9.0.x.neon +++ b/tests/php/phpstan/phpstan-9.0.x.neon @@ -4,4 +4,4 @@ includes: parameters: ignoreErrors: - '#Access to an undefined property Cookie\:\:\$contactFormToken.#' - - '#Access to an undefined property Cookie\:\:\$contactFormTokenTTL.#' \ No newline at end of file + - '#Call to an undefined static method Tools\:\:stripslashes\(\).#' \ No newline at end of file diff --git a/tests/php/phpstan/phpstan-9.1.x.neon b/tests/php/phpstan/phpstan-9.1.x.neon index 6294a6d..a97b152 100644 --- a/tests/php/phpstan/phpstan-9.1.x.neon +++ b/tests/php/phpstan/phpstan-9.1.x.neon @@ -4,4 +4,4 @@ includes: parameters: ignoreErrors: - '#Access to an undefined property Cookie\:\:\$contactFormToken.#' - - '#Access to an undefined property Cookie\:\:\$contactFormTokenTTL.#' + - '#Call to an undefined static method Tools\:\:stripslashes\(\).#' diff --git a/tests/php/phpstan/phpstan-develop.neon b/tests/php/phpstan/phpstan-develop.neon index d185545..a72bdeb 100644 --- a/tests/php/phpstan/phpstan-develop.neon +++ b/tests/php/phpstan/phpstan-develop.neon @@ -4,4 +4,4 @@ includes: parameters: ignoreErrors: - '#Access to an undefined property Cookie\:\:\$contactFormToken.#' - - '#Access to an undefined property Cookie\:\:\$contactFormTokenTTL.#' \ No newline at end of file + - '#Call to an undefined static method Tools\:\:stripslashes\(\).#' \ No newline at end of file From abd30856b09c91d8b5872f5902c3541956eef779 Mon Sep 17 00:00:00 2001 From: Thomas Roux Date: Sat, 21 Feb 2026 10:30:14 +0100 Subject: [PATCH 8/9] Restore PrestaShop Repo --- .github/workflows/php.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/php.yml b/.github/workflows/php.yml index 148577d..b484807 100644 --- a/.github/workflows/php.yml +++ b/.github/workflows/php.yml @@ -56,7 +56,7 @@ jobs: } > ${{ github.event.repository.name }}/.phpstan-php-ini/php.ini - name: Run PHPStan - uses: Touxten/.github/.github/actions/php-ci/phpstan@master + uses: PrestaShop/.github/.github/actions/php-ci/phpstan@master with: php-version: ${{ matrix.php_version }} presta-version: ${{ matrix.presta_version }} @@ -92,7 +92,7 @@ jobs: } > ${{ github.event.repository.name }}/.phpstan-php-ini/php.ini - name: Run PHPStan - uses: Touxten/.github/.github/actions/php-ci/phpstan@master + uses: PrestaShop/.github/.github/actions/php-ci/phpstan@master with: php-version: ${{ matrix.php_version }} presta-version: ${{ matrix.presta_version }} @@ -126,7 +126,7 @@ jobs: } > ${{ github.event.repository.name }}/.phpstan-php-ini/php.ini - name: Run PHPStan - uses: Touxten/.github/.github/actions/php-ci/phpstan@master + uses: PrestaShop/.github/.github/actions/php-ci/phpstan@master with: php-version: ${{ matrix.php_version }} presta-version: ${{ matrix.presta_version }} From e59bc598514b054b3bd5a18d228cdfed47938531 Mon Sep 17 00:00:00 2001 From: Thomas Roux Date: Sun, 22 Feb 2026 10:44:24 +0100 Subject: [PATCH 9/9] Compilance --- README.md | 2 +- contactform.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 6530613..02f8e0b 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ Help your customers get in touch when they need, add a contact form on your stor ## Compatibility -PrestaShop: `8.0.0` or later +PrestaShop: `8.1.0` or later ## How to test diff --git a/contactform.php b/contactform.php index 89406a8..6f0e969 100644 --- a/contactform.php +++ b/contactform.php @@ -66,7 +66,7 @@ public function __construct() 'Modules.Contactform.Admin' ); $this->ps_versions_compliancy = [ - 'min' => '8.0.0', + 'min' => '8.1.0', 'max' => _PS_VERSION_, ]; }