allow offline builds using system kanzi

[carlwgeorge]

Is your feature request related to a problem? Please describe.

Up through commit 3b8addd this software could be built in an environment without internet access. Since #70/#72, the kanzi library is downloaded during the build, which fails in such environments.

Describe the solution you'd like

Please add a cmake option that allows to either downloading kanzi or using a system copy of the library.

Describe existing solutions that have this feature

The first one that comes to mind is mumble. It doesn't download libraries during the build, but it does have bundled copies of a few things, with corresponding cmake flags to disable their usage. For example, passing the flag -Dbundled-json=OFF will ignore the bundled json library and attempt to find it on the system instead.

Additional context

I'm packaging drawy for Fedora. Like most distros, the official build system does not allow outbound internet access. If implemented this will drawy stay up to date in Fedora, help other distro package drawy, and overall increase the availability of the application.

[quarterstar]

Sup. We've been working on a fix for it in tandem with #77 that uses conditional compilation, but the CI still fails. For reference, a similar issue has been recorded to occur for Windows builds thus far.

This is more of a build infrastructure decision, so I will leave it up to @Prayag2 to decide how he wants us to fetch the library.

By the way, the master branch has some experimental features that aren't meant to be packaged yet. If you are packaging for Fedora, you should use the official 1.0 build source that is provided in GitHub Releases.

[Prayag2]

We no longer need to do this as we’ve moved to libzstd, which is far easier to package and supports offline builds. Please note that this repository is maintained solely to monitor existing issues. Active development is now taking place on KDE Invent: https://invent.kde.org/prayag/drawy.

[carlwgeorge]

By the way, the master branch has some experimental features that aren't meant to be packaged yet. If you are packaging for Fedora, you should use the official 1.0 build source that is provided in GitHub Releases.

I started with the 1.0.0-alpha tag, but later commits introduced highly desirable changes for packaging so I've updated to a newer snapshot. I'll keep periodically updating to newer snapshots until the actual 1.0.0 (non-alpha) release happens.

We no longer need to do this as we’ve moved to libzstd, which is far easier to package and supports offline builds.

Sounds good to me. libzstd is of course already widely packaged while kanzi is not.

Please note that this repository is maintained solely to monitor existing issues. Active development is now taking place on KDE Invent: https://invent.kde.org/prayag/drawy.

Thanks for the heads up, I'll switch the package to use that new upstream.