Skip to content

Surgical YAML patches: github-pr.yaml, close-out.yaml, plan-level.yaml + twig sync audit #529

Description

@PolyphonyRequiem

Context

Three surgical YAML fixes surfaced during the 2026-05-28 squad fan-out, plus a twig sync audit. Each is self-contained; combined effort is less than a day.

  1. github-pr.yaml missing output branchado-pr.yaml:139-148 emits merged + pr_url outputs on the already_merged_emitter branch; github-pr.yaml lacks the equivalent, meaning callers get silent nulls when a PR is already merged. Pattern mirror needed at lines 100-107 and 437.

  2. close-out.yaml:43| json footgun| json is not a standard Jinja2 filter; it should be | tojson. The current behavior silently produces incorrect output or template error depending on conductor version.

  3. plan-level.yaml:163-183 vs root-item-dispatch.yaml:157-161 scope-violation bubble-upvalidate_scope_verdict and scope_violation_files are partially bubbled up but the wiring is incomplete relative to the root-item-dispatch consumption side. Complete the bubble-up.

  4. Twig sync audit — Audit all twig state callers in .conductor/registry/workflows/ for missing post-state twig sync. Twig state transitions may require a sync call to propagate ADO state to polyphony's local model. File follow-up issues for any callers found missing the sync.

Parent epic: #522 (Squad short-term wins, 2026-05-28 fan-out)


Acceptance criteria

  • github-pr.yaml: already_merged_emitter output branch added (mirroring ado-pr.yaml:139-148), emitting merged + pr_url at lines 100-107 and 437
  • close-out.yaml:43: | json replaced with | tojson
  • plan-level.yaml:163-183: validate_scope_verdict + scope_violation_files bubble-up complete and consistent with root-item-dispatch.yaml:157-161 consumption
  • Twig sync audit completed; any callers missing post-state sync have follow-up issues filed

Owner

  • Primary: Sibelius (twig sync audit — owns twig/ADO seam)
  • Secondary: Wagner (YAML patches — owns workflow YAML authoring)

Estimated effort

2–4 hours (surgical patches + audit)


File anchors

  • .conductor/registry/workflows/github-pr.yaml (lines 100-107, 437)
  • .conductor/registry/workflows/ado-pr.yaml (lines 139-148, mirror pattern)
  • .conductor/registry/workflows/close-out.yaml (line 43)
  • .conductor/registry/workflows/plan-level.yaml (lines 163-183)
  • .conductor/registry/workflows/root-item-dispatch.yaml (lines 157-161)

In-situ clause

Apply DU patterns and hygiene fixes opportunistically where natural in your scope. Don't make these the primary focus.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions