From 4e35cd7cb0dab81cc0bf5804988b9988eec6a05d Mon Sep 17 00:00:00 2001 From: prasanth_j Date: Sun, 15 Mar 2026 12:21:10 +0530 Subject: [PATCH 1/8] Fix unused props in BrowserView --- maxc_desktop/src/components/BrowserView.tsx | 4 ---- 1 file changed, 4 deletions(-) diff --git a/maxc_desktop/src/components/BrowserView.tsx b/maxc_desktop/src/components/BrowserView.tsx index 798f450..85dd148 100644 --- a/maxc_desktop/src/components/BrowserView.tsx +++ b/maxc_desktop/src/components/BrowserView.tsx @@ -1,7 +1,6 @@ import { useEffect, useRef, useState } from "react"; import { ArrowLeft, ArrowRight, Globe2, RotateCw } from "lucide-react"; import { Shimmer } from "@/components/ai-elements/shimmer"; -import { cn } from "@/lib/utils"; export type BrowserViewProps = { surfaceId: string; @@ -26,10 +25,7 @@ export function BrowserView({ onReload, onBack, onForward, - onScreenshot, currentUrl, - screenshotData, - screenshotLoading, sessionLoading, }: BrowserViewProps) { const [urlInput, setUrlInput] = useState(currentUrl); From 8c0de110849679efe99fbf6563336ba55e9b8a29 Mon Sep 17 00:00:00 2001 From: prasanth_j Date: Sun, 15 Mar 2026 12:22:42 +0530 Subject: [PATCH 2/8] Add GTK dev libs for backend CI --- .github/workflows/backend.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/backend.yml b/.github/workflows/backend.yml index 543f1ce..f9e83c7 100644 --- a/.github/workflows/backend.yml +++ b/.github/workflows/backend.yml @@ -15,7 +15,7 @@ jobs: - name: Install Linux system deps run: | sudo apt-get update - sudo apt-get install -y pkg-config libglib2.0-dev + sudo apt-get install -y pkg-config libglib2.0-dev libgtk-3-dev - name: Install Rust uses: dtolnay/rust-toolchain@stable From cc3af2bfa5aa6c4b1c412d52df1072e3b41e274a Mon Sep 17 00:00:00 2001 From: prasanth_j Date: Sun, 15 Mar 2026 12:25:01 +0530 Subject: [PATCH 3/8] Add WebKitGTK deps for backend CI --- .github/workflows/backend.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/backend.yml b/.github/workflows/backend.yml index f9e83c7..753e49d 100644 --- a/.github/workflows/backend.yml +++ b/.github/workflows/backend.yml @@ -15,7 +15,12 @@ jobs: - name: Install Linux system deps run: | sudo apt-get update - sudo apt-get install -y pkg-config libglib2.0-dev libgtk-3-dev + sudo apt-get install -y \ + pkg-config \ + libglib2.0-dev \ + libgtk-3-dev \ + libjavascriptcoregtk-4.1-dev \ + libsoup-3.0-dev - name: Install Rust uses: dtolnay/rust-toolchain@stable From a8f00f354cbfdad23c4b3e637cfb331cf9ca5f1c Mon Sep 17 00:00:00 2001 From: prasanth_j Date: Sun, 15 Mar 2026 12:27:11 +0530 Subject: [PATCH 4/8] Add WebKit2GTK dev libs for CI --- .github/workflows/backend.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/backend.yml b/.github/workflows/backend.yml index 753e49d..b60eaef 100644 --- a/.github/workflows/backend.yml +++ b/.github/workflows/backend.yml @@ -20,7 +20,8 @@ jobs: libglib2.0-dev \ libgtk-3-dev \ libjavascriptcoregtk-4.1-dev \ - libsoup-3.0-dev + libsoup-3.0-dev \ + libwebkit2gtk-4.1-dev || sudo apt-get install -y libwebkit2gtk-4.0-dev - name: Install Rust uses: dtolnay/rust-toolchain@stable From 983a2fc6f23b85f5694f183841ac3e4d98e36f64 Mon Sep 17 00:00:00 2001 From: prasanth_j Date: Sun, 15 Mar 2026 12:30:01 +0530 Subject: [PATCH 5/8] Fix clippy len_zero warnings --- backend/cli/src/main.rs | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/backend/cli/src/main.rs b/backend/cli/src/main.rs index 744f25e..f6beb74 100644 --- a/backend/cli/src/main.rs +++ b/backend/cli/src/main.rs @@ -3361,11 +3361,10 @@ mod tests { .await .expect("workspace list"); assert!( - ws_list["result"]["workspaces"] + !ws_list["result"]["workspaces"] .as_array() .expect("array") - .len() - >= 1 + .is_empty() ); // workspace update @@ -3414,11 +3413,10 @@ mod tests { .await .expect("pane list"); assert!( - pane_list["result"]["panes"] + !pane_list["result"]["panes"] .as_array() .expect("panes array") - .len() - >= 1 + .is_empty() ); let split = transport @@ -3466,11 +3464,10 @@ mod tests { .await .expect("surface list"); assert!( - surface_list["result"]["surfaces"] + !surface_list["result"]["surfaces"] .as_array() .expect("surfaces array") - .len() - >= 1 + .is_empty() ); let focused = transport From 85c77967baf60c31e097f41658de22f0dc765e43 Mon Sep 17 00:00:00 2001 From: prasanth_j Date: Sun, 15 Mar 2026 12:32:17 +0530 Subject: [PATCH 6/8] Adjust clippy assertions formatting --- backend/cli/src/main.rs | 30 ++++++++++++------------------ 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/backend/cli/src/main.rs b/backend/cli/src/main.rs index f6beb74..b28c54b 100644 --- a/backend/cli/src/main.rs +++ b/backend/cli/src/main.rs @@ -3360,12 +3360,10 @@ mod tests { })) .await .expect("workspace list"); - assert!( - !ws_list["result"]["workspaces"] - .as_array() - .expect("array") - .is_empty() - ); + let workspaces = ws_list["result"]["workspaces"] + .as_array() + .expect("array"); + assert!(!workspaces.is_empty()); // workspace update let ws_id = ws_created["result"]["workspace_id"] @@ -3412,12 +3410,10 @@ mod tests { })) .await .expect("pane list"); - assert!( - !pane_list["result"]["panes"] - .as_array() - .expect("panes array") - .is_empty() - ); + let panes = pane_list["result"]["panes"] + .as_array() + .expect("panes array"); + assert!(!panes.is_empty()); let split = transport .send(build_request(Command::PaneSplit { @@ -3463,12 +3459,10 @@ mod tests { })) .await .expect("surface list"); - assert!( - !surface_list["result"]["surfaces"] - .as_array() - .expect("surfaces array") - .is_empty() - ); + let surfaces = surface_list["result"]["surfaces"] + .as_array() + .expect("surfaces array"); + assert!(!surfaces.is_empty()); let focused = transport .send(build_request(Command::SurfaceFocus { From 3ebc2468b026ab6789d43e37c23ec31de291215f Mon Sep 17 00:00:00 2001 From: prasanth_j Date: Sun, 15 Mar 2026 12:34:27 +0530 Subject: [PATCH 7/8] Format CLI tests --- backend/cli/src/main.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/backend/cli/src/main.rs b/backend/cli/src/main.rs index b28c54b..abf749c 100644 --- a/backend/cli/src/main.rs +++ b/backend/cli/src/main.rs @@ -3360,9 +3360,7 @@ mod tests { })) .await .expect("workspace list"); - let workspaces = ws_list["result"]["workspaces"] - .as_array() - .expect("array"); + let workspaces = ws_list["result"]["workspaces"].as_array().expect("array"); assert!(!workspaces.is_empty()); // workspace update From fd8a9e064f6b8fde16669aaaeebca661ca4dc581 Mon Sep 17 00:00:00 2001 From: prasanth_j Date: Sun, 15 Mar 2026 12:37:30 +0530 Subject: [PATCH 8/8] Fix bool assert in storage tests --- backend/storage/src/lib.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/storage/src/lib.rs b/backend/storage/src/lib.rs index 32545e7..823e685 100644 --- a/backend/storage/src/lib.rs +++ b/backend/storage/src/lib.rs @@ -1488,7 +1488,7 @@ mod tests { .notifications .get("notif-1") .expect("notification"); - assert_eq!(notification.read, true); + assert!(notification.read); assert!(recovered.command_results.contains_key("cmd-notify-2")); let _ = fs::remove_dir_all(dir); }