From 12fc2aa7037a432896722537c885a9e3d10dbcd3 Mon Sep 17 00:00:00 2001
From: Bartosz Groffik <43883736+Bartman119@users.noreply.github.com>
Date: Mon, 7 Jul 2025 12:09:47 +0000
Subject: [PATCH] Fix negative position setting for edited questionnaire and
 remove position updating for other questionnaires

---
 classes/questions_form.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/classes/questions_form.php b/classes/questions_form.php
index 0bb2b4697..cc213ca1c 100644
--- a/classes/questions_form.php
+++ b/classes/questions_form.php
@@ -139,7 +139,7 @@ public function definition() {
             // No page break in first position!
             if ($tid == QUESPAGEBREAK && $pos == 1) {
                 $DB->set_field('questionnaire_question', 'deleted', 'y', ['id' => $qid, 'surveyid' => $sid]);
-                if ($records = $DB->get_records_select('questionnaire_question', $select, null, 'position ASC')) {
+                if ($records = $DB->get_records_select('questionnaire_question', 'surveyid = ' . $sid, null, 'position ASC')) {
                     foreach ($records as $record) {
                         $DB->set_field('questionnaire_question', 'position', $record->position - 1, array('id' => $record->id));
                     }