From cbb852752993f7329d1c29cc90a6bcea1b5eb64b Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Fri, 6 Nov 2026 12:19:26 +0000 Subject: [PATCH 1/2] chore(deps): update version.pmd to v7.29.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 4925beac..69973fbd 100644 --- a/pom.xml +++ b/pom.xml @@ -48,7 +48,7 @@ 0.14.3 1.6.5-SNAPSHOT ${lightkeeper.minecraft-version}-R0.2-SNAPSHOT - 7.23.0 + 7.29.0 6.0.0 3.6.0 From 1f005aefdde9591e2f91bdad143c09cce79c2494 Mon Sep 17 00:00:00 2001 From: Pim van der Loos Date: Fri, 6 Nov 2026 13:48:49 +0100 Subject: [PATCH 2/2] Fix PMD violation --- .../maven/serverprovider/ServerProvider.java | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/lightkeeper-maven-plugin/src/main/java/nl/pim16aap2/lightkeeper/maven/serverprovider/ServerProvider.java b/lightkeeper-maven-plugin/src/main/java/nl/pim16aap2/lightkeeper/maven/serverprovider/ServerProvider.java index 928f0009..153f2eaf 100644 --- a/lightkeeper-maven-plugin/src/main/java/nl/pim16aap2/lightkeeper/maven/serverprovider/ServerProvider.java +++ b/lightkeeper-maven-plugin/src/main/java/nl/pim16aap2/lightkeeper/maven/serverprovider/ServerProvider.java @@ -227,6 +227,7 @@ protected void writeServerProperties(String properties) * Creates the default server properties content for an offline-mode integration server. * * @return The server properties content. + * * @throws MojoExecutionException * If no free local TCP port can be reserved. */ @@ -306,10 +307,9 @@ protected void configureSpigotWatchdogTimeout() lines.add(settingsLineIndex + 1, settingsLineIndentation + " timeout-time: " + SPIGOT_WATCHDOG_TIMEOUT_SECONDS); } - else + else if (!lines.isEmpty() && !lines.getLast().isBlank()) { - if (!lines.isEmpty() && !lines.get(lines.size() - 1).isBlank()) - lines.add(""); + lines.add(""); lines.add("settings:"); lines.add(" timeout-time: " + SPIGOT_WATCHDOG_TIMEOUT_SECONDS); } @@ -338,6 +338,7 @@ protected void configureSpigotWatchdogTimeout() * Reserves an available local TCP port. * * @return A currently available local TCP port. + * * @throws MojoExecutionException * If no local TCP port could be reserved. */ @@ -415,8 +416,10 @@ public final void prepareServer() /** * Creates the same provider with durable runtime output locations while retaining all resolved server inputs. * - * @param serverWorkDirectoryRoot Root directory for the prepared runtime. - * @param runtimeManifestPath Runtime manifest destination. + * @param serverWorkDirectoryRoot + * Root directory for the prepared runtime. + * @param runtimeManifestPath + * Runtime manifest destination. * @return A provider using the supplied runtime output locations. */ public final ServerProvider withRuntimeLocations(Path serverWorkDirectoryRoot, Path runtimeManifestPath) @@ -427,7 +430,8 @@ public final ServerProvider withRuntimeLocations(Path serverWorkDirectoryRoot, P /** * Recreates this resolved provider with a copied server specification. * - * @param specification Copied server specification. + * @param specification + * Copied server specification. * @return The recreated provider. */ protected abstract ServerProvider recreate(ServerSpecification specification); @@ -599,6 +603,7 @@ protected void rewriteTargetServerPropertiesWithReservedPort() * Reserves a target-server TCP port. * * @return A currently available local TCP port. + * * @throws MojoExecutionException * If no local TCP port could be reserved. */