Use generic SCSI TAPE product name and add more SCTP profiles

Author: rdmark

cpp/devices/device_factory.cpp

@@ -99,9 +99,7 @@ shared_ptr<PrimaryDevice> DeviceFactory::CreateDevice(PbDeviceType type, int lun
 
 	case SCTP:
 		device = make_shared<SCSIST>(lun);
-		// Masquerade as Tandberg
-		device->SetVendor("TANDBERG");
-		device->SetProduct(" TDC Streamer");
+		device->SetProduct("SCSI TAPE");
 		break;
 
 	default:

cpp/test/device_factory_test.cpp

@@ -252,25 +252,5 @@ TEST(DeviceFactoryTest, SCLP_Device_Defaults)
 
 TEST(DeviceFactoryTest, SCTP_Device_Defaults)
 {
-	DeviceFactory device_factory;
-
-	auto device = device_factory.CreateDevice(UNDEFINED, 0, "test.tap");
-	EXPECT_NE(nullptr, device);
-	EXPECT_EQ(SCTP, device->GetType());
-	EXPECT_TRUE(device->SupportsFile());
-	EXPECT_FALSE(device->SupportsParams());
-	EXPECT_TRUE(device->IsProtectable());
-	EXPECT_FALSE(device->IsProtected());
-	EXPECT_FALSE(device->IsReadOnly());
-	EXPECT_TRUE(device->IsRemovable());
-	EXPECT_FALSE(device->IsRemoved());
-	EXPECT_TRUE(device->IsLockable());
-	EXPECT_FALSE(device->IsLocked());
-	EXPECT_TRUE(device->IsStoppable());
-	EXPECT_FALSE(device->IsStopped());
-
-	EXPECT_EQ("TANDBERG", device->GetVendor());
-	EXPECT_EQ(" TDC Streamer", device->GetProduct());
-	EXPECT_EQ(string(piscsi_get_version_string()).substr(0, 2) + string(piscsi_get_version_string()).substr(3, 2),
-			device->GetRevision());
+	TestRemovableDrive(SCTP, "test.tap", "SCSI TAPE");
 }

python/web/src/drive_properties.json

@@ -450,9 +450,33 @@
     "revision": null,
     "block_size": "",
     "size": 262144000,
-    "name": "250 MB Cartridge",
+    "name": "Tandberg TDC 3600",
     "file_type": "tap",
-    "description": "DC 6250 Data Cartridge",
-    "url": ""
+    "description": "Tandberg TDC 3600 with DC6250 250 MB Data Cartridge",
+    "url": "https://web.archive.org/web/20200325013232/http://www.bitsavers.org/pdf/tandbergData/TDC_3620_3640_3660_Reference_Manual.pdf"
+},
+{
+    "device_type": "SCTP",
+    "vendor": "TANDBERG",
+    "product": " TDC 4100",
+    "revision": null,
+    "block_size": "",
+    "size": 1073741824,
+    "name": "Tandberg TDC 4100",
+    "file_type": "tap",
+    "description": "Tandberg TDC 4100 with DC9100 1 GB Data Cartridge",
+    "url": "https://web.archive.org/web/20240526132933/http://bitsavers.org/pdf/tandbergData/423042_TDC_4000_Series_SCSI-2_Interface_Functional_Specifications_May97.pdf"
+},
+{
+    "device_type": "SCTP",
+    "vendor": "TANDBERG",
+    "product": " TDC 4222",
+    "revision": null,
+    "block_size": "",
+    "size": 2147483648,
+    "name": "Tandberg TDC 4222",
+    "file_type": "tap",
+    "description": "Tandberg TDC 4222 with DC9200 2 GB Data Cartridge",
+    "url": "https://web.archive.org/web/20240526132933/http://bitsavers.org/pdf/tandbergData/423042_TDC_4000_Series_SCSI-2_Interface_Functional_Specifications_May97.pdf"
 }
 ]