Separe to GenericOpeningController?

[SrMouraSilva]

Opening components will possibly do the same operations, what changes is virtually communication. In this way, it is interesting to create a generic class that has all these operations.

In this way, creating a GenericOpeningComponent is useful for sparing development efforts.

[SrMouraSilva]

To separe what?! 🤔 I don't remember.

Suggestion, instead GenericOpeningController, create façades

Maybe I refered the handler layer (https://github.com/PedalPi/WebService/tree/master/webservice/handler)

Extract the methods for a GenericOpeningController and reimplement handle as a façade for GenericOpeningController. This way, I will reuse GenericOpeningController if need implement other opening methods like:

• a ORC protocol;
• a MIDI protocol;
• using a simple TCP connection;
• using a simple serial connection;

Currently I prefer instead to separate GenericOpeningController, reuse the WebService methods:
https://github.com/PedalPi/WebService/blob/master/webservice/webservice.py#L91-L160

Example - Serial connection:

Protocol

METHOD URL
DATA
EOF

Set current pedalboard

Based in: http://pedalpi.github.io/WebService/#current-management-manages-the-current-pedalboard-put

PUT /current/bank/1/pedalboard/3

Param value

Based in: http://pedalpi.github.io/WebService/#param-management-manages-a-param-by-index-position-get

GET /bank/1/pedalboard/3/effect/2/param/0

Based in: http://pedalpi.github.io/WebService/#param-management-manages-a-param-by-index-position-put

PUT /bank/1/pedalboard/3/effect/2/param/0
1.1901190476159431

Problems

The abstraction are based in devices with memory. Simple devices, as ESP8266 will not get all data from Pedal Pi or all plugins installed!

In a apk, the cell phone can be filter the necessary informations (the client can filter), but an ESP can't. The filter need be applied in the Pedal Pi opening component.

The PluginsManager strategy is to offer a simple interface for manage audio plugins.

Then, actually, I don't know if this issue is a good or a bad idea.

In the future, I will implement a simple USB pedal controller using a ESP, then I will have a opinion.

[SrMouraSilva]

Not separe. If necessary, uses:

• REST

from tornado.httpclient import HTTPRequest, AsyncHTTPClient, HTTPError

Example: WebServiceSerial - RequestMessageProcessor

• WebSocket

from tornado.websocket import websocket_connect

Example: WebServiceSerial - WebSocketClient