fix(codeql): suppress lgtm warnings, remove dead code, simplify elif chain

- Add # lgtm[py/ineffectual-statement] to overload stubs in pipeline.py
- Add # lgtm[py/bad-tag-filter] to _SUFFIX_RE in parser.py
- Add # lgtm[py/empty-except] to intentional bare-pass except blocks in tests
- Remove dead any_soda_results assignments in signs/__init__.py (L1/L2 branches)
- Remove unused Transformer import and _transformer variable in build_index.py
- Simplify redundant elif lower bounds in side_resolver.py (45<=angle<135 → angle<135)
- Mirror all src changes to custom_components/asp_parking/gps2asp/ vendored copy

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: Pascal-ZeGerman

custom_components/asp_parking/gps2asp/pipeline.py

@@ -23,7 +23,7 @@ async def resolve_asp(
     lon: float,
     debug: Literal[False] = ...,
     suspension_status: SuspensionInfo | None = ...,
-) -> ASPResult: ...
+) -> ASPResult: ...  # lgtm[py/ineffectual-statement]
 
 
 @overload
@@ -32,7 +32,7 @@ async def resolve_asp(
     lon: float,
     debug: Literal[True],
     suspension_status: SuspensionInfo | None = ...,
-) -> ASPDebugResult: ...
+) -> ASPDebugResult: ...  # lgtm[py/ineffectual-statement]
 
 
 async def resolve_asp(

custom_components/asp_parking/gps2asp/resolver/side_resolver.py

@@ -81,10 +81,10 @@ def determine_side(
     if 315 <= angle or angle < 45:
         # Segment runs roughly East: left=N, right=S
         return "N" if cross > 0 else "S"
-    elif 45 <= angle < 135:
+    elif angle < 135:
         # Segment runs roughly North: left=W, right=E
         return "W" if cross > 0 else "E"
-    elif 135 <= angle < 225:
+    elif angle < 225:
         # Segment runs roughly West: left=S, right=N
         return "S" if cross > 0 else "N"
     else:  # 225 <= angle < 315

custom_components/asp_parking/gps2asp/schedule/parser.py

@@ -58,7 +58,7 @@
 
 # Suffix: arrows (<->, -->) and optional SUPERSEDES clause.
 _SUFFIX_RE = re.compile(
-    r"\s*(?:<-+>|--+>)\s*(?:\(SUPERSEDES\s+[^)]+\))?\s*$",
+    r"\s*(?:<-+>|--+>)\s*(?:\(SUPERSEDES\s+[^)]+\))?\s*$",  # lgtm[py/bad-tag-filter]
     re.IGNORECASE,
 )
 

custom_components/asp_parking/gps2asp/signs/__init__.py

@@ -276,7 +276,6 @@ async def retrieve_signs(
         soda_level=1,
     )
     if result is not None:
-        any_soda_results = True
         logger.info(
             "Level 1 matched: on_street=%r, from=%r, to=%r (%d unique signs)",
             on_variants[0],
@@ -313,7 +312,6 @@ async def retrieve_signs(
             soda_level=2,
         )
         if result is not None:
-            any_soda_results = True
             logger.info(
                 "Level 2 matched: on_street=%r, from=%r, to=%r (%d unique signs)",
                 on_var,

scripts/build_index.py

@@ -29,7 +29,6 @@
 import geopandas as gpd
 import requests
 import zstandard
-from pyproj import Transformer
 from rtree import index as rtree_index
 
 from gps2asp.signs.normalize import normalize_to_soda
@@ -51,9 +50,6 @@
 CSCL_BATCH_SIZE = 10000
 SIGNS_BATCH_SIZE = 50000
 
-# WGS84 to EPSG:2263 transformer for reprojecting GeoJSON (which arrives in WGS84)
-_transformer = Transformer.from_crs("EPSG:4326", "EPSG:2263", always_xy=True)
-
 
 def _normalize_street_name(name: str) -> str:
     """Normalize a street name by expanding abbreviations and directional prefixes.

src/gps2asp/pipeline.py

@@ -23,7 +23,7 @@ async def resolve_asp(
     lon: float,
     debug: Literal[False] = ...,
     suspension_status: SuspensionInfo | None = ...,
-) -> ASPResult: ...
+) -> ASPResult: ...  # lgtm[py/ineffectual-statement]
 
 
 @overload
@@ -32,7 +32,7 @@ async def resolve_asp(
     lon: float,
     debug: Literal[True],
     suspension_status: SuspensionInfo | None = ...,
-) -> ASPDebugResult: ...
+) -> ASPDebugResult: ...  # lgtm[py/ineffectual-statement]
 
 
 async def resolve_asp(

src/gps2asp/resolver/side_resolver.py

@@ -87,10 +87,10 @@ def determine_side(
     if 315 <= angle or angle < 45:
         # Segment runs roughly East: left=N, right=S
         return "N" if cross > 0 else "S"
-    elif 45 <= angle < 135:
+    elif angle < 135:
         # Segment runs roughly North: left=W, right=E
         return "W" if cross > 0 else "E"
-    elif 135 <= angle < 225:
+    elif angle < 225:
         # Segment runs roughly West: left=S, right=N
         return "S" if cross > 0 else "N"
     else:  # 225 <= angle < 315

src/gps2asp/schedule/parser.py

@@ -58,7 +58,7 @@
 
 # Suffix: arrows (<->, -->) and optional SUPERSEDES clause.
 _SUFFIX_RE = re.compile(
-    r"\s*(?:<-+>|--+>)\s*(?:\(SUPERSEDES\s+[^)]+\))?\s*$",
+    r"\s*(?:<-+>|--+>)\s*(?:\(SUPERSEDES\s+[^)]+\))?\s*$",  # lgtm[py/bad-tag-filter]
     re.IGNORECASE,
 )
 

src/gps2asp/signs/__init__.py

@@ -279,7 +279,6 @@ async def retrieve_signs(
         soda_level=1,
     )
     if result is not None:
-        any_soda_results = True
         logger.info(
             "Level 1 matched: on_street=%r, from=%r, to=%r (%d unique signs)",
             on_variants[0],
@@ -316,7 +315,6 @@ async def retrieve_signs(
             soda_level=2,
         )
         if result is not None:
-            any_soda_results = True
             logger.info(
                 "Level 2 matched: on_street=%r, from=%r, to=%r (%d unique signs)",
                 on_var,

tests/test_edge_cases.py

@@ -189,7 +189,7 @@ async def test_divided_road_eastern_parkway(self, spatial_index_dir):
             # are approximate, but it should resolve to something
             assert isinstance(result.on_street, str)
             assert len(result.on_street) > 0
-        except (AmbiguousResolutionError, NoSegmentFoundError):
+        except (AmbiguousResolutionError, NoSegmentFoundError):  # lgtm[py/empty-except]
             pass
 
 
@@ -208,7 +208,7 @@ async def test_manhattan_midtown(self, spatial_index_dir):
             )
             assert isinstance(result.on_street, str)
             assert result.side_of_street in ("N", "S", "E", "W")
-        except (AmbiguousResolutionError, NoSegmentFoundError):
+        except (AmbiguousResolutionError, NoSegmentFoundError):  # lgtm[py/empty-except]
             pass
 
     async def test_queens_astoria(self, spatial_index_dir):
@@ -221,7 +221,7 @@ async def test_queens_astoria(self, spatial_index_dir):
                 index_dir=spatial_index_dir,
             )
             assert isinstance(result.on_street, str)
-        except (AmbiguousResolutionError, NoSegmentFoundError):
+        except (AmbiguousResolutionError, NoSegmentFoundError):  # lgtm[py/empty-except]
             pass
 
     async def test_bronx_grand_concourse(self, spatial_index_dir):
@@ -234,5 +234,5 @@ async def test_bronx_grand_concourse(self, spatial_index_dir):
                 index_dir=spatial_index_dir,
             )
             assert isinstance(result.on_street, str)
-        except (AmbiguousResolutionError, NoSegmentFoundError):
+        except (AmbiguousResolutionError, NoSegmentFoundError):  # lgtm[py/empty-except]
             pass