Skip to content

Commit 7ccc097

Browse files
committed
refactor(webui): remove redundant chamber temperature clamp
The range check already rejects values above CHAMBER_MAX_TEMP, so the follow-up Math.min was dead code. Flagged by Gemini Code Assist.
1 parent e1006fd commit 7ccc097

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

src/webui/static/ui/dialogs.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -239,21 +239,19 @@ export async function setTemperature(): Promise<void> {
239239
}
240240

241241
const target = dialog.temperatureTarget;
242-
let temperature = parseInt(input.value, 10);
242+
const temperature = parseInt(input.value, 10);
243243

244244
if (!target) {
245245
showToast('Unknown temperature target', 'error');
246246
return;
247247
}
248248

249+
// Chamber is capped at CHAMBER_MAX_TEMP by the range check below (no separate clamp needed).
249250
const maxTemperature = target.kind === 'chamber' ? CHAMBER_MAX_TEMP : 300;
250251
if (Number.isNaN(temperature) || temperature < 0 || temperature > maxTemperature) {
251252
showToast('Invalid temperature value', 'error');
252253
return;
253254
}
254-
if (target.kind === 'chamber') {
255-
temperature = Math.min(temperature, CHAMBER_MAX_TEMP);
256-
}
257255

258256
if (!dialogHandlers.onTemperatureSubmit) {
259257
showToast('Temperature control unavailable', 'error');

0 commit comments

Comments
 (0)