fix: update CI workflow and format terraform code

- TFLint: use --minimum-failure-severity=error (warnings don't fail CI)
- Run terraform fmt -recursive for canonical formatting

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: JoshLuedeman

.github/workflows/ci.yml

@@ -62,7 +62,7 @@ jobs:
           GITHUB_TOKEN: ${{ github.token }}
 
       - name: Run TFLint
-        run: tflint --recursive --format compact
+        run: tflint --recursive --format compact --minimum-failure-severity=error
 
   terraform-plan:
     name: "📋 Plan (Validation)"

tests/plugin-cache/main.tf

@@ -1,4 +1,4 @@
 provider "acme" {
-  version = "1.4.0"
+  version    = "1.4.0"
   server_url = "https://acme-staging-v02.api.letsencrypt.org/directory"
 }

tests/workflows/pull_request_review/main.tf

@@ -1,5 +1,5 @@
 resource "random_string" "my_string" {
-  length      = 11
+  length = 11
 }
 
 output "output_string" {

tests/workflows/pull_request_target/main.tf

@@ -1,5 +1,5 @@
 resource "random_string" "my_string" {
-  length      = 11
+  length = 11
 }
 
 output "output_string" {

tests/workflows/test-apply/apply-error/main.tf

@@ -5,6 +5,6 @@ resource "aws_s3_bucket" "my_bucket" {
   bucket = "hello"
 }
 
-provider aws {
+provider "aws" {
   region = "eu-west-2"
 }

tests/workflows/test-apply/changes/main.tf

@@ -1,5 +1,5 @@
 resource "random_string" "my_string" {
-  length      = 11
+  length = 11
 }
 
 output "output_string" {

tests/workflows/test-apply/deprecated_var/main.tf

@@ -1,18 +1,18 @@
 resource "random_string" "my_string" {
-  length      = 11
+  length = 11
 }
 
 output "output_string" {
   value = "the_string"
 }
 
 variable "my_var" {
-  type = string
+  type    = string
   default = "my_var_default"
 }
 
 variable "my_var_from_file" {
-  type = string
+  type    = string
   default = "my_var_from_file_default"
 }
 

tests/workflows/test-apply/destroy_mode/main.tf

@@ -1,5 +1,5 @@
 resource "random_string" "my_string" {
-  length      = 11
+  length = 11
 }
 
 output "output_string" {

tests/workflows/test-apply/error/main.tf

@@ -1,3 +1,3 @@
 resource "random_string" "my_string" {
-  length      = "ten"
+  length = "ten"
 }

tests/workflows/test-apply/long_plan/main.tf

@@ -9,6 +9,6 @@ resource "random_id" "b" {
 }
 
 variable "length" {
-  type = number
+  type    = number
   default = 3
 }