Skip to content

No automated contract test between this API and the Globe-Wallet/mobile clients #50

Description

@ndii-dev

Three other repos (Globe-Wallet, mobile) are described in this README as consumers of this API, but there's no contract/integration test anywhere confirming their expected request/response shapes actually match what this service returns (especially now that /wallet/send responses would need to reflect any future changes like fee-bump or structured error codes from other issues here). Set up cross-repo contract testing.

Definition of done:

  • Machine-checkable contract (e.g. generated from the OpenAPI spec once it exists) that consumer repos can validate against
  • CI in this repo fails if a response shape changes in a way that would break the documented contract
  • At minimum, the /wallet/send and /account/:publicKey/balances shapes (the two most directly consumed) are covered first

Before opening a PR for this issue, read CONTRIBUTING.md.

This is not a starter-issue. The Definition of done above is the full
acceptance criteria, not a subset to sample from — a PR that addresses part
of it is an unfinished issue, not a smaller one. Your PR must include, in
the PR description itself:

  • Root cause / design-decision rationale in your own words — not a restatement of this issue
  • Every Definition of done bullet above addressed explicitly, with a one-line note on how
  • Evidence the code actually runs: pasted test/build output, a screen recording or before/after screenshots for UI changes, or real (non-mocked) logs for network/contract-facing work
  • New or updated tests included and shown passing (paste the output)
  • Any adjacent/related behavior this issue calls out re-verified, not assumed unaffected

PRs missing these will be sent back before review, not reviewed and rejected — please do this up front.

Metadata

Metadata

Assignees

No one assigned

    Labels

    GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardOfficial Campaign | FWC26Campaign: Official Campaign | FWC26

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions