Missing check for null address in Address.sendValue

[AntonGulak]

https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/Address.sol#L41

Expected: The function should revert if the recipient is the zero address.
Actual: The function sends the Ether to the zero address, effectively burning it.

The function should include a check for the recipient != address(0) before proceeding with the transfer. Without this check, if the recipient is accidentally set as the zero address, any Ether sent using this function will be permanently lost.

[Amxx]

Thanks you @AntonGulak for raising this issue.

I'm not quite sure if we want to treat address(0) in a specific way here. I see arguments both for and against.
Adding it to the "idea box" for the next release.

[AntonGulak]

Thanks you @AntonGulak for raising this issue.

I'm not quite sure if we want to treat address(0) in a specific way here. I see arguments both for and against. Adding it to the "idea box" for the next release.

What are the scenarios where it's necessary to send Ether to the zero address? The only situation I can think of is burning it, but that seems like a very specific case.

At the very least, when zero address validation is needed, a negative test case is required. In cases where sending to the zero address is also necessary, a positive test case will be needed and will be tested regardless. This is because, upon quick review, it may seem that the .call() automatically validates the zero address, eliminating the need for any additional checks.

[ZhangPeibin]

I don't know if it's too late to answer now.
I don't think it is necessary to add the check of null address.
If you add this check , then some scenarios that need to be sent to the 0 address will no longer apply.
oz only needs to ensure the execution of sendValue, and does not need to care whether to is a null address.
What really needs to be checked is the caller of sendvalue