Commit fb8a0de
authored
feat(consent): log where the consent window was opened (#107)
#106 made a window that cannot be created a logged denial. The remaining
blind spot is the opposite case: creation succeeds, a window id comes
back, and the user still sees nothing.
Those two are indistinguishable from the outside -- "no popup, no errors"
-- and that ambiguity is exactly what made the silent hang take days to
find. A window id proves creation succeeded; it does not prove the window
is visible.
consentWindowBounds derives left/top from chrome.windows.getLastFocused(),
so a minimised window, a second display, or an undocked DevTools window
can place the prompt somewhere the user never looks. Logging the id and
the computed bounds makes "I see no popup" answerable: either no line
(never reached creation), the #106 error (creation failed), or a line
naming coordinates that can be checked against the actual displays.
Logging only; no behaviour change. Both consent surfaces.
Signed-off-by: Glenn Gore <glenn.g@affinidi.com>1 parent 9af5cda commit fb8a0de
1 file changed
Lines changed: 24 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
592 | 592 | | |
593 | 593 | | |
594 | 594 | | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
595 | 607 | | |
596 | 608 | | |
597 | 609 | | |
| |||
678 | 690 | | |
679 | 691 | | |
680 | 692 | | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
681 | 705 | | |
682 | 706 | | |
683 | 707 | | |
| |||
0 commit comments